fbdev/tridentfb: replace printk() with dev_*() in probe

[PATCH] fbdev/tridentfb: replace printk() with dev_*() in probe

Posted by Javier Garcia 2 months, 3 weeks ago

- Replace in `trident_pc_probe()` printk by dev_* fn's
- Delete the prefix `tridentfb:` from msg strings, not needed now.

Signed-off-by: Javier Garcia <rampxxxx@gmail.com>
---
 drivers/video/fbdev/tridentfb.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/video/fbdev/tridentfb.c b/drivers/video/fbdev/tridentfb.c
index 516cf2a18757..17b7253b8fbe 100644
--- a/drivers/video/fbdev/tridentfb.c
+++ b/drivers/video/fbdev/tridentfb.c
@@ -1631,7 +1631,7 @@ static int trident_pci_probe(struct pci_dev *dev,
 	}
 
 	if (noaccel) {
-		printk(KERN_DEBUG "disabling acceleration\n");
+		dev_dbg(&dev->dev, "disabling acceleration\n");
 		info->flags |= FBINFO_HWACCEL_DISABLED;
 		info->pixmap.scan_align = 1;
 	}
@@ -1693,7 +1693,7 @@ static int trident_pci_probe(struct pci_dev *dev,
 	info->var.activate |= FB_ACTIVATE_NOW;
 	info->device = &dev->dev;
 	if (register_framebuffer(info) < 0) {
-		printk(KERN_ERR "tridentfb: could not register framebuffer\n");
+		dev_err(&dev->dev, "could not register framebuffer\n");
 		fb_dealloc_cmap(&info->cmap);
 		err = -EINVAL;
 		goto out_unmap2;
-- 
2.50.1

Re: [PATCH] fbdev/tridentfb: replace printk() with dev_*() in probe

Posted by Helge Deller 2 months ago

On 11/15/25 13:57, Javier Garcia wrote:
> - Replace in `trident_pc_probe()` printk by dev_* fn's
> - Delete the prefix `tridentfb:` from msg strings, not needed now.
> 
> Signed-off-by: Javier Garcia <rampxxxx@gmail.com>
> ---
>   drivers/video/fbdev/tridentfb.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)

applied.

Thanks!
Helge

Re: [PATCH] fbdev/tridentfb: replace printk() with dev_*() in probe

Posted by Javier Garcia 2 months, 2 weeks ago

Hi Deller,

Any comments on this patch?,

Thanks!

---
Javier Garcia

On Sat, 15 Nov 2025 at 13:57, Javier Garcia <rampxxxx@gmail.com> wrote:
>
> - Replace in `trident_pc_probe()` printk by dev_* fn's
> - Delete the prefix `tridentfb:` from msg strings, not needed now.
>
> Signed-off-by: Javier Garcia <rampxxxx@gmail.com>
> ---
>  drivers/video/fbdev/tridentfb.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/tridentfb.c b/drivers/video/fbdev/tridentfb.c
> index 516cf2a18757..17b7253b8fbe 100644
> --- a/drivers/video/fbdev/tridentfb.c
> +++ b/drivers/video/fbdev/tridentfb.c
> @@ -1631,7 +1631,7 @@ static int trident_pci_probe(struct pci_dev *dev,
>         }
>
>         if (noaccel) {
> -               printk(KERN_DEBUG "disabling acceleration\n");
> +               dev_dbg(&dev->dev, "disabling acceleration\n");
>                 info->flags |= FBINFO_HWACCEL_DISABLED;
>                 info->pixmap.scan_align = 1;
>         }
> @@ -1693,7 +1693,7 @@ static int trident_pci_probe(struct pci_dev *dev,
>         info->var.activate |= FB_ACTIVATE_NOW;
>         info->device = &dev->dev;
>         if (register_framebuffer(info) < 0) {
> -               printk(KERN_ERR "tridentfb: could not register framebuffer\n");
> +               dev_err(&dev->dev, "could not register framebuffer\n");
>                 fb_dealloc_cmap(&info->cmap);
>                 err = -EINVAL;
>                 goto out_unmap2;
> --
> 2.50.1
>