drivers/pwm/pwm-adp5585.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
From: Luke Wang <ziniu.wang_1@nxp.com>
The register addresses of ADP5585 and ADP5589 are swapped.
Fixes: 75024f97e82e ("pwm: adp5585: add support for adp5589")
Signed-off-by: Luke Wang <ziniu.wang_1@nxp.com>
Tested-by: Liu Ying <victor.liu@nxp.com>
Acked-by: Nuno Sá <nuno.sa@analog.com>
---
v2: amend commit message
---
drivers/pwm/pwm-adp5585.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pwm/pwm-adp5585.c b/drivers/pwm/pwm-adp5585.c
index dc2860979e24..806f8d79b0d7 100644
--- a/drivers/pwm/pwm-adp5585.c
+++ b/drivers/pwm/pwm-adp5585.c
@@ -190,13 +190,13 @@ static int adp5585_pwm_probe(struct platform_device *pdev)
return 0;
}
-static const struct adp5585_pwm_chip adp5589_pwm_chip_info = {
+static const struct adp5585_pwm_chip adp5585_pwm_chip_info = {
.pwm_cfg = ADP5585_PWM_CFG,
.pwm_offt_low = ADP5585_PWM_OFFT_LOW,
.pwm_ont_low = ADP5585_PWM_ONT_LOW,
};
-static const struct adp5585_pwm_chip adp5585_pwm_chip_info = {
+static const struct adp5585_pwm_chip adp5589_pwm_chip_info = {
.pwm_cfg = ADP5589_PWM_CFG,
.pwm_offt_low = ADP5589_PWM_OFFT_LOW,
.pwm_ont_low = ADP5589_PWM_ONT_LOW,
--
2.34.1
Hello,
On Fri, Nov 14, 2025 at 06:42:50PM +0800, ziniu.wang_1@nxp.com wrote:
> From: Luke Wang <ziniu.wang_1@nxp.com>
>
> The register addresses of ADP5585 and ADP5589 are swapped.
>
> Fixes: 75024f97e82e ("pwm: adp5585: add support for adp5589")
>
> Signed-off-by: Luke Wang <ziniu.wang_1@nxp.com>
> Tested-by: Liu Ying <victor.liu@nxp.com>
> Acked-by: Nuno Sá <nuno.sa@analog.com>
> ---
> v2: amend commit message
Note that I already applied (implicit) v1 and replaced the wording as I
suggested.
Also typically there is no empty line between Fixes: and the S-o-b area
(also fixed).
See https://git.kernel.org/pub/scm/linux/kernel/git/ukleinek/linux.git/commit/?h=pwm/for-next&id=f84fd5bec502447df145f31734793714690ce27f
Best regards
Uwe
© 2016 - 2026 Red Hat, Inc.