.../boot/dts/rockchip/rk3568-9tripod-x3568-v4.dts | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)
The regulator type is "regulator-fixed" since its voltage always be
3.3v, min and max should be 3300000 make the regulator has a voltage
The regulator is supplied by dc_12v, so add the vin-supply.
Link: https://github.com/rockchip-linux/kernel/commit/17e9559f67d26f3c602e38a24feb5194e51ac782
Signed-off-by: Coia Prant <coiaprant@gmail.com>
---
.../boot/dts/rockchip/rk3568-9tripod-x3568-v4.dts | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3568-9tripod-x3568-v4.dts b/arch/arm64/boot/dts/rockchip/rk3568-9tripod-x3568-v4.dts
index ad4d62060..32fda9f5e 100644
--- a/arch/arm64/boot/dts/rockchip/rk3568-9tripod-x3568-v4.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3568-9tripod-x3568-v4.dts
@@ -170,16 +170,16 @@ vcc3v3_sys: regulator-vcc3v3-sys {
};
vcc3v3_pcie: regulator-vcc3v3-pcie {
- compatible = "regulator-gpio";
- regulator-name = "vcc3v3_pcie";
- regulator-min-microvolt = <100000>;
- regulator-max-microvolt = <3300000>;
+ compatible = "regulator-fixed";
+ enable-active-high;
+ gpio = <&gpio3 RK_PC3 GPIO_ACTIVE_HIGH>;
pinctrl-names = "default";
pinctrl-0 = <&vcc3v3_pcie_en_pin>;
- gpios = <&gpio3 RK_PC3 GPIO_ACTIVE_HIGH>;
- gpios-states = <1>;
- states = <100000 0>, <3300000 1>;
+ regulator-name = "vcc3v3_pcie";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
startup-delay-us = <5000>;
+ vin-supply = <&dc_12v>;
};
vcc5v0_sys: regulator-vcc5v0-sys {
--
2.47.3
On Fri, 14 Nov 2025 17:21:15 +0800, Coia Prant wrote:
> The regulator type is "regulator-fixed" since its voltage always be
> 3.3v, min and max should be 3300000 make the regulator has a voltage
>
> The regulator is supplied by dc_12v, so add the vin-supply.
>
>
Applied, thanks!
[1/1] arm64: dts: rockchip: fix PCIe 3.3V regulator voltage on 9Tripod X3568 v4
commit: c8ecda015eb4070ced887eba34cdb60737a9893b
Changes "gpio" to the correct "gpios" property.
"gpio" only works because the kernel handles this common mistake :-) .
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
© 2016 - 2026 Red Hat, Inc.