The iguanair_disconnect() function calls rc_unregister_device() before
usb_kill_urb(), creating a race condition similar to the one fixed in
commit 'f656cfbc7a29'. If rc_unregister_device() executes while
the URB callback iguanair_rx() is still running, process_ir_data() may call
ir_raw_event_store_with_filter() or ir_raw_event_overflow() with a freed
ir->rc->raw pointer, leading to a NULL pointer dereference.
Call usb_kill_urb() before rc_unregister_device() to ensure all URB
callbacks complete before freeing device resources.
Fixes: 7c0bd96b767d ("[media] iguanair: support suspend and resume")
Signed-off-by: Haotian Zhang <vulab@iscas.ac.cn>
---
drivers/media/rc/iguanair.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/rc/iguanair.c b/drivers/media/rc/iguanair.c
index 8af94246e591..70105250d88d 100644
--- a/drivers/media/rc/iguanair.c
+++ b/drivers/media/rc/iguanair.c
@@ -496,10 +496,10 @@ static void iguanair_disconnect(struct usb_interface *intf)
{
struct iguanair *ir = usb_get_intfdata(intf);
- rc_unregister_device(ir->rc);
usb_set_intfdata(intf, NULL);
usb_kill_urb(ir->urb_in);
usb_kill_urb(ir->urb_out);
+ rc_unregister_device(ir->rc);
usb_free_urb(ir->urb_in);
usb_free_urb(ir->urb_out);
usb_free_coherent(ir->udev, MAX_IN_PACKET, ir->buf_in, ir->dma_in);
--
2.50.1.windows.1