[PATCH v3 1/4] dt-bindings: misc: qcom,fastrpc: Add compatible for Kaanapali

Kumari Pallavi posted 4 patches 2 months, 3 weeks ago
There is a newer version of this series
[PATCH v3 1/4] dt-bindings: misc: qcom,fastrpc: Add compatible for Kaanapali
Posted by Kumari Pallavi 2 months, 3 weeks ago
Add a new compatible string "qcom,kaanapali-fastrpc" to support
for Kaanapali SoC.

Signed-off-by: Kumari Pallavi <kumari.pallavi@oss.qualcomm.com>
---
 Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml b/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml
index 3f6199fc9ae6..13ba91fe1176 100644
--- a/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml
+++ b/Documentation/devicetree/bindings/misc/qcom,fastrpc.yaml
@@ -18,7 +18,10 @@ description: |
 
 properties:
   compatible:
-    const: qcom,fastrpc
+    items:
+    - enum:
+       - qcom,kaanapali-fastrpc
+       - qcom,fastrpc
 
   label:
     enum:
-- 
2.34.1
Re: [PATCH v3 1/4] dt-bindings: misc: qcom,fastrpc: Add compatible for Kaanapali
Posted by Krzysztof Kozlowski 2 months, 3 weeks ago
On 14/11/2025 09:41, Kumari Pallavi wrote:
> Add a new compatible string "qcom,kaanapali-fastrpc" to support
> for Kaanapali SoC.
> 
> Signed-off-by: Kumari Pallavi <kumari.pallavi@oss.qualcomm.com>
> ---

You not only did not bother to test it - there are obvious bugs here -
but you also did not send it to mailing lists for actual testing by
Rob's bot.

NAK

Best regards,
Krzysztof
Re: [PATCH v3 1/4] dt-bindings: misc: qcom,fastrpc: Add compatible for Kaanapali
Posted by Kumari Pallavi 2 months, 3 weeks ago

On 11/14/2025 9:17 PM, Krzysztof Kozlowski wrote:
> On 14/11/2025 09:41, Kumari Pallavi wrote:
>> Add a new compatible string "qcom,kaanapali-fastrpc" to support
>> for Kaanapali SoC.
>>
>> Signed-off-by: Kumari Pallavi <kumari.pallavi@oss.qualcomm.com>
>> ---
> 
> You not only did not bother to test it - there are obvious bugs here -
> but you also did not send it to mailing lists for actual testing by
> Rob's bot.
> 
> NAK
> 
> Best regards,
> Krzysztof

Thank you for the feedback. I did run the schema validation locally using:
make dt_binding_check
(as per 
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/), 
and the build completed successfully without any errors.
Ack that I missed adding the mailing lists in the initial submission due 
to an issue with the script I used for retrieving mailing addresses 
locally.
I’ll make sure to include the correct mailing lists in the next revision.

Thanks,
Pallavi

Re: [PATCH v3 1/4] dt-bindings: misc: qcom,fastrpc: Add compatible for Kaanapali
Posted by Krzysztof Kozlowski 2 months, 3 weeks ago
On 17/11/2025 08:17, Kumari Pallavi wrote:
> 
> 
> On 11/14/2025 9:17 PM, Krzysztof Kozlowski wrote:
>> On 14/11/2025 09:41, Kumari Pallavi wrote:
>>> Add a new compatible string "qcom,kaanapali-fastrpc" to support
>>> for Kaanapali SoC.
>>>
>>> Signed-off-by: Kumari Pallavi <kumari.pallavi@oss.qualcomm.com>
>>> ---
>>
>> You not only did not bother to test it - there are obvious bugs here -
>> but you also did not send it to mailing lists for actual testing by
>> Rob's bot.
>>
>> NAK
>>
>> Best regards,
>> Krzysztof
> 
> Thank you for the feedback. I did run the schema validation locally using:
> make dt_binding_check
> (as per 
> https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/), 
> and the build completed successfully without any errors.

But you did not read warnings and messages shown to you...

That's still obviously NAK.

Best regards,
Krzysztof