1. Patchew
  2. linux
  3. View series

[PATCH v2] ASoC: qcom: sdm845: set quaternary MI2S codec DAI to I2S format

David Heidelberg via B4 Relay posted 1 patch 2 months, 3 weeks ago
There is a newer version of this series
sound/soc/qcom/sdm845.c | 2 ++
1 file changed, 2 insertions(+)
[PATCH v2] ASoC: qcom: sdm845: set quaternary MI2S codec DAI to I2S format
Posted by David Heidelberg via B4 Relay 2 months, 3 weeks ago 
From: "Dr. Git" <drgitx@gmail.com>

We configure the codec DAI format for primary and secondary but not the
quaternery MI2S path. Add the missing configuration to enable speaker
codecs on the quaternary MI2S like the MAX9827 found on the OnePlus 6.

Signed-off-by: Dr. Git <drgitx@gmail.com>
Signed-off-by: Casey Connolly <casey.connolly@linaro.org>
Signed-off-by: David Heidelberg <david@ixit.cz>
---
Changes in v2:
 - Rebased on top of next-20251113
---
 sound/soc/qcom/sdm845.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sound/soc/qcom/sdm845.c b/sound/soc/qcom/sdm845.c
index e18a8e44f2db5..0ce9dff4dc525 100644
--- a/sound/soc/qcom/sdm845.c
+++ b/sound/soc/qcom/sdm845.c
@@ -365,10 +365,12 @@ static int sdm845_snd_startup(struct snd_pcm_substream *substream)
 		snd_soc_dai_set_fmt(codec_dai, codec_dai_fmt);
 		break;
 	case QUATERNARY_MI2S_RX:
+		codec_dai_fmt |= SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_I2S;
 		snd_soc_dai_set_sysclk(cpu_dai,
 			Q6AFE_LPASS_CLK_ID_QUAD_MI2S_IBIT,
 			MI2S_BCLK_RATE, SNDRV_PCM_STREAM_PLAYBACK);
 		snd_soc_dai_set_fmt(cpu_dai, fmt);
+		snd_soc_dai_set_fmt(codec_dai, codec_dai_fmt);
 		break;
 
 	case QUATERNARY_TDM_RX_0:

---
base-commit: 6d7e7251d03f98f26f2ee0dfd21bb0a0480a2178
change-id: 20251114-sdm845-quaternary-e9d6d0b513c9

Best regards,
-- 
David Heidelberg <david@ixit.cz>
Re: [PATCH v2] ASoC: qcom: sdm845: set quaternary MI2S codec DAI to I2S format
Posted by Srinivas Kandagatla 2 months, 3 weeks ago 

On 11/14/25 12:14 AM, David Heidelberg via B4 Relay wrote:
> From: "Dr. Git" <drgitx@gmail.com>
> 
> We configure the codec DAI format for primary and secondary but not the
> quaternery MI2S path. Add the missing configuration to enable speaker
> codecs on the quaternary MI2S like the MAX9827 found on the OnePlus 6.
> 
> Signed-off-by: Dr. Git <drgitx@gmail.com>

Please fix your git user.name, looks like "Dr. Git" is not your real name.


Other than that patch itself looks sane to me.

--srini



> Signed-off-by: Casey Connolly <casey.connolly@linaro.org>
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
> Changes in v2:
>  - Rebased on top of next-20251113
> ---
>  sound/soc/qcom/sdm845.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/sound/soc/qcom/sdm845.c b/sound/soc/qcom/sdm845.c
> index e18a8e44f2db5..0ce9dff4dc525 100644
> --- a/sound/soc/qcom/sdm845.c
> +++ b/sound/soc/qcom/sdm845.c
> @@ -365,10 +365,12 @@ static int sdm845_snd_startup(struct snd_pcm_substream *substream)
>  		snd_soc_dai_set_fmt(codec_dai, codec_dai_fmt);
>  		break;
>  	case QUATERNARY_MI2S_RX:
> +		codec_dai_fmt |= SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_I2S;
>  		snd_soc_dai_set_sysclk(cpu_dai,
>  			Q6AFE_LPASS_CLK_ID_QUAD_MI2S_IBIT,
>  			MI2S_BCLK_RATE, SNDRV_PCM_STREAM_PLAYBACK);
>  		snd_soc_dai_set_fmt(cpu_dai, fmt);
> +		snd_soc_dai_set_fmt(codec_dai, codec_dai_fmt);
>  		break;
>  
>  	case QUATERNARY_TDM_RX_0:
> 
> ---
> base-commit: 6d7e7251d03f98f26f2ee0dfd21bb0a0480a2178
> change-id: 20251114-sdm845-quaternary-e9d6d0b513c9
> 
> Best regards,
Re: [PATCH v2] ASoC: qcom: sdm845: set quaternary MI2S codec DAI to I2S format
Posted by David Heidelberg 2 months, 3 weeks ago 
On 14/11/2025 13:33, Srinivas Kandagatla wrote:
> 
> 
> On 11/14/25 12:14 AM, David Heidelberg via B4 Relay wrote:
>> From: "Dr. Git" <drgitx@gmail.com>
>>
>> We configure the codec DAI format for primary and secondary but not the
>> quaternery MI2S path. Add the missing configuration to enable speaker
>> codecs on the quaternary MI2S like the MAX9827 found on the OnePlus 6.
>>
>> Signed-off-by: Dr. Git <drgitx@gmail.com>
> 
> Please fix your git user.name, looks like "Dr. Git" is not your real name.

Dr. Git is author of the patch. He's known contributor to the Snapdragon 
845 close to mainline tree. I'll ask, if he'd like to provide different 
name.

If not, I would be glad if known identity could be used for this patch 
[1] (consider my S-off-by as confirmation of known identity).

David

[1] 
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=d4563201f33a022fc0353033d9dfeb1606a88330

> 
> 
> Other than that patch itself looks sane to me.
> 
> --srini
> 
> 
> 
>> Signed-off-by: Casey Connolly <casey.connolly@linaro.org>
>> Signed-off-by: David Heidelberg <david@ixit.cz>
>> ---
>> Changes in v2:
>>   - Rebased on top of next-20251113
>> ---
>>   sound/soc/qcom/sdm845.c | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/sound/soc/qcom/sdm845.c b/sound/soc/qcom/sdm845.c
>> index e18a8e44f2db5..0ce9dff4dc525 100644
>> --- a/sound/soc/qcom/sdm845.c
>> +++ b/sound/soc/qcom/sdm845.c
>> @@ -365,10 +365,12 @@ static int sdm845_snd_startup(struct snd_pcm_substream *substream)
>>   		snd_soc_dai_set_fmt(codec_dai, codec_dai_fmt);
>>   		break;
>>   	case QUATERNARY_MI2S_RX:
>> +		codec_dai_fmt |= SND_SOC_DAIFMT_NB_NF | SND_SOC_DAIFMT_I2S;
>>   		snd_soc_dai_set_sysclk(cpu_dai,
>>   			Q6AFE_LPASS_CLK_ID_QUAD_MI2S_IBIT,
>>   			MI2S_BCLK_RATE, SNDRV_PCM_STREAM_PLAYBACK);
>>   		snd_soc_dai_set_fmt(cpu_dai, fmt);
>> +		snd_soc_dai_set_fmt(codec_dai, codec_dai_fmt);
>>   		break;
>>   
>>   	case QUATERNARY_TDM_RX_0:
>>
>> ---
>> base-commit: 6d7e7251d03f98f26f2ee0dfd21bb0a0480a2178
>> change-id: 20251114-sdm845-quaternary-e9d6d0b513c9
>>
>> Best regards,
> 

-- 
David Heidelberg

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.