[v1] Add FRDM i.MX 91 Development board support

[PATCH 2/2] dt-bindings: arm: imx Add FRDM-IMX91 board

Posted by Joseph Guo 2 months, 3 weeks ago

Add the board FRDM-IMX91 in the binding document.

Signed-off-by: Joseph Guo <qijian.guo@nxp.com>
---
 Documentation/devicetree/bindings/arm/fsl.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
index 00cdf490b0620bf537330ee9342a197f13c8c8ab..402c735bafe97236a2f4790f914ef56a4156b0f0 100644
--- a/Documentation/devicetree/bindings/arm/fsl.yaml
+++ b/Documentation/devicetree/bindings/arm/fsl.yaml
@@ -1409,6 +1409,7 @@ properties:
         items:
           - enum:
               - fsl,imx91-11x11-evk       # i.MX91 11x11 EVK Board
+              - fsl,frdm-imx91            # FRDM i.MX91 Development Board
           - const: fsl,imx91
 
       - description: i.MX93 based Boards

-- 
2.34.1

Re: [PATCH 2/2] dt-bindings: arm: imx Add FRDM-IMX91 board

Posted by Daniel Baluta 2 months, 3 weeks ago

Hi Joseph,

Thanks for your patch.

<snip>

>                - fsl,imx91-11x11-evk       # i.MX91 11x11 EVK Board
> +              - fsl,frdm-imx91            # FRDM i.MX91 Development Board
>            - const: fsl,imx91

Community pattern of creating compatibles is fsl,imx91-frdm.

Even we have some internal expectations we need to adhere to community
practices.

Daniel.

Re: [PATCH 2/2] dt-bindings: arm: imx Add FRDM-IMX91 board

Posted by Krzysztof Kozlowski 2 months, 3 weeks ago

On 14/11/2025 07:55, Joseph Guo wrote:
> Add the board FRDM-IMX91 in the binding document.
> 
> Signed-off-by: Joseph Guo <qijian.guo@nxp.com>
> ---
>  Documentation/devicetree/bindings/arm/fsl.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index 00cdf490b0620bf537330ee9342a197f13c8c8ab..402c735bafe97236a2f4790f914ef56a4156b0f0 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -1409,6 +1409,7 @@ properties:
>          items:
>            - enum:
>                - fsl,imx91-11x11-evk       # i.MX91 11x11 EVK Board
> +              - fsl,frdm-imx91            # FRDM i.MX91 Development Board

You received comments already the order of board/soc is wrong, but still
push own version. No, read the feedback people gave you.

Please organize the patch documenting the compatible (DT bindings)
before the patch using that compatible.
See also:
https://elixir.bootlin.com/linux/v6.14-rc6/source/Documentation/devicetree/bindings/submitting-patches.rst#L46


>            - const: fsl,imx91
>  
>        - description: i.MX93 based Boards
> 


Best regards,
Krzysztof