1. Patchew
  2. linux
  3. [PATCH 0/3] arm64: dts: freescale: moduline-display: several fixes
  4. View patch

[PATCH 1/3] dt-bindings: arm: fsl: moduline-display: fix compatible

Maud Spierings via B4 Relay posted 3 patches 2 months, 3 weeks ago
There is a newer version of this series
[PATCH 1/3] dt-bindings: arm: fsl: moduline-display: fix compatible
Posted by Maud Spierings via B4 Relay 2 months, 3 weeks ago 
From: Maud Spierings <maudspierings@gocontroll.com>

The compatibles should include the SoM compatible, this board is based
on the Ka-Ro TX8P-ML81 SoM, so add it. Also add the hardware revision to
the board compatible.

This is a breaking change, but it is early enough that it can be
corrected without causing any issues.

Fixes: 24e67d28ef95 ("dt-bindings: arm: fsl: Add GOcontroll Moduline Display")
Signed-off-by: Maud Spierings <maudspierings@gocontroll.com>
---
 Documentation/devicetree/bindings/arm/fsl.yaml | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
index 21b7168d61f5..8949a98acd87 100644
--- a/Documentation/devicetree/bindings/arm/fsl.yaml
+++ b/Documentation/devicetree/bindings/arm/fsl.yaml
@@ -1105,7 +1105,6 @@ properties:
               - gateworks,imx8mp-gw74xx   # i.MX8MP Gateworks Board
               - gateworks,imx8mp-gw75xx-2x # i.MX8MP Gateworks Board
               - gateworks,imx8mp-gw82xx-2x # i.MX8MP Gateworks Board
-              - gocontroll,moduline-display # GOcontroll Moduline Display controller
               - prt,prt8ml             # Protonic PRT8ML
               - skov,imx8mp-skov-basic # SKOV i.MX8MP baseboard without frontplate
               - skov,imx8mp-skov-revb-hdmi # SKOV i.MX8MP climate control without panel
@@ -1163,6 +1162,12 @@ properties:
           - const: engicam,icore-mx8mp             # i.MX8MP Engicam i.Core MX8M Plus SoM
           - const: fsl,imx8mp
 
+      - description: Ka-Ro TX8P-ML81 SoM based boards
+        items:
+          - const: gocontroll,moduline-display-106
+          - const: karo,tx8p-ml81
+          - const: fsl,imx8mp
+
       - description: Kontron i.MX8MP OSM-S SoM based Boards
         items:
           - const: kontron,imx8mp-bl-osm-s  # Kontron BL i.MX8MP OSM-S Board

-- 
2.51.2
Re: [PATCH 1/3] dt-bindings: arm: fsl: moduline-display: fix compatible
Posted by Krzysztof Kozlowski 2 months, 3 weeks ago 
On Fri, Nov 14, 2025 at 03:11:49PM +0100, Maud Spierings wrote:
> The compatibles should include the SoM compatible, this board is based
> on the Ka-Ro TX8P-ML81 SoM, so add it. Also add the hardware revision to
> the board compatible.
> 
> This is a breaking change, but it is early enough that it can be
> corrected without causing any issues.
> 
> Fixes: 24e67d28ef95 ("dt-bindings: arm: fsl: Add GOcontroll Moduline Display")
> Signed-off-by: Maud Spierings <maudspierings@gocontroll.com>
> ---
>  Documentation/devicetree/bindings/arm/fsl.yaml | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index 21b7168d61f5..8949a98acd87 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -1105,7 +1105,6 @@ properties:
>                - gateworks,imx8mp-gw74xx   # i.MX8MP Gateworks Board
>                - gateworks,imx8mp-gw75xx-2x # i.MX8MP Gateworks Board
>                - gateworks,imx8mp-gw82xx-2x # i.MX8MP Gateworks Board
> -              - gocontroll,moduline-display # GOcontroll Moduline Display controller
>                - prt,prt8ml             # Protonic PRT8ML
>                - skov,imx8mp-skov-basic # SKOV i.MX8MP baseboard without frontplate
>                - skov,imx8mp-skov-revb-hdmi # SKOV i.MX8MP climate control without panel
> @@ -1163,6 +1162,12 @@ properties:
>            - const: engicam,icore-mx8mp             # i.MX8MP Engicam i.Core MX8M Plus SoM
>            - const: fsl,imx8mp
>  
> +      - description: Ka-Ro TX8P-ML81 SoM based boards
> +        items:
> +          - const: gocontroll,moduline-display-106

You need old compatible here as well, you cannot drop it.

I don't understand why you need board revision - commit msg should
explain that.

> +          - const: karo,tx8p-ml81
> +          - const: fsl,imx8mp

Best regards,
Krzysztof
Re: [PATCH 1/3] dt-bindings: arm: fsl: moduline-display: fix compatible
Posted by Maud Spierings 2 months, 3 weeks ago 
Hi Krzysztof,

Thanks for the review.

On 11/15/25 12:53, Krzysztof Kozlowski wrote:
> On Fri, Nov 14, 2025 at 03:11:49PM +0100, Maud Spierings wrote:
>> The compatibles should include the SoM compatible, this board is based
>> on the Ka-Ro TX8P-ML81 SoM, so add it. Also add the hardware revision to
>> the board compatible.
>>
>> This is a breaking change, but it is early enough that it can be
>> corrected without causing any issues.
>>
>> Fixes: 24e67d28ef95 ("dt-bindings: arm: fsl: Add GOcontroll Moduline Display")
>> Signed-off-by: Maud Spierings <maudspierings@gocontroll.com>
>> ---
>>   Documentation/devicetree/bindings/arm/fsl.yaml | 7 ++++++-
>>   1 file changed, 6 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
>> index 21b7168d61f5..8949a98acd87 100644
>> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
>> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
>> @@ -1105,7 +1105,6 @@ properties:
>>                 - gateworks,imx8mp-gw74xx   # i.MX8MP Gateworks Board
>>                 - gateworks,imx8mp-gw75xx-2x # i.MX8MP Gateworks Board
>>                 - gateworks,imx8mp-gw82xx-2x # i.MX8MP Gateworks Board
>> -              - gocontroll,moduline-display # GOcontroll Moduline Display controller
>>                 - prt,prt8ml             # Protonic PRT8ML
>>                 - skov,imx8mp-skov-basic # SKOV i.MX8MP baseboard without frontplate
>>                 - skov,imx8mp-skov-revb-hdmi # SKOV i.MX8MP climate control without panel
>> @@ -1163,6 +1162,12 @@ properties:
>>             - const: engicam,icore-mx8mp             # i.MX8MP Engicam i.Core MX8M Plus SoM
>>             - const: fsl,imx8mp
>>   
>> +      - description: Ka-Ro TX8P-ML81 SoM based boards
>> +        items:
>> +          - const: gocontroll,moduline-display-106
> 
> You need old compatible here as well, you cannot drop it.

The old compatible should stay in the above section then right? Because 
the old compatible never matched the pattern with the SoM compatible. 
Should/can I add some deprecated tag to it then?

> I don't understand why you need board revision - commit msg should
> explain that.

It is to resolve certain quirks in userspace/bootloader, I will add it 
to the commit version in the next version.

The SoM compatible will be used in barebox to trigger shared code that 
applies to this SoM, I will add that better to the commit message too. I 
believe that also resolves the comments on patch 2/3

Kind Regards,
Maud
>> +          - const: karo,tx8p-ml81
>> +          - const: fsl,imx8mp
> 
> Best regards,
> Krzysztof
>
Re: [PATCH 1/3] dt-bindings: arm: fsl: moduline-display: fix compatible
Posted by Krzysztof Kozlowski 2 months, 3 weeks ago 
On 17/11/2025 08:33, Maud Spierings wrote:
> Hi Krzysztof,
> 
> Thanks for the review.
> 
> On 11/15/25 12:53, Krzysztof Kozlowski wrote:
>> On Fri, Nov 14, 2025 at 03:11:49PM +0100, Maud Spierings wrote:
>>> The compatibles should include the SoM compatible, this board is based
>>> on the Ka-Ro TX8P-ML81 SoM, so add it. Also add the hardware revision to
>>> the board compatible.
>>>
>>> This is a breaking change, but it is early enough that it can be
>>> corrected without causing any issues.
>>>
>>> Fixes: 24e67d28ef95 ("dt-bindings: arm: fsl: Add GOcontroll Moduline Display")
>>> Signed-off-by: Maud Spierings <maudspierings@gocontroll.com>
>>> ---
>>>   Documentation/devicetree/bindings/arm/fsl.yaml | 7 ++++++-
>>>   1 file changed, 6 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
>>> index 21b7168d61f5..8949a98acd87 100644
>>> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
>>> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
>>> @@ -1105,7 +1105,6 @@ properties:
>>>                 - gateworks,imx8mp-gw74xx   # i.MX8MP Gateworks Board
>>>                 - gateworks,imx8mp-gw75xx-2x # i.MX8MP Gateworks Board
>>>                 - gateworks,imx8mp-gw82xx-2x # i.MX8MP Gateworks Board
>>> -              - gocontroll,moduline-display # GOcontroll Moduline Display controller
>>>                 - prt,prt8ml             # Protonic PRT8ML
>>>                 - skov,imx8mp-skov-basic # SKOV i.MX8MP baseboard without frontplate
>>>                 - skov,imx8mp-skov-revb-hdmi # SKOV i.MX8MP climate control without panel
>>> @@ -1163,6 +1162,12 @@ properties:
>>>             - const: engicam,icore-mx8mp             # i.MX8MP Engicam i.Core MX8M Plus SoM
>>>             - const: fsl,imx8mp
>>>   
>>> +      - description: Ka-Ro TX8P-ML81 SoM based boards
>>> +        items:
>>> +          - const: gocontroll,moduline-display-106
>>
>> You need old compatible here as well, you cannot drop it.
> 
> The old compatible should stay in the above section then right? Because 
> the old compatible never matched the pattern with the SoM compatible. 
> Should/can I add some deprecated tag to it then?

You could deprecate old list but there is little benefit of it, but the
point is that your final (new) list must include old compatible because
otherwise it is a potential ABI break.



Best regards,
Krzysztof

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.