perf lock contention: Assorted fixes

[PATCH 0/2] perf lock contention: Assorted fixes

Posted by Ravi Bangoria 2 months, 3 weeks ago

o Patch 1 resolves a segmentation fault in both "perf lock report"
  and "perf lock contention".
o Patch 2 repairs the perf-lock unit test.

Ravi Bangoria (2):
  perf lock: Fix segfault due to missing kernel map
  perf test: Fix lock contention test

 tools/perf/builtin-lock.c                 |  2 ++
 tools/perf/tests/shell/lock_contention.sh | 14 +++++++++-----
 2 files changed, 11 insertions(+), 5 deletions(-)

-- 
2.51.0

Re: [PATCH 0/2] perf lock contention: Assorted fixes

Posted by Namhyung Kim 2 months, 3 weeks ago

Hello,

On Thu, Nov 13, 2025 at 04:01:22PM +0000, Ravi Bangoria wrote:
> o Patch 1 resolves a segmentation fault in both "perf lock report"
>   and "perf lock contention".
> o Patch 2 repairs the perf-lock unit test.
> 
> Ravi Bangoria (2):
>   perf lock: Fix segfault due to missing kernel map
>   perf test: Fix lock contention test

Acked-by: Namhyung Kim <namhyung@kernel.org>

Thanks for the fix!
Namhyung

> 
>  tools/perf/builtin-lock.c                 |  2 ++
>  tools/perf/tests/shell/lock_contention.sh | 14 +++++++++-----
>  2 files changed, 11 insertions(+), 5 deletions(-)
> 
> -- 
> 2.51.0
>

Re: [PATCH 0/2] perf lock contention: Assorted fixes

Posted by Ian Rogers 2 months, 3 weeks ago

On Thu, Nov 13, 2025 at 8:03 AM Ravi Bangoria <ravi.bangoria@amd.com> wrote:
>
> o Patch 1 resolves a segmentation fault in both "perf lock report"
>   and "perf lock contention".
> o Patch 2 repairs the perf-lock unit test.

Reviewed-by: Ian Rogers <irogers@google.com>

Thanks!
Ian

> Ravi Bangoria (2):
>   perf lock: Fix segfault due to missing kernel map
>   perf test: Fix lock contention test
>
>  tools/perf/builtin-lock.c                 |  2 ++
>  tools/perf/tests/shell/lock_contention.sh | 14 +++++++++-----
>  2 files changed, 11 insertions(+), 5 deletions(-)
>
> --
> 2.51.0
>

Re: [PATCH 0/2] perf lock contention: Assorted fixes

Posted by Arnaldo Carvalho de Melo 2 months, 3 weeks ago

On Thu, Nov 13, 2025 at 08:57:40AM -0800, Ian Rogers wrote:
> On Thu, Nov 13, 2025 at 8:03 AM Ravi Bangoria <ravi.bangoria@amd.com> wrote:
> >
> > o Patch 1 resolves a segmentation fault in both "perf lock report"
> >   and "perf lock contention".
> > o Patch 2 repairs the perf-lock unit test.
 
> Reviewed-by: Ian Rogers <irogers@google.com>

Thanks, tested, reproduced the segfault and the fix for it, applied to
perf-tools,

- Arnaldo