fix MIC buffer sizing in selftest

[PATCH] fix MIC buffer sizing in selftest

Posted by Joep Duin 2 months, 3 weeks ago

From: Joep Duin <165405982+joepduin@users.noreply.github.com>

Signed-off-by: Joep Duin <joepduin12@gmail.com>
---
 crypto/krb5/selftest.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/crypto/krb5/selftest.c b/crypto/krb5/selftest.c
index 4519c572d37e..82b2b6a3607d 100644
--- a/crypto/krb5/selftest.c
+++ b/crypto/krb5/selftest.c
@@ -427,10 +427,10 @@ static int krb5_test_one_mic(const struct krb5_mic_test *test, void *buf)
 	memcpy(buf + offset, plain.data, plain.len);
 
 	/* Generate a MIC generation request. */
-	sg_init_one(sg, buf, 1024);
+	sg_init_one(sg, buf, message_len);
 
-	ret = crypto_krb5_get_mic(krb5, ci, NULL, sg, 1, 1024,
-				  krb5->cksum_len, plain.len);
+	ret = crypto_krb5_get_mic(krb5, ci, NULL, sg, 1, message_len,
+                   krb5->cksum_len, plain.len);
 	if (ret < 0) {
 		CHECK(1);
 		pr_warn("Get MIC failed %d\n", ret);
-- 
2.51.2

Re: [PATCH] fix MIC buffer sizing in selftest

Posted by Herbert Xu 2 months, 2 weeks ago

Joep Duin <joepduin12@gmail.com> wrote:
> From: Joep Duin <165405982+joepduin@users.noreply.github.com>
> 
> Signed-off-by: Joep Duin <joepduin12@gmail.com>
> ---
> crypto/krb5/selftest.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/crypto/krb5/selftest.c b/crypto/krb5/selftest.c
> index 4519c572d37e..82b2b6a3607d 100644
> --- a/crypto/krb5/selftest.c
> +++ b/crypto/krb5/selftest.c
> @@ -427,10 +427,10 @@ static int krb5_test_one_mic(const struct krb5_mic_test *test, void *buf)
>        memcpy(buf + offset, plain.data, plain.len);
> 
>        /* Generate a MIC generation request. */
> -       sg_init_one(sg, buf, 1024);
> +       sg_init_one(sg, buf, message_len);
> 
> -       ret = crypto_krb5_get_mic(krb5, ci, NULL, sg, 1, 1024,
> -                                 krb5->cksum_len, plain.len);
> +       ret = crypto_krb5_get_mic(krb5, ci, NULL, sg, 1, message_len,
> +                   krb5->cksum_len, plain.len);

I have no idea what you're trying to fix here.  Please explain
the problem.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] fix MIC buffer sizing in selftest

Posted by David Howells 2 months, 2 weeks ago

Herbert Xu <herbert@gondor.apana.org.au> wrote:

> >        /* Generate a MIC generation request. */
> > -       sg_init_one(sg, buf, 1024);
> > +       sg_init_one(sg, buf, message_len);
> > 
> > -       ret = crypto_krb5_get_mic(krb5, ci, NULL, sg, 1, 1024,
> > -                                 krb5->cksum_len, plain.len);
> > +       ret = crypto_krb5_get_mic(krb5, ci, NULL, sg, 1, message_len,
> > +                   krb5->cksum_len, plain.len);

The buffer doesn't need to fit exactly, it just needs to be big enough to hold
the output produced, but it can be bigger.

David