1. Patchew
  2. linux
  3. View series

[PATCH] arm64: dts: qcom: qcs8300-ride: Enable Bluetooth support

Wei Deng posted 1 patch 2 months, 3 weeks ago
There is a newer version of this series
arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 28 +++++++++++++++++++++++
1 file changed, 28 insertions(+)
[PATCH] arm64: dts: qcom: qcs8300-ride: Enable Bluetooth support
Posted by Wei Deng 2 months, 3 weeks ago 
Enable BT on qcs8300-ride by adding a device tree node for BT.

Signed-off-by: Wei Deng <wei.deng@oss.qualcomm.com>
---
This patch depends on:
- WLAN
https://lore.kernel.org/all/20251113055148.2729943-1-wei.zhang@oss.qualcomm.com/
---
 arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 28 +++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
index cd8800a59700..08b705fe4eea 100644
--- a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
+++ b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
@@ -18,6 +18,7 @@ / {
 	aliases {
 		serial0 = &uart7;
 		mmc0 = &sdhc_1;
+		serial1 = &uart2;
 	};
 
 	chosen {
@@ -71,6 +72,7 @@ wcn6855-pmu {
 		vddpcie1p3-supply = <&vreg_conn_pa>;
 		vddpcie1p9-supply = <&vreg_conn_1p8>;
 
+		bt-enable-gpios = <&tlmm 55 GPIO_ACTIVE_HIGH>;
 		wlan-enable-gpios = <&tlmm 54 GPIO_ACTIVE_HIGH>;
 
 		regulators {
@@ -501,6 +503,13 @@ &sdhc_1 {
 };
 
 &tlmm {
+	bt_en_state: bt-en-state {
+		pins = "gpio55";
+		function = "gpio";
+		bias-pull-down;
+		output-low;
+	};
+
 	ethernet0_default: ethernet0-default-state {
 		ethernet0_mdc: ethernet0-mdc-pins {
 			pins = "gpio5";
@@ -571,6 +580,25 @@ wlan_en_state: wlan-en-state {
 	};
 };
 
+&uart2 {
+	status = "okay";
+
+	bluetooth: bluetooth {
+		compatible = "qcom,wcn6855-bt";
+		firmware-name = "QCA6698/hpnv21", "QCA6698/hpbtfw21.tlv";
+		max-speed = <3200000>;
+
+		vddrfacmn-supply = <&vreg_pmu_rfa_cmn>;
+		vddaon-supply = <&vreg_pmu_aon_0p59>;
+		vddwlcx-supply = <&vreg_pmu_wlcx_0p8>;
+		vddwlmx-supply = <&vreg_pmu_wlmx_0p85>;
+		vddbtcmx-supply = <&vreg_pmu_btcmx_0p85>;
+		vddrfa0p8-supply = <&vreg_pmu_rfa_0p8>;
+		vddrfa1p2-supply = <&vreg_pmu_rfa_1p2>;
+		vddrfa1p8-supply = <&vreg_pmu_rfa_1p7>;
+	};
+};
+
 &uart7 {
 	status = "okay";
 };
-- 
2.25.1
Re: [PATCH] arm64: dts: qcom: qcs8300-ride: Enable Bluetooth support
Posted by Dmitry Baryshkov 2 months, 3 weeks ago 
On Thu, Nov 13, 2025 at 06:39:42PM +0530, Wei Deng wrote:
> Enable BT on qcs8300-ride by adding a device tree node for BT.
> 
> Signed-off-by: Wei Deng <wei.deng@oss.qualcomm.com>
> ---
> This patch depends on:
> - WLAN
> https://lore.kernel.org/all/20251113055148.2729943-1-wei.zhang@oss.qualcomm.com/
> ---
>  arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 28 +++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
> 
> @@ -571,6 +580,25 @@ wlan_en_state: wlan-en-state {
>  	};
>  };
>  
> +&uart2 {
> +	status = "okay";
> +
> +	bluetooth: bluetooth {
> +		compatible = "qcom,wcn6855-bt";
> +		firmware-name = "QCA6698/hpnv21", "QCA6698/hpbtfw21.tlv";

The reason for these firmware-names should be added to the commit
message.

> +		max-speed = <3200000>;
> +
> +		vddrfacmn-supply = <&vreg_pmu_rfa_cmn>;
> +		vddaon-supply = <&vreg_pmu_aon_0p59>;
> +		vddwlcx-supply = <&vreg_pmu_wlcx_0p8>;
> +		vddwlmx-supply = <&vreg_pmu_wlmx_0p85>;
> +		vddbtcmx-supply = <&vreg_pmu_btcmx_0p85>;
> +		vddrfa0p8-supply = <&vreg_pmu_rfa_0p8>;
> +		vddrfa1p2-supply = <&vreg_pmu_rfa_1p2>;
> +		vddrfa1p8-supply = <&vreg_pmu_rfa_1p7>;
> +	};
> +};
> +
>  &uart7 {
>  	status = "okay";
>  };
> -- 
> 2.25.1
> 

-- 
With best wishes
Dmitry
Re: [PATCH] arm64: dts: qcom: qcs8300-ride: Enable Bluetooth support
Posted by Wei Deng 2 months, 3 weeks ago 
Hi Dmitry,
Thanks for your comments.

On 11/14/2025 4:14 AM, Dmitry Baryshkov wrote:
> On Thu, Nov 13, 2025 at 06:39:42PM +0530, Wei Deng wrote:
>> Enable BT on qcs8300-ride by adding a device tree node for BT.
>>
>> Signed-off-by: Wei Deng <wei.deng@oss.qualcomm.com>
>> ---
>> This patch depends on:
>> - WLAN
>> https://lore.kernel.org/all/20251113055148.2729943-1-wei.zhang@oss.qualcomm.com/
>> ---
>>  arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 28 +++++++++++++++++++++++
>>  1 file changed, 28 insertions(+)
>>
>> @@ -571,6 +580,25 @@ wlan_en_state: wlan-en-state {
>>  	};
>>  };
>>  
>> +&uart2 {
>> +	status = "okay";
>> +
>> +	bluetooth: bluetooth {
>> +		compatible = "qcom,wcn6855-bt";
>> +		firmware-name = "QCA6698/hpnv21", "QCA6698/hpbtfw21.tlv";
> 
> The reason for these firmware-names should be added to the commit
> message.
> 

Since the platform uses the QCA6698 Bluetooth chip. While the QCA6698 
shares the same IP core as the WCN6855, it has different RF components
and RAM sizes, requiring new firmware files. Use the firmware-name property
to specify the NVM and rampatch firmware to load.
Will add this to commit message.

>> +		max-speed = <3200000>;
>> +
>> +		vddrfacmn-supply = <&vreg_pmu_rfa_cmn>;
>> +		vddaon-supply = <&vreg_pmu_aon_0p59>;
>> +		vddwlcx-supply = <&vreg_pmu_wlcx_0p8>;
>> +		vddwlmx-supply = <&vreg_pmu_wlmx_0p85>;
>> +		vddbtcmx-supply = <&vreg_pmu_btcmx_0p85>;
>> +		vddrfa0p8-supply = <&vreg_pmu_rfa_0p8>;
>> +		vddrfa1p2-supply = <&vreg_pmu_rfa_1p2>;
>> +		vddrfa1p8-supply = <&vreg_pmu_rfa_1p7>;
>> +	};
>> +};
>> +
>>  &uart7 {
>>  	status = "okay";
>>  };
>> -- 
>> 2.25.1
>>
> 

-- 
Best Regards,
Wei Deng
Re: [PATCH] arm64: dts: qcom: qcs8300-ride: Enable Bluetooth support
Posted by Krzysztof Kozlowski 2 months, 3 weeks ago 
On 13/11/2025 14:09, Wei Deng wrote:
> Enable BT on qcs8300-ride by adding a device tree node for BT.
> 
> Signed-off-by: Wei Deng <wei.deng@oss.qualcomm.com>
> ---
> This patch depends on:
> - WLAN
> https://lore.kernel.org/all/20251113055148.2729943-1-wei.zhang@oss.qualcomm.com/

And that patch depends on something else.

You make it very difficult to review and even more difficult to merge.

> ---
>  arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 28 +++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
> index cd8800a59700..08b705fe4eea 100644
> --- a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
> +++ b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
> @@ -18,6 +18,7 @@ / {
>  	aliases {
>  		serial0 = &uart7;
>  		mmc0 = &sdhc_1;

There is no such alias?

> +		serial1 = &uart2;

So every contributor here will add some random order...


Best regards,
Krzysztof
Re: [PATCH] arm64: dts: qcom: qcs8300-ride: Enable Bluetooth support
Posted by Krzysztof Kozlowski 2 months, 3 weeks ago 
On 13/11/2025 14:37, Krzysztof Kozlowski wrote:
> On 13/11/2025 14:09, Wei Deng wrote:
>> Enable BT on qcs8300-ride by adding a device tree node for BT.
>>
>> Signed-off-by: Wei Deng <wei.deng@oss.qualcomm.com>
>> ---
>> This patch depends on:
>> - WLAN
>> https://lore.kernel.org/all/20251113055148.2729943-1-wei.zhang@oss.qualcomm.com/
> 
> And that patch depends on something else.
> 
> You make it very difficult to review and even more difficult to merge.
> 
>> ---
>>  arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 28 +++++++++++++++++++++++
>>  1 file changed, 28 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
>> index cd8800a59700..08b705fe4eea 100644
>> --- a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
>> +++ b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
>> @@ -18,6 +18,7 @@ / {
>>  	aliases {
>>  		serial0 = &uart7;
>>  		mmc0 = &sdhc_1;
> 
> There is no such alias?

Ah there is, found now added by Sayali Lokhande <quic_sayalil@quicinc.com>.

Anyway, organize your work in reasonable patchsets not 3 or more
one-patchers spread all over the mailing list.

Best regards,
Krzysztof
Re: [PATCH] arm64: dts: qcom: qcs8300-ride: Enable Bluetooth support
Posted by Wei Deng 2 months, 3 weeks ago 
Hi Krzysztof,
Thanks for your comments.

On 11/13/2025 9:38 PM, Krzysztof Kozlowski wrote:
> On 13/11/2025 14:37, Krzysztof Kozlowski wrote:
>> On 13/11/2025 14:09, Wei Deng wrote:
>>> Enable BT on qcs8300-ride by adding a device tree node for BT.
>>>
>>> Signed-off-by: Wei Deng <wei.deng@oss.qualcomm.com>
>>> ---
>>> This patch depends on:
>>> - WLAN
>>> https://lore.kernel.org/all/20251113055148.2729943-1-wei.zhang@oss.qualcomm.com/
>>
>> And that patch depends on something else.
>>
>> You make it very difficult to review and even more difficult to merge.
>>
>>> ---
>>>  arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 28 +++++++++++++++++++++++
>>>  1 file changed, 28 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
>>> index cd8800a59700..08b705fe4eea 100644
>>> --- a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
>>> +++ b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
>>> @@ -18,6 +18,7 @@ / {
>>>  	aliases {
>>>  		serial0 = &uart7;
>>>  		mmc0 = &sdhc_1;
>>
>> There is no such alias?
> 
> Ah there is, found now added by Sayali Lokhande <quic_sayalil@quicinc.com>.
> 
> Anyway, organize your work in reasonable patchsets not 3 or more
> one-patchers spread all over the mailing list.
> 

OK, will re-organize my work in reasonable patchsets. Will send new patch.

> Best regards,
> Krzysztof

-- 
Best Regards,
Wei Deng

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.