This patch series adds Signal Quality Indicator (SQI) and enhanced SQI+
support for OATC14 10Base-T1S PHYs, along with integration into the
Microchip T1S PHY driver. These changes enable higher-layer drivers and
diagnostic tools to assess link quality more accurately.

Patch Summary:
1. add SQI and SQI+ support for OATC14 10Base-T1S PHYs
   - Introduces MDIO register definitions for DCQ_SQI and DCQ_SQIPLUS.
   - Adds genphy_c45_oatc14_get_sqi_max() to report the maximum SQI/SQI+
     level.
   - Adds genphy_c45_oatc14_get_sqi() to return the current SQI or SQI+
     value.
   - Updates include/linux/phy.h to expose the new APIs.
   - SQI+ capability is read from the Advanced Diagnostic Features
     Capability register (ADFCAP). If unsupported, the driver falls back
     to basic SQI (0–7 levels).
   - Open Alliance TC14 10BASE-T1S Advanced Diagnostic PHY Features.
     https://opensig.org/wp-content/uploads/2025/06/OPEN_Alliance_10BASE-T1S_Advanced_PHY_features_for-automotive_Ethernet_V2.1b.pdf
	
2. add SQI support for LAN867x Rev.D0 PHYs
   - Registers .get_sqi and .get_sqi_max callbacks in the Microchip T1S
     driver.
   - Enables network drivers and diagnostic tools to query link signal
     quality for LAN867x Rev.D0 PHYs.
   - Existing PHY functionality remains unchanged.

Parthiban Veerasooran (2):
  net: phy: phy-c45: add SQI and SQI+ support for OATC14 10Base-T1S PHYs
  net: phy: microchip_t1s: add SQI support for LAN867x Rev.D0 PHYs

 drivers/net/phy/mdio-open-alliance.h | 14 +++++
 drivers/net/phy/microchip_t1s.c      |  2 +
 drivers/net/phy/phy-c45.c            | 94 ++++++++++++++++++++++++++++
 include/linux/phy.h                  |  2 +
 4 files changed, 112 insertions(+)


base-commit: 68fa5b092efab37a4f08a47b22bb8ca98f7f6223
-- 
2.34.1

On Thu, Nov 13, 2025 at 05:22:04PM +0530, Parthiban Veerasooran wrote:
> This patch series adds Signal Quality Indicator (SQI) and enhanced SQI+
> support for OATC14 10Base-T1S PHYs, along with integration into the
> Microchip T1S PHY driver. These changes enable higher-layer drivers and
> diagnostic tools to assess link quality more accurately.

Higher-layer drivers? I don't know of any examples at the moment.  Are
you thinking of a new bond mode, where it will do active-backup based
on the best SQI values?

	Andrew

Hi Andrew,

Thank you for reviewing the patches.

On 13/11/25 7:09 pm, Andrew Lunn wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On Thu, Nov 13, 2025 at 05:22:04PM +0530, Parthiban Veerasooran wrote:
>> This patch series adds Signal Quality Indicator (SQI) and enhanced SQI+
>> support for OATC14 10Base-T1S PHYs, along with integration into the
>> Microchip T1S PHY driver. These changes enable higher-layer drivers and
>> diagnostic tools to assess link quality more accurately.
> 
> Higher-layer drivers? I don't know of any examples at the moment.  Are
> you thinking of a new bond mode, where it will do active-backup based
> on the best SQI values?
I think I misstated it here. I meant that the higher-layer drivers are 
the OATC14 10Base-T1S PHY drivers, which can use the generic APIs 
implemented in PHYLIB to obtain SQI value. Currently, this patch series 
is intended only for ethtool.

I should have described the patch series more specifically as follows:

This patch series adds Signal Quality Indicator (SQI) and enhanced SQI+ 
support for OATC14 10Base-T1S PHYs, along with integration into the 
Microchip T1S PHY driver. This enables ethtool to report the SQI value 
for OATC14 10Base-T1S PHYs.

If this explanation clarifies things, I will update it in the next version.

Best regards,
Parthiban V
> 
>          Andrew