drivers/gpu/drm/arm/display/komeda/komeda_event.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Replace the DRM_ERROR() call in
drivers/gpu/drm/arm/display/komeda/komeda_event.c with the corresponding
drm_err() helper that uses the existing drm_device parameter.
Using drm_err() allows the DRM core to prefix log messages with the
specific DRM device name and instance, which helps distinguish logs when
multiple display controllers are present.
This change aligns komeda_event.c with the DRM TODO item:
"Convert logging to drm_* functions with drm_device parameter".
Signed-off-by: Abhishek Rajput <abhiraj21put@gmail.com>
---
drivers/gpu/drm/arm/display/komeda/komeda_event.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_event.c b/drivers/gpu/drm/arm/display/komeda/komeda_event.c
index 53f944e66dfc..78a4a78d1fab 100644
--- a/drivers/gpu/drm/arm/display/komeda/komeda_event.c
+++ b/drivers/gpu/drm/arm/display/komeda/komeda_event.c
@@ -148,7 +148,7 @@ void komeda_print_events(struct komeda_events *evts, struct drm_device *dev)
komeda_sprintf(&str, ", pipes[1]: ");
evt_str(&str, evts->pipes[1]);
- DRM_ERROR("err detect: %s\n", msg);
+ drm_err(dev, "err detect: %s\n", msg);
if ((err_verbosity & KOMEDA_DEV_PRINT_DUMP_STATE_ON_EVENT) &&
(evts_mask & (KOMEDA_ERR_EVENTS | KOMEDA_WARN_EVENTS)))
drm_state_dump(dev, &p);
--
2.43.0
On Thu, Nov 13, 2025 at 03:36:23PM +0530, Abhishek Rajput wrote:
> Replace the DRM_ERROR() call in
> drivers/gpu/drm/arm/display/komeda/komeda_event.c with the corresponding
> drm_err() helper that uses the existing drm_device parameter.
>
> Using drm_err() allows the DRM core to prefix log messages with the
> specific DRM device name and instance, which helps distinguish logs when
> multiple display controllers are present.
>
> This change aligns komeda_event.c with the DRM TODO item:
> "Convert logging to drm_* functions with drm_device parameter".
>
> Signed-off-by: Abhishek Rajput <abhiraj21put@gmail.com>
Reviewed-by: Liviu Dudau <liviu.dudau@arm.com>
Best regards,
Liviu
> ---
> drivers/gpu/drm/arm/display/komeda/komeda_event.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_event.c b/drivers/gpu/drm/arm/display/komeda/komeda_event.c
> index 53f944e66dfc..78a4a78d1fab 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_event.c
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_event.c
> @@ -148,7 +148,7 @@ void komeda_print_events(struct komeda_events *evts, struct drm_device *dev)
> komeda_sprintf(&str, ", pipes[1]: ");
> evt_str(&str, evts->pipes[1]);
>
> - DRM_ERROR("err detect: %s\n", msg);
> + drm_err(dev, "err detect: %s\n", msg);
> if ((err_verbosity & KOMEDA_DEV_PRINT_DUMP_STATE_ON_EVENT) &&
> (evts_mask & (KOMEDA_ERR_EVENTS | KOMEDA_WARN_EVENTS)))
> drm_state_dump(dev, &p);
> --
> 2.43.0
>
--
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
¯\_(ツ)_/¯
© 2016 - 2026 Red Hat, Inc.