[net PATCH] octeontx2-af: Skip TM tree print for disabled SQs

Anshumali Gaur posted 1 patch 2 months, 3 weeks ago
There is a newer version of this series
drivers/net/ethernet/marvell/octeontx2/af/rvu_debugfs.c | 3 +++
1 file changed, 3 insertions(+)
[net PATCH] octeontx2-af: Skip TM tree print for disabled SQs
Posted by Anshumali Gaur 2 months, 3 weeks ago
Currently, the TM tree is printing all SQ topology including those
which are not enabled, this results in redundant output for SQs
which are not active. This patch adds a check in print_tm_tree()
to skip printing the TM tree hierarchy if the SQ is not enabled.

Fixes: b907194a5d5b ("octeontx2-af: Add debugfs support to dump NIX TM topology")
Signed-off-by: Anshumali Gaur <agaur@marvell.com>
---
 drivers/net/ethernet/marvell/octeontx2/af/rvu_debugfs.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_debugfs.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_debugfs.c
index 8375f18c8e07..7e3be0fb8cf6 100644
--- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_debugfs.c
+++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_debugfs.c
@@ -1651,6 +1651,9 @@ static void print_tm_tree(struct seq_file *m,
 	int blkaddr;
 	u64 cfg;
 
+	if (!sq_ctx->ena)
+		return;
+
 	blkaddr = nix_hw->blkaddr;
 	schq = sq_ctx->smq;
 
-- 
2.25.1
Re: [net PATCH] octeontx2-af: Skip TM tree print for disabled SQs
Posted by Simon Horman 2 months, 3 weeks ago
On Thu, Nov 13, 2025 at 03:09:00PM +0530, Anshumali Gaur wrote:
> Currently, the TM tree is printing all SQ topology including those
> which are not enabled, this results in redundant output for SQs
> which are not active. This patch adds a check in print_tm_tree()
> to skip printing the TM tree hierarchy if the SQ is not enabled.
> 
> Fixes: b907194a5d5b ("octeontx2-af: Add debugfs support to dump NIX TM topology")
> Signed-off-by: Anshumali Gaur <agaur@marvell.com>

Thanks Anshumali,

I agree that this is a nice change.  But I'd lean towards this being
net-next material rather than a bugfix for net.

This is because my understanding is that the change enhances the
readability of debugfs output which, as the name implies, is for debugging.

...