From: David Heidelberg <david@ixit.cz>
Reason for moving from simple panel is this DDIC has three supplies,
while panel-simple-dsi is limited to one.
Previous compatible only described the DDIC, but didn't include panel
connected to it. Let's fix it, and offer bindings authors two
compatibles to distinguish the connected panel.
Basic description for SOFEF00 DDIC with attached panels
- Samsung AMS601NT22 6.01 inch, 1080x2160 pixels, 18:9 ratio
- Samsung AMS628NW01 6.28 inch, 1080x2280 pixels, 19:9 ratio
There is only one user which uses samsung,sofef00 and it's updated to
comply within this patch series.
Signed-off-by: David Heidelberg <david@ixit.cz>
---
.../bindings/display/panel/panel-simple-dsi.yaml | 25 ++-----
.../bindings/display/panel/samsung,sofef00.yaml | 79 ++++++++++++++++++++++
MAINTAINERS | 6 ++
3 files changed, 89 insertions(+), 21 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml
index ac2db8cf5eb76..464d7c8a7665e 100644
--- a/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml
+++ b/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml
@@ -19,6 +19,9 @@ description: |
If the panel is more advanced a dedicated binding file is required.
+allOf:
+ - $ref: panel-common.yaml#
+
properties:
compatible:
@@ -56,8 +59,6 @@ properties:
- panasonic,vvx10f034n00
# Samsung s6e3fa7 1080x2220 based AMS559NK06 AMOLED panel
- samsung,s6e3fa7-ams559nk06
- # Samsung sofef00 1080x2280 AMOLED panel
- - samsung,sofef00
# Shangai Top Display Optoelectronics 7" TL070WSH30 1024x600 TFT LCD panel
- tdo,tl070wsh30
@@ -70,30 +71,12 @@ properties:
reset-gpios: true
port: true
power-supply: true
- vddio-supply: true
-
-allOf:
- - $ref: panel-common.yaml#
- - if:
- properties:
- compatible:
- enum:
- - samsung,sofef00
- then:
- properties:
- power-supply: false
- required:
- - vddio-supply
- else:
- properties:
- vddio-supply: false
- required:
- - power-supply
additionalProperties: false
required:
- compatible
+ - power-supply
- reg
examples:
diff --git a/Documentation/devicetree/bindings/display/panel/samsung,sofef00.yaml b/Documentation/devicetree/bindings/display/panel/samsung,sofef00.yaml
new file mode 100644
index 0000000000000..eeee3cac72e31
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/samsung,sofef00.yaml
@@ -0,0 +1,79 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/panel/samsung,sofef00.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Samsung SOFEF00 AMOLED DDIC
+
+description: The SOFEF00 is display driver IC with connected panel.
+
+maintainers:
+ - David Heidelberg <david@ixit.cz>
+
+allOf:
+ - $ref: panel-common.yaml#
+
+properties:
+ compatible:
+ items:
+ - enum:
+ # Samsung 6.01 inch, 1080x2160 pixels, 18:9 ratio
+ - samsung,sofef00-ams601nt22
+ # Samsung 6.28 inch, 1080x2280 pixels, 19:9 ratio
+ - samsung,sofef00-ams628nw01
+ - const: samsung,sofef00
+
+ reg:
+ maxItems: 1
+
+ poc-supply:
+ description: POC regulator
+
+ vci-supply:
+ description: VCI regulator
+
+ vddio-supply:
+ description: VDD regulator
+
+required:
+ - compatible
+ - reset-gpios
+ - poc-supply
+ - vci-supply
+ - vddio-supply
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/gpio/gpio.h>
+
+ dsi {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ panel@0 {
+ compatible = "samsung,sofef00-ams628nw01", "samsung,sofef00";
+ reg = <0>;
+
+ vddio-supply = <&vreg_l14a_1p88>;
+ vci-supply = <&s2dos05_buck1>;
+ poc-supply = <&s2dos05_ldo1>;
+
+ te-gpios = <&tlmm 10 GPIO_ACTIVE_HIGH>;
+ reset-gpios = <&tlmm 6 GPIO_ACTIVE_HIGH>;
+
+ pinctrl-0 = <&panel_active>;
+ pinctrl-1 = <&panel_suspend>;
+ pinctrl-names = "default", "sleep";
+
+ port {
+ panel_in: endpoint {
+ remote-endpoint = <&mdss_dsi0_out>;
+ };
+ };
+ };
+ };
+
+...
diff --git a/MAINTAINERS b/MAINTAINERS
index 7e015dcbac732..a4b16812d5a0c 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -8117,6 +8117,12 @@ S: Maintained
F: Documentation/devicetree/bindings/display/panel/samsung,s6e3ha8.yaml
F: drivers/gpu/drm/panel/panel-samsung-s6e3ha8.c
+DRM DRIVER FOR SAMSUNG SOFEF00 DDIC
+M: David Heidelberg <david@ixit.cz>
+S: Maintained
+F: Documentation/devicetree/bindings/display/panel/samsung,sofef00.yaml
+F: drivers/gpu/drm/panel/panel-samsung-sofef00.c
+
DRM DRIVER FOR SHARP MEMORY LCD
M: Alex Lanzano <lanzano.alex@gmail.com>
S: Maintained
--
2.51.0Hi David, I may not have added myself to MAINTAINERS when I submitted this driver, but a heads-up would have been appreciated before just taking it over! On 11/13/25 18:57, David Heidelberg via B4 Relay wrote: > From: David Heidelberg <david@ixit.cz> [...]> diff --git a/MAINTAINERS b/MAINTAINERS > index 7e015dcbac732..a4b16812d5a0c 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -8117,6 +8117,12 @@ S: Maintained > F: Documentation/devicetree/bindings/display/panel/samsung,s6e3ha8.yaml > F: drivers/gpu/drm/panel/panel-samsung-s6e3ha8.c > > +DRM DRIVER FOR SAMSUNG SOFEF00 DDIC > +M: David Heidelberg <david@ixit.cz> M: Casey Connolly <casey.connolly@linaro.org> Please and thanks! Casey (she/they) > +S: Maintained > +F: Documentation/devicetree/bindings/display/panel/samsung,sofef00.yaml > +F: drivers/gpu/drm/panel/panel-samsung-sofef00.c > + > DRM DRIVER FOR SHARP MEMORY LCD > M: Alex Lanzano <lanzano.alex@gmail.com> > S: Maintained >
On 16/11/2025 14:55, Casey Connolly wrote: > Hi David, > > I may not have added myself to MAINTAINERS when I submitted this driver, > but a heads-up would have been appreciated before just taking it over! I missed this part in first reaction to your email. Since the driver was broken in mainline and you didn't upstream any patches you had in sdm845-mainline tree for more than year, I assumed you don't have time to maintain the driver. I'm very happy you got back and you're going to maintain the driver again thou. I didn't feel I'm taking over from you, so sorry about that! David > > On 11/13/25 18:57, David Heidelberg via B4 Relay wrote: >> From: David Heidelberg <david@ixit.cz> > > [...]> diff --git a/MAINTAINERS b/MAINTAINERS >> index 7e015dcbac732..a4b16812d5a0c 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -8117,6 +8117,12 @@ S: Maintained >> F: Documentation/devicetree/bindings/display/panel/ >> samsung,s6e3ha8.yaml >> F: drivers/gpu/drm/panel/panel-samsung-s6e3ha8.c >> +DRM DRIVER FOR SAMSUNG SOFEF00 DDIC >> +M: David Heidelberg <david@ixit.cz> > > M: Casey Connolly <casey.connolly@linaro.org> > > Please and thanks! > Casey (she/they) > >> +S: Maintained >> +F: Documentation/devicetree/bindings/display/panel/ >> samsung,sofef00.yaml >> +F: drivers/gpu/drm/panel/panel-samsung-sofef00.c >> + >> DRM DRIVER FOR SHARP MEMORY LCD >> M: Alex Lanzano <lanzano.alex@gmail.com> >> S: Maintained >> > -- David Heidelberg
On 16/11/2025 14:55, Casey Connolly wrote: > Hi David, > > I may not have added myself to MAINTAINERS when I submitted this driver, > but a heads-up would have been appreciated before just taking it over! > > On 11/13/25 18:57, David Heidelberg via B4 Relay wrote: >> From: David Heidelberg <david@ixit.cz> > > [...]> diff --git a/MAINTAINERS b/MAINTAINERS >> index 7e015dcbac732..a4b16812d5a0c 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -8117,6 +8117,12 @@ S: Maintained >> F: Documentation/devicetree/bindings/display/panel/ >> samsung,s6e3ha8.yaml >> F: drivers/gpu/drm/panel/panel-samsung-s6e3ha8.c >> +DRM DRIVER FOR SAMSUNG SOFEF00 DDIC >> +M: David Heidelberg <david@ixit.cz> > > M: Casey Connolly <casey.connolly@linaro.org> Sure, I'll add you in next patch version. Could you review the patches not authored by you within the patchset too? Thank you David > > Please and thanks! > Casey (she/they) > >> +S: Maintained >> +F: Documentation/devicetree/bindings/display/panel/ >> samsung,sofef00.yaml >> +F: drivers/gpu/drm/panel/panel-samsung-sofef00.c >> + >> DRM DRIVER FOR SHARP MEMORY LCD >> M: Alex Lanzano <lanzano.alex@gmail.com> >> S: Maintained >> > -- David Heidelberg
On Thu, Nov 13, 2025 at 06:57:35PM +0100, David Heidelberg wrote: > Reason for moving from simple panel is this DDIC has three supplies, > while panel-simple-dsi is limited to one. > > Previous compatible only described the DDIC, but didn't include panel > connected to it. Let's fix it, and offer bindings authors two > compatibles to distinguish the connected panel. > > Basic description for SOFEF00 DDIC with attached panels > > - Samsung AMS601NT22 6.01 inch, 1080x2160 pixels, 18:9 ratio > - Samsung AMS628NW01 6.28 inch, 1080x2280 pixels, 19:9 ratio > > There is only one user which uses samsung,sofef00 and it's updated to > comply within this patch series. > > Signed-off-by: David Heidelberg <david@ixit.cz> > --- Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
© 2016 - 2026 Red Hat, Inc.