[PATCH sched_ext/for-6.19] sched_ext: Update comments replacing breather with aborting mechanism

Andrea Righi posted 1 patch 2 months, 3 weeks ago
kernel/sched/ext.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
[PATCH sched_ext/for-6.19] sched_ext: Update comments replacing breather with aborting mechanism
Posted by Andrea Righi 2 months, 3 weeks ago
Commit 5ebec443fb96a ("sched_ext: Exit dispatch and move operations
immediately when aborting") replaced the breather mechanism with the
scx_aborting flag.

Update comments removing references to the breather mechanism to avoid
confusion.

Signed-off-by: Andrea Righi <arighi@nvidia.com>
---
 kernel/sched/ext.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/kernel/sched/ext.c b/kernel/sched/ext.c
index c900667b25b88..8a3b8f64a06be 100644
--- a/kernel/sched/ext.c
+++ b/kernel/sched/ext.c
@@ -3732,7 +3732,7 @@ bool scx_rcu_cpu_stall(void)
  * live-lock the system by making many CPUs target the same DSQ to the point
  * where soft-lockup detection triggers. This function is called from
  * soft-lockup watchdog when the triggering point is close and tries to unjam
- * the system by enabling the breather and aborting the BPF scheduler.
+ * the system and aborting the BPF scheduler.
  */
 void scx_softlockup(u32 dur_s)
 {
@@ -4315,9 +4315,9 @@ static bool scx_claim_exit(struct scx_sched *sch, enum scx_exit_kind kind)
 		return false;
 
 	/*
-	 * Some CPUs may be trapped in the dispatch paths. Enable breather
-	 * immediately; otherwise, we might not even be able to get to
-	 * scx_bypass().
+	 * Some CPUs may be trapped in the dispatch paths. Set the aborting
+	 * flag to break potential live-lock scenarios, ensuring we can
+	 * successfully reach scx_bypass().
 	 */
 	WRITE_ONCE(scx_aborting, true);
 	return true;
-- 
2.51.2
Re: [PATCH sched_ext/for-6.19] sched_ext: Update comments replacing breather with aborting mechanism
Posted by Tejun Heo 2 months, 3 weeks ago
Applied to sched_ext/for-6.19.

Thanks.
--
tejun