[PATCH v2] greybus: add WQ_PERCPU to alloc_workqueue users

Marco Crivellari posted 1 patch 2 months, 3 weeks ago
drivers/greybus/operation.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH v2] greybus: add WQ_PERCPU to alloc_workqueue users
Posted by Marco Crivellari 2 months, 3 weeks ago
This continues the effort to refactor workqueue APIs, which began with
the introduction of new workqueues and a new alloc_workqueue flag in:

commit 128ea9f6ccfb ("workqueue: Add system_percpu_wq and system_dfl_wq")
commit 930c2ea566af ("workqueue: Add new WQ_PERCPU flag")

This change adds a new WQ_PERCPU flag to explicitly request
alloc_workqueue() to be per-cpu when WQ_UNBOUND has not been specified.

With the introduction of the WQ_PERCPU flag (equivalent to !WQ_UNBOUND),
any alloc_workqueue() caller that doesn’t explicitly specify WQ_UNBOUND
must now use WQ_PERCPU.

Once migration is complete, WQ_UNBOUND can be removed and unbound will
become the implicit default.

Suggested-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Marco Crivellari <marco.crivellari@suse.com>
Reviewed-by: Johan Hovold <johan@kernel.org>
---
Changes in v2:
- updated commit log removing two paragraph not strictly related to
  the work.

- subject changed removing "drivers/" before the actual prefix.
---
 drivers/greybus/operation.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/greybus/operation.c b/drivers/greybus/operation.c
index 54ccc434a1f7..7e12ffb2dd60 100644
--- a/drivers/greybus/operation.c
+++ b/drivers/greybus/operation.c
@@ -1238,7 +1238,7 @@ int __init gb_operation_init(void)
 		goto err_destroy_message_cache;
 
 	gb_operation_completion_wq = alloc_workqueue("greybus_completion",
-						     0, 0);
+						     WQ_PERCPU, 0);
 	if (!gb_operation_completion_wq)
 		goto err_destroy_operation_cache;
 
-- 
2.51.1

Re: [PATCH v2] greybus: add WQ_PERCPU to alloc_workqueue users
Posted by Marco Crivellari 1 month, 2 weeks ago
On Wed, Nov 12, 2025 at 4:27 PM Marco Crivellari
<marco.crivellari@suse.com> wrote:
> [...]
>  drivers/greybus/operation.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/greybus/operation.c b/drivers/greybus/operation.c
> index 54ccc434a1f7..7e12ffb2dd60 100644
> --- a/drivers/greybus/operation.c
> +++ b/drivers/greybus/operation.c
> @@ -1238,7 +1238,7 @@ int __init gb_operation_init(void)
>                 goto err_destroy_message_cache;
>
>         gb_operation_completion_wq = alloc_workqueue("greybus_completion",
> -                                                    0, 0);
> +                                                    WQ_PERCPU, 0);
>         if (!gb_operation_completion_wq)
>                 goto err_destroy_operation_cache;
>

Gentle ping.

Thanks!


-- 

Marco Crivellari

L3 Support Engineer
Re: [PATCH v2] greybus: add WQ_PERCPU to alloc_workqueue users
Posted by Johan Hovold 3 weeks, 4 days ago
On Wed, Dec 24, 2025 at 04:20:52PM +0100, Marco Crivellari wrote:
> On Wed, Nov 12, 2025 at 4:27 PM Marco Crivellari
> <marco.crivellari@suse.com> wrote:
> > [...]
> >  drivers/greybus/operation.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/greybus/operation.c b/drivers/greybus/operation.c
> > index 54ccc434a1f7..7e12ffb2dd60 100644
> > --- a/drivers/greybus/operation.c
> > +++ b/drivers/greybus/operation.c
> > @@ -1238,7 +1238,7 @@ int __init gb_operation_init(void)
> >                 goto err_destroy_message_cache;
> >
> >         gb_operation_completion_wq = alloc_workqueue("greybus_completion",
> > -                                                    0, 0);
> > +                                                    WQ_PERCPU, 0);
> >         if (!gb_operation_completion_wq)
> >                 goto err_destroy_operation_cache;
> >
> 
> Gentle ping.

On Christmas Eve?

It'll be picked up by eventually now that people are back from
conferences and holiday.

Johan
Re: [PATCH v2] greybus: add WQ_PERCPU to alloc_workqueue users
Posted by Marco Crivellari 3 weeks, 4 days ago
On Tue, Jan 13, 2026 at 10:45 AM Johan Hovold <johan@kernel.org> wrote:
> [...]
>
> On Christmas Eve?
>
> It'll be picked up by eventually now that people are back from
> conferences and holiday.

Hi,

Yes it could be. I pinged only because I noticed it is from mid November.

Many thanks, anyhow!

-- 

Marco Crivellari

L3 Support Engineer