[PATCH 10/10] of/address: Remove the incorrect and misleading comment

Yuntao Wang posted 10 patches 2 months, 4 weeks ago
There is a newer version of this series
[PATCH 10/10] of/address: Remove the incorrect and misleading comment
Posted by Yuntao Wang 2 months, 4 weeks ago
The of_bus_default_match() function appears to have been copied from
of_bus_default_flags_match() with some modifications.

However, the comment was left unchanged and still describes the behavior
of of_bus_default_flags_match(), it is incorrect and misleading, remove it.

Signed-off-by: Yuntao Wang <yuntao.wang@linux.dev>
---
 drivers/of/address.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/of/address.c b/drivers/of/address.c
index f0f8f0dd191c..4034d798c55a 100644
--- a/drivers/of/address.c
+++ b/drivers/of/address.c
@@ -328,10 +328,6 @@ static int of_bus_default_flags_match(struct device_node *np)
 
 static int of_bus_default_match(struct device_node *np)
 {
-	/*
-	 * Check for presence first since of_bus_n_addr_cells() will warn when
-	 * walking parent nodes.
-	 */
 	return of_property_present(np, "#address-cells");
 }
 
-- 
2.51.0
Re: [PATCH 10/10] of/address: Remove the incorrect and misleading comment
Posted by Rob Herring 2 months, 4 weeks ago
On Wed, Nov 12, 2025 at 10:35:20PM +0800, Yuntao Wang wrote:
> The of_bus_default_match() function appears to have been copied from
> of_bus_default_flags_match() with some modifications.
> 
> However, the comment was left unchanged and still describes the behavior
> of of_bus_default_flags_match(), it is incorrect and misleading, remove it.
> 
> Signed-off-by: Yuntao Wang <yuntao.wang@linux.dev>
> ---
>  drivers/of/address.c | 4 ----
>  1 file changed, 4 deletions(-)

Applied, thanks!
Re: [PATCH 10/10] of/address: Remove the incorrect and misleading comment
Posted by Rob Herring 2 months, 4 weeks ago
On Wed, Nov 12, 2025 at 10:35:20PM +0800, Yuntao Wang wrote:
> The of_bus_default_match() function appears to have been copied from
> of_bus_default_flags_match() with some modifications.
> 
> However, the comment was left unchanged and still describes the behavior
> of of_bus_default_flags_match(), it is incorrect and misleading, remove it.

There is no reason to put this patch in this series. It is completely 
unrelated.

> 
> Signed-off-by: Yuntao Wang <yuntao.wang@linux.dev>
> ---
>  drivers/of/address.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/of/address.c b/drivers/of/address.c
> index f0f8f0dd191c..4034d798c55a 100644
> --- a/drivers/of/address.c
> +++ b/drivers/of/address.c
> @@ -328,10 +328,6 @@ static int of_bus_default_flags_match(struct device_node *np)
>  
>  static int of_bus_default_match(struct device_node *np)
>  {
> -	/*
> -	 * Check for presence first since of_bus_n_addr_cells() will warn when
> -	 * walking parent nodes.
> -	 */
>  	return of_property_present(np, "#address-cells");
>  }
>  
> -- 
> 2.51.0
>
Re: [PATCH 10/10] of/address: Remove the incorrect and misleading comment
Posted by Geert Uytterhoeven 2 months, 4 weeks ago
On Wed, 12 Nov 2025 at 15:38, Yuntao Wang <yuntao.wang@linux.dev> wrote:
> The of_bus_default_match() function appears to have been copied from
> of_bus_default_flags_match() with some modifications.
>
> However, the comment was left unchanged and still describes the behavior
> of of_bus_default_flags_match(), it is incorrect and misleading, remove it.
>
> Signed-off-by: Yuntao Wang <yuntao.wang@linux.dev>

Fixes: 6e5773d52f4a2d9c ("of/address: Fix WARN when attempting
translating non-translatable addresses")
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds