net/sched: act_ife: convert comma to semicolon

[PATCH] net/sched: act_ife: convert comma to semicolon

Posted by Chen Ni 2 months, 4 weeks ago

Replace comma between expressions with semicolons.

Using a ',' in place of a ';' can have unintended side effects.
Although that is not the case here, it is seems best to use ';'
unless ',' is intended.

Found by inspection.
No functional change intended.
Compile tested only.

Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
 net/sched/act_ife.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/net/sched/act_ife.c b/net/sched/act_ife.c
index 7c6975632fc2..1dfdda6c2d4c 100644
--- a/net/sched/act_ife.c
+++ b/net/sched/act_ife.c
@@ -649,9 +649,9 @@ static int tcf_ife_dump(struct sk_buff *skb, struct tc_action *a, int bind,
 
 	memset(&opt, 0, sizeof(opt));
 
-	opt.index = ife->tcf_index,
-	opt.refcnt = refcount_read(&ife->tcf_refcnt) - ref,
-	opt.bindcnt = atomic_read(&ife->tcf_bindcnt) - bind,
+	opt.index = ife->tcf_index;
+	opt.refcnt = refcount_read(&ife->tcf_refcnt) - ref;
+	opt.bindcnt = atomic_read(&ife->tcf_bindcnt) - bind;
 
 	spin_lock_bh(&ife->tcf_lock);
 	opt.action = ife->tcf_action;
-- 
2.25.1

Re: [PATCH] net/sched: act_ife: convert comma to semicolon

Posted by Jamal Hadi Salim 2 months, 3 weeks ago

On Wed, Nov 12, 2025 at 2:28 AM Chen Ni <nichen@iscas.ac.cn> wrote:
>
> Replace comma between expressions with semicolons.
>
> Using a ',' in place of a ';' can have unintended side effects.
> Although that is not the case here, it is seems best to use ';'
> unless ',' is intended.
>

IIRC, Simon brought this up in the review as well...

> Found by inspection.
> No functional change intended.
> Compile tested only.
>
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>

Reviewed-by: Jamal Hadi Salim <jhs@mojatatu.com>

cheers,
jamal

> ---
>  net/sched/act_ife.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/net/sched/act_ife.c b/net/sched/act_ife.c
> index 7c6975632fc2..1dfdda6c2d4c 100644
> --- a/net/sched/act_ife.c
> +++ b/net/sched/act_ife.c
> @@ -649,9 +649,9 @@ static int tcf_ife_dump(struct sk_buff *skb, struct tc_action *a, int bind,
>
>         memset(&opt, 0, sizeof(opt));
>
> -       opt.index = ife->tcf_index,
> -       opt.refcnt = refcount_read(&ife->tcf_refcnt) - ref,
> -       opt.bindcnt = atomic_read(&ife->tcf_bindcnt) - bind,
> +       opt.index = ife->tcf_index;
> +       opt.refcnt = refcount_read(&ife->tcf_refcnt) - ref;
> +       opt.bindcnt = atomic_read(&ife->tcf_bindcnt) - bind;
>
>         spin_lock_bh(&ife->tcf_lock);
>         opt.action = ife->tcf_action;
> --
> 2.25.1
>

Re: [PATCH] net/sched: act_ife: convert comma to semicolon

Posted by Simon Horman 2 months, 2 weeks ago

On Wed, Nov 12, 2025 at 05:50:36AM -0500, Jamal Hadi Salim wrote:
> On Wed, Nov 12, 2025 at 2:28 AM Chen Ni <nichen@iscas.ac.cn> wrote:
> >
> > Replace comma between expressions with semicolons.
> >
> > Using a ',' in place of a ';' can have unintended side effects.
> > Although that is not the case here, it is seems best to use ';'
> > unless ',' is intended.
> >
> 
> IIRC, Simon brought this up in the review as well...

Yes, I might have.
But at any rate I agree with the analysis above.

> 
> > Found by inspection.
> > No functional change intended.
> > Compile tested only.
> >
> > Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> 
> Reviewed-by: Jamal Hadi Salim <jhs@mojatatu.com>

...