[PATCH v2 1/2] dt-bindings: arm: keystone: add missing items to mboxes

Anshul Dalal posted 2 patches 2 months, 4 weeks ago
There is a newer version of this series
[PATCH v2 1/2] dt-bindings: arm: keystone: add missing items to mboxes
Posted by Anshul Dalal 2 months, 4 weeks ago
The mailboxes for the ti,sci node were not documented, this patch adds
the description for the two channel entries as per TI-SCI spec[1].

[1]:
https://software-dl.ti.com/tisci/esd/latest/5_soc_doc/am65x/sec_proxy.html

Signed-off-by: Anshul Dalal <anshuld@ti.com>
---
 Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml b/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
index 25a2b42105e541cb3c8ad12a0dfec1af038fa907..182915c34fc1429fb627ac44c99c0c76fdf28e0f 100644
--- a/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
+++ b/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
@@ -60,6 +60,12 @@ properties:
 
   mboxes:
     minItems: 2
+    description: |
+      List of phandles to mailbox channels used for receiving and transmitting
+      data from and to the TI-SCI Controller.
+    items:
+      - description: RX thread
+      - description: TX thread
 
   ti,host-id:
     $ref: /schemas/types.yaml#/definitions/uint32

-- 
2.51.0
Re: [PATCH v2 1/2] dt-bindings: arm: keystone: add missing items to mboxes
Posted by Rob Herring (Arm) 2 months, 4 weeks ago
On Wed, 12 Nov 2025 14:00:53 +0530, Anshul Dalal wrote:
> The mailboxes for the ti,sci node were not documented, this patch adds
> the description for the two channel entries as per TI-SCI spec[1].
> 
> [1]:
> https://software-dl.ti.com/tisci/esd/latest/5_soc_doc/am65x/sec_proxy.html
> 
> Signed-off-by: Anshul Dalal <anshuld@ti.com>
> ---
>  Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml: properties:mboxes: 'oneOf' conditional failed, one must be fixed:
	False schema does not allow 2
	[{'description': 'RX thread'}, {'description': 'TX thread'}] is too long
	[{'description': 'RX thread'}, {'description': 'TX thread'}] is too short
	1 was expected
	hint: "minItems" is only needed if less than the "items" list length
	from schema $id: http://devicetree.org/meta-schemas/items.yaml

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20251112-k3_syscon_add_boot_mailboxes-v2-1-aebc1e47b391@ti.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
Re: [PATCH v2 1/2] dt-bindings: arm: keystone: add missing items to mboxes
Posted by Krzysztof Kozlowski 2 months, 4 weeks ago
On 12/11/2025 09:30, Anshul Dalal wrote:
> The mailboxes for the ti,sci node were not documented, this patch adds
> the description for the two channel entries as per TI-SCI spec[1].
> 
> [1]:
> https://software-dl.ti.com/tisci/esd/latest/5_soc_doc/am65x/sec_proxy.html
> 
> Signed-off-by: Anshul Dalal <anshuld@ti.com>
> ---
>  Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml b/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
> index 25a2b42105e541cb3c8ad12a0dfec1af038fa907..182915c34fc1429fb627ac44c99c0c76fdf28e0f 100644
> --- a/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
> +++ b/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
> @@ -60,6 +60,12 @@ properties:
>  
>    mboxes:
>      minItems: 2

That's wrong now.

> +    description: |
> +      List of phandles to mailbox channels used for receiving and transmitting

Drop, completely redundant. I don't understand why you added it.

> +      data from and to the TI-SCI Controller.

Best regards,
Krzysztof