We want to change ::new() to take no parameters and produce a pool that
is as large as possible while also being inline because that is the
constructor that Rust Binder actually needs.
However, to avoid complications in examples, we still need the current
constructor. So rename it to with_capacity(), which is the idiomatic
Rust name for this kind constructor.
Reviewed-by: Burak Emir <bqe@google.com>
Signed-off-by: Alice Ryhl <aliceryhl@google.com>
---
rust/kernel/id_pool.rs | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/rust/kernel/id_pool.rs b/rust/kernel/id_pool.rs
index 8f68b45a3da1f62dd0d010480837de49b9a343ba..90836b05c6155f98ab8393c8291749f408dbd4da 100644
--- a/rust/kernel/id_pool.rs
+++ b/rust/kernel/id_pool.rs
@@ -26,7 +26,7 @@
/// use kernel::alloc::{AllocError, flags::GFP_KERNEL};
/// use kernel::id_pool::IdPool;
///
-/// let mut pool = IdPool::new(64, GFP_KERNEL)?;
+/// let mut pool = IdPool::with_capacity(64, GFP_KERNEL)?;
/// for i in 0..64 {
/// assert_eq!(i, pool.acquire_next_id(i).ok_or(ENOSPC)?);
/// }
@@ -93,14 +93,14 @@ pub fn realloc(&self, flags: Flags) -> Result<PoolResizer, AllocError> {
}
impl IdPool {
- /// Constructs a new [`IdPool`].
+ /// Constructs a new [`IdPool`] with space for a specific number of bits.
///
/// A capacity below [`MAX_INLINE_LEN`] is adjusted to [`MAX_INLINE_LEN`].
///
/// [`MAX_INLINE_LEN`]: BitmapVec::MAX_INLINE_LEN
#[inline]
- pub fn new(num_ids: usize, flags: Flags) -> Result<Self, AllocError> {
- let num_ids = usize::max(num_ids, BitmapVec::MAX_INLINE_LEN);
+ pub fn with_capacity(num_ids: usize, flags: Flags) -> Result<Self, AllocError> {
+ let num_ids = usize::max(num_ids, BITS_PER_LONG);
let map = BitmapVec::new(num_ids, flags)?;
Ok(Self { map })
}
@@ -123,7 +123,7 @@ pub fn capacity(&self) -> usize {
/// use kernel::alloc::{AllocError, flags::GFP_KERNEL};
/// use kernel::id_pool::{ReallocRequest, IdPool};
///
- /// let mut pool = IdPool::new(1024, GFP_KERNEL)?;
+ /// let mut pool = IdPool::with_capacity(1024, GFP_KERNEL)?;
/// let alloc_request = pool.shrink_request().ok_or(AllocError)?;
/// let resizer = alloc_request.realloc(GFP_KERNEL)?;
/// pool.shrink(resizer);
--
2.51.2.1041.gc1ab5b90ca-googHi Alice, kernel test robot noticed the following build errors: [auto build test ERROR on 211ddde0823f1442e4ad052a2f30f050145ccada] url: https://github.com/intel-lab-lkp/linux/commits/Alice-Ryhl/rust-bitmap-add-MAX_LEN-and-MAX_INLINE_LEN-constants/20251112-205752 base: 211ddde0823f1442e4ad052a2f30f050145ccada patch link: https://lore.kernel.org/r/20251112-binder-bitmap-v5-3-8b9d7c7eca82%40google.com patch subject: [PATCH v5 3/6] rust: bitmap: rename IdPool::new() to with_capacity() config: x86_64-rhel-9.4-rust (https://download.01.org/0day-ci/archive/20251114/202511140825.Bbsm1dKT-lkp@intel.com/config) compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261) rustc: rustc 1.88.0 (6b00bc388 2025-06-23) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251114/202511140825.Bbsm1dKT-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202511140825.Bbsm1dKT-lkp@intel.com/ All errors (new ones prefixed by >>): In file included from kernel/sched/rq-offsets.c:5: kernel/sched/sched.h:3743:18: warning: variable 'cpumask' set but not used [-Wunused-but-set-variable] 3743 | struct cpumask *cpumask; | ^ 1 warning generated. >> error[E0425]: cannot find value `BITS_PER_LONG` in this scope --> rust/kernel/id_pool.rs:103:43 | 103 | let num_ids = usize::max(num_ids, BITS_PER_LONG); | ^^^^^^^^^^^^^ not found in this scope | help: consider importing one of these constants | 7 + use crate::bindings::BITS_PER_LONG; | 7 + use crate::uapi::BITS_PER_LONG; | 7 + use bindings::BITS_PER_LONG; | 7 + use uapi::BITS_PER_LONG; | -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
On Wed, Nov 12, 2025 at 12:47:21PM +0000, Alice Ryhl wrote:
> We want to change ::new() to take no parameters and produce a pool that
> is as large as possible while also being inline because that is the
> constructor that Rust Binder actually needs.
>
> However, to avoid complications in examples, we still need the current
> constructor. So rename it to with_capacity(), which is the idiomatic
> Rust name for this kind constructor.
>
> Reviewed-by: Burak Emir <bqe@google.com>
> Signed-off-by: Alice Ryhl <aliceryhl@google.com>
> ---
> rust/kernel/id_pool.rs | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/rust/kernel/id_pool.rs b/rust/kernel/id_pool.rs
> index 8f68b45a3da1f62dd0d010480837de49b9a343ba..90836b05c6155f98ab8393c8291749f408dbd4da 100644
> --- a/rust/kernel/id_pool.rs
> +++ b/rust/kernel/id_pool.rs
> @@ -26,7 +26,7 @@
> /// use kernel::alloc::{AllocError, flags::GFP_KERNEL};
> /// use kernel::id_pool::IdPool;
> ///
> -/// let mut pool = IdPool::new(64, GFP_KERNEL)?;
> +/// let mut pool = IdPool::with_capacity(64, GFP_KERNEL)?;
> /// for i in 0..64 {
> /// assert_eq!(i, pool.acquire_next_id(i).ok_or(ENOSPC)?);
> /// }
> @@ -93,14 +93,14 @@ pub fn realloc(&self, flags: Flags) -> Result<PoolResizer, AllocError> {
> }
>
> impl IdPool {
> - /// Constructs a new [`IdPool`].
> + /// Constructs a new [`IdPool`] with space for a specific number of bits.
> ///
> /// A capacity below [`MAX_INLINE_LEN`] is adjusted to [`MAX_INLINE_LEN`].
> ///
> /// [`MAX_INLINE_LEN`]: BitmapVec::MAX_INLINE_LEN
> #[inline]
> - pub fn new(num_ids: usize, flags: Flags) -> Result<Self, AllocError> {
> - let num_ids = usize::max(num_ids, BitmapVec::MAX_INLINE_LEN);
> + pub fn with_capacity(num_ids: usize, flags: Flags) -> Result<Self, AllocError> {
> + let num_ids = usize::max(num_ids, BITS_PER_LONG);
let num_ids = usize::max(num_ids, MAX_INLINE_LEN);
> let map = BitmapVec::new(num_ids, flags)?;
> Ok(Self { map })
> }
> @@ -123,7 +123,7 @@ pub fn capacity(&self) -> usize {
> /// use kernel::alloc::{AllocError, flags::GFP_KERNEL};
> /// use kernel::id_pool::{ReallocRequest, IdPool};
> ///
> - /// let mut pool = IdPool::new(1024, GFP_KERNEL)?;
> + /// let mut pool = IdPool::with_capacity(1024, GFP_KERNEL)?;
> /// let alloc_request = pool.shrink_request().ok_or(AllocError)?;
> /// let resizer = alloc_request.realloc(GFP_KERNEL)?;
> /// pool.shrink(resizer);
>
> --
> 2.51.2.1041.gc1ab5b90ca-goog
On Wed, Nov 12, 2025 at 12:47:21PM +0000, Alice Ryhl wrote: > We want to change ::new() to take no parameters and produce a pool that > is as large as possible while also being inline because that is the > constructor that Rust Binder actually needs. > > However, to avoid complications in examples, we still need the current > constructor. So rename it to with_capacity(), which is the idiomatic > Rust name for this kind constructor. > > Reviewed-by: Burak Emir <bqe@google.com> > Signed-off-by: Alice Ryhl <aliceryhl@google.com> > - let num_ids = usize::max(num_ids, BitmapVec::MAX_INLINE_LEN); > + let num_ids = usize::max(num_ids, BITS_PER_LONG); Ah ... I messed up the rebase here. Alice
© 2016 - 2026 Red Hat, Inc.