clocksource/drivers: Prevent clockevent driver unbind

[PATCH 1/3] clocksource/drivers/arm_arch_timer_mmio: Prevent driver unbind

Posted by Johan Hovold 2 months, 4 weeks ago

Clockevents cannot be deregistered so suppress the bind attributes to
prevent the driver from being unbound and releasing the underlying
resources after registration.

Fixes: 4891f01527bb ("clocksource/drivers/arm_arch_timer: Add standalone MMIO driver")
Signed-off-by: Johan Hovold <johan@kernel.org>
---
 drivers/clocksource/arm_arch_timer_mmio.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/clocksource/arm_arch_timer_mmio.c b/drivers/clocksource/arm_arch_timer_mmio.c
index ebe1987d651e..d10362692fdd 100644
--- a/drivers/clocksource/arm_arch_timer_mmio.c
+++ b/drivers/clocksource/arm_arch_timer_mmio.c
@@ -426,6 +426,7 @@ static struct platform_driver arch_timer_mmio_drv = {
 	.driver	= {
 		.name = "arch-timer-mmio",
 		.of_match_table	= arch_timer_mmio_of_table,
+		.suppress_bind_attrs = true,
 	},
 	.probe	= arch_timer_mmio_probe,
 };
@@ -434,6 +435,7 @@ builtin_platform_driver(arch_timer_mmio_drv);
 static struct platform_driver arch_timer_mmio_acpi_drv = {
 	.driver	= {
 		.name = "gtdt-arm-mmio-timer",
+		.suppress_bind_attrs = true,
 	},
 	.probe	= arch_timer_mmio_probe,
 };
-- 
2.51.0

Re: [PATCH 1/3] clocksource/drivers/arm_arch_timer_mmio: Prevent driver unbind

Posted by Marc Zyngier 2 months, 4 weeks ago

On Tue, 11 Nov 2025 15:32:24 +0000,
Johan Hovold <johan@kernel.org> wrote:
> 
> Clockevents cannot be deregistered so suppress the bind attributes to
> prevent the driver from being unbound and releasing the underlying
> resources after registration.
> 
> Fixes: 4891f01527bb ("clocksource/drivers/arm_arch_timer: Add standalone MMIO driver")
> Signed-off-by: Johan Hovold <johan@kernel.org>
> ---
>  drivers/clocksource/arm_arch_timer_mmio.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/clocksource/arm_arch_timer_mmio.c b/drivers/clocksource/arm_arch_timer_mmio.c
> index ebe1987d651e..d10362692fdd 100644
> --- a/drivers/clocksource/arm_arch_timer_mmio.c
> +++ b/drivers/clocksource/arm_arch_timer_mmio.c
> @@ -426,6 +426,7 @@ static struct platform_driver arch_timer_mmio_drv = {
>  	.driver	= {
>  		.name = "arch-timer-mmio",
>  		.of_match_table	= arch_timer_mmio_of_table,
> +		.suppress_bind_attrs = true,
>  	},
>  	.probe	= arch_timer_mmio_probe,
>  };
> @@ -434,6 +435,7 @@ builtin_platform_driver(arch_timer_mmio_drv);
>  static struct platform_driver arch_timer_mmio_acpi_drv = {
>  	.driver	= {
>  		.name = "gtdt-arm-mmio-timer",
> +		.suppress_bind_attrs = true,
>  	},
>  	.probe	= arch_timer_mmio_probe,
>  };

Acked-by: Marc Zyngier <maz@kernel.org>

	M.

-- 
Without deviation from the norm, progress is not possible.

[tip: timers/clocksource] clocksource/drivers/arm_arch_timer_mmio: Prevent driver unbind

Posted by tip-bot2 for Johan Hovold 2 months, 1 week ago

The following commit has been merged into the timers/clocksource branch of tip:

Commit-ID:     6aa10f0e2ef9eba1955be6a9d0a8eaecf6bdb7ae
Gitweb:        https://git.kernel.org/tip/6aa10f0e2ef9eba1955be6a9d0a8eaecf6bdb7ae
Author:        Johan Hovold <johan@kernel.org>
AuthorDate:    Tue, 11 Nov 2025 16:32:24 +01:00
Committer:     Daniel Lezcano <daniel.lezcano@linaro.org>
CommitterDate: Wed, 26 Nov 2025 11:24:47 +01:00

clocksource/drivers/arm_arch_timer_mmio: Prevent driver unbind

Clockevents cannot be deregistered so suppress the bind attributes to
prevent the driver from being unbound and releasing the underlying
resources after registration.

Fixes: 4891f01527bb ("clocksource/drivers/arm_arch_timer: Add standalone MMIO driver")
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Acked-by: Marc Zyngier <maz@kernel.org>
Link: https://patch.msgid.link/20251111153226.579-2-johan@kernel.org
---
 drivers/clocksource/arm_arch_timer_mmio.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/clocksource/arm_arch_timer_mmio.c b/drivers/clocksource/arm_arch_timer_mmio.c
index ebe1987..d103626 100644
--- a/drivers/clocksource/arm_arch_timer_mmio.c
+++ b/drivers/clocksource/arm_arch_timer_mmio.c
@@ -426,6 +426,7 @@ static struct platform_driver arch_timer_mmio_drv = {
 	.driver	= {
 		.name = "arch-timer-mmio",
 		.of_match_table	= arch_timer_mmio_of_table,
+		.suppress_bind_attrs = true,
 	},
 	.probe	= arch_timer_mmio_probe,
 };
@@ -434,6 +435,7 @@ builtin_platform_driver(arch_timer_mmio_drv);
 static struct platform_driver arch_timer_mmio_acpi_drv = {
 	.driver	= {
 		.name = "gtdt-arm-mmio-timer",
+		.suppress_bind_attrs = true,
 	},
 	.probe	= arch_timer_mmio_probe,
 };