From: Baolin Liu <liubaolin@kylinos.cn>

In barn_shrink(),use LIST_HEAD() to declare and initialize
the list_head in one step instead of using INIT_LIST_HEAD() separately.

No functional change.

Signed-off-by: Baolin Liu <liubaolin@kylinos.cn>
---
 mm/slub.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/mm/slub.c b/mm/slub.c
index f1a5373eee7b..0ab5d87305af 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -3011,14 +3011,11 @@ static void barn_init(struct node_barn *barn)
 
 static void barn_shrink(struct kmem_cache *s, struct node_barn *barn)
 {
-	struct list_head empty_list;
-	struct list_head full_list;
+	LIST_HEAD(empty_list);
+	LIST_HEAD(full_list);
 	struct slab_sheaf *sheaf, *sheaf2;
 	unsigned long flags;
 
-	INIT_LIST_HEAD(&empty_list);
-	INIT_LIST_HEAD(&full_list);
-
 	spin_lock_irqsave(&barn->lock, flags);
 
 	list_splice_init(&barn->sheaves_full, &full_list);
-- 
2.39.2

On Tue, Nov 11, 2025 at 08:22:05PM +0800, Baolin Liu wrote:
> From: Baolin Liu <liubaolin@kylinos.cn>
> 
> In barn_shrink(),use LIST_HEAD() to declare and initialize
                  ^ nit: need space after comma

> the list_head in one step instead of using INIT_LIST_HEAD() separately.
> 
> No functional change.
> 
> Signed-off-by: Baolin Liu <liubaolin@kylinos.cn>
> ---

Looks good to me,
Reviewed-by: Harry Yoo <harry.yoo@oracle.com>

-- 
Cheers,
Harry / Hyeonggon

On 11/13/25 09:37, Harry Yoo wrote:
> On Tue, Nov 11, 2025 at 08:22:05PM +0800, Baolin Liu wrote:
>> From: Baolin Liu <liubaolin@kylinos.cn>
>> 
>> In barn_shrink(),use LIST_HEAD() to declare and initialize
>                   ^ nit: need space after comma

Fixed up locally.

> 
>> the list_head in one step instead of using INIT_LIST_HEAD() separately.
>> 
>> No functional change.
>> 
>> Signed-off-by: Baolin Liu <liubaolin@kylinos.cn>
>> ---
> 
> Looks good to me,
> Reviewed-by: Harry Yoo <harry.yoo@oracle.com>

Thanks, applied to slab/for-next