[PATCH v1] f2fs: simplify list initialization in f2fs_recover_fsync_data()

Baolin Liu posted 1 patch 2 months, 3 weeks ago
fs/f2fs/recovery.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
[PATCH v1] f2fs: simplify list initialization in f2fs_recover_fsync_data()
Posted by Baolin Liu 2 months, 3 weeks ago
From: Baolin Liu <liubaolin@kylinos.cn>

In f2fs_recover_fsync_data(),use LIST_HEAD() to declare and
initialize the list_head in one step instead of using
INIT_LIST_HEAD() separately.

No functional change.

Signed-off-by: Baolin Liu <liubaolin@kylinos.cn>
---
 fs/f2fs/recovery.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/fs/f2fs/recovery.c b/fs/f2fs/recovery.c
index 215e442db72c..3d85d15a4f8b 100644
--- a/fs/f2fs/recovery.c
+++ b/fs/f2fs/recovery.c
@@ -869,8 +869,9 @@ static int recover_data(struct f2fs_sb_info *sbi, struct list_head *inode_list,
 
 int f2fs_recover_fsync_data(struct f2fs_sb_info *sbi, bool check_only)
 {
-	struct list_head inode_list, tmp_inode_list;
-	struct list_head dir_list;
+	LIST_HEAD(inode_list);
+	LIST_HEAD(tmp_inode_list);
+	LIST_HEAD(dir_list);
 	int err;
 	int ret = 0;
 	unsigned long s_flags = sbi->sb->s_flags;
@@ -882,10 +883,6 @@ int f2fs_recover_fsync_data(struct f2fs_sb_info *sbi, bool check_only)
 	if (is_sbi_flag_set(sbi, SBI_IS_WRITABLE))
 		f2fs_info(sbi, "recover fsync data on readonly fs");
 
-	INIT_LIST_HEAD(&inode_list);
-	INIT_LIST_HEAD(&tmp_inode_list);
-	INIT_LIST_HEAD(&dir_list);
-
 	/* prevent checkpoint */
 	f2fs_down_write(&sbi->cp_global_sem);
 
-- 
2.39.2
Re: [PATCH v1] f2fs: simplify list initialization in f2fs_recover_fsync_data()
Posted by Chao Yu 2 months, 3 weeks ago
On 11/11/25 20:17, Baolin Liu wrote:
> From: Baolin Liu <liubaolin@kylinos.cn>
> 
> In f2fs_recover_fsync_data(),use LIST_HEAD() to declare and
> initialize the list_head in one step instead of using
> INIT_LIST_HEAD() separately.
> 
> No functional change.
> 
> Signed-off-by: Baolin Liu <liubaolin@kylinos.cn>

Reviewed-by: Chao Yu <chao@kernel.org>

Thanks,