[v2] EDAC/altera: Use INTTEST register for Ethernet and USB SBE injection

[PATCH v2] EDAC/altera: Use INTTEST register for Ethernet and USB SBE injection

Posted by niravkumarlaxmidas.rabara@altera.com 2 months, 4 weeks ago

From: Niravkumar L Rabara <niravkumarlaxmidas.rabara@altera.com>

The current single-bit error injection mechanism flips bits directly in
ECC RAM by performing write and read operations. When the ECC RAM is
actively used by the Ethernet or USB controller, this approach sometimes
trigger a false double-bit error.

Switch both Ethernet and USB EDAC devices to use the INTTEST register
(altr_edac_a10_device_inject_fops) for single-bit error injection,
similar to the existing double-bit error injection method.

Fixes: 064acbd4f4ab ("EDAC, altera: Add Stratix10 peripheral support")
Cc: stable@vger.kernel.org
Signed-off-by: Niravkumar L Rabara <niravkumarlaxmidas.rabara@altera.com>
---

v2 changes:
 - Add missing Cc tag

v1 link:
https://lore.kernel.org/all/20251101051723.917688-1-niravkumarlaxmidas.rabara@altera.com/

 drivers/edac/altera_edac.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/edac/altera_edac.c b/drivers/edac/altera_edac.c
index 103b2c2eba2a..5c5d4585d8ae 100644
--- a/drivers/edac/altera_edac.c
+++ b/drivers/edac/altera_edac.c
@@ -1357,7 +1357,7 @@ static const struct edac_device_prv_data a10_enetecc_data = {
 	.ue_set_mask = ALTR_A10_ECC_TDERRA,
 	.set_err_ofst = ALTR_A10_ECC_INTTEST_OFST,
 	.ecc_irq_handler = altr_edac_a10_ecc_irq,
-	.inject_fops = &altr_edac_a10_device_inject2_fops,
+	.inject_fops = &altr_edac_a10_device_inject_fops,
 };
 
 #endif	/* CONFIG_EDAC_ALTERA_ETHERNET */
@@ -1447,7 +1447,7 @@ static const struct edac_device_prv_data a10_usbecc_data = {
 	.ue_set_mask = ALTR_A10_ECC_TDERRA,
 	.set_err_ofst = ALTR_A10_ECC_INTTEST_OFST,
 	.ecc_irq_handler = altr_edac_a10_ecc_irq,
-	.inject_fops = &altr_edac_a10_device_inject2_fops,
+	.inject_fops = &altr_edac_a10_device_inject_fops,
 };
 
 #endif	/* CONFIG_EDAC_ALTERA_USB */
-- 
2.25.1

Re: [PATCH v2] EDAC/altera: Use INTTEST register for Ethernet and USB SBE injection

Posted by Borislav Petkov 2 months, 4 weeks ago

On Tue, Nov 11, 2025 at 04:13:33PM +0800, niravkumarlaxmidas.rabara@altera.com wrote:
> From: Niravkumar L Rabara <niravkumarlaxmidas.rabara@altera.com>
> 
> The current single-bit error injection mechanism flips bits directly in
> ECC RAM by performing write and read operations. When the ECC RAM is
> actively used by the Ethernet or USB controller, this approach sometimes
> trigger a false double-bit error.
> 
> Switch both Ethernet and USB EDAC devices to use the INTTEST register
> (altr_edac_a10_device_inject_fops) for single-bit error injection,
> similar to the existing double-bit error injection method.
> 
> Fixes: 064acbd4f4ab ("EDAC, altera: Add Stratix10 peripheral support")
> Cc: stable@vger.kernel.org
> Signed-off-by: Niravkumar L Rabara <niravkumarlaxmidas.rabara@altera.com>
> ---
> 
> v2 changes:
>  - Add missing Cc tag
> 
> v1 link:
> https://lore.kernel.org/all/20251101051723.917688-1-niravkumarlaxmidas.rabara@altera.com/
> 
>  drivers/edac/altera_edac.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied, thanks.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

Re: [PATCH v2] EDAC/altera: Use INTTEST register for Ethernet and USB SBE injection

Posted by Dinh Nguyen 2 months, 4 weeks ago


On 11/11/25 02:13, niravkumarlaxmidas.rabara@altera.com wrote:
> From: Niravkumar L Rabara <niravkumarlaxmidas.rabara@altera.com>
> 
> The current single-bit error injection mechanism flips bits directly in
> ECC RAM by performing write and read operations. When the ECC RAM is
> actively used by the Ethernet or USB controller, this approach sometimes
> trigger a false double-bit error.
> 
> Switch both Ethernet and USB EDAC devices to use the INTTEST register
> (altr_edac_a10_device_inject_fops) for single-bit error injection,
> similar to the existing double-bit error injection method.
> 
> Fixes: 064acbd4f4ab ("EDAC, altera: Add Stratix10 peripheral support")
> Cc: stable@vger.kernel.org
> Signed-off-by: Niravkumar L Rabara <niravkumarlaxmidas.rabara@altera.com>
> ---
> 
> v2 changes:
>   - Add missing Cc tag
> 
> v1 link:
> https://lore.kernel.org/all/20251101051723.917688-1-niravkumarlaxmidas.rabara@altera.com/
> 
>   drivers/edac/altera_edac.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/edac/altera_edac.c b/drivers/edac/altera_edac.c
> index 103b2c2eba2a..5c5d4585d8ae 100644
> --- a/drivers/edac/altera_edac.c
> +++ b/drivers/edac/altera_edac.c

Acked-by: Dinh Nguyen <dinguyen@kernel.org>