Add a compatible string for sq52210, sq52210 is forward compatible
with INA3221 and add alert register to implement four additional
alert function.
Signed-off-by: Wenliang Yan <wenliang202407@163.com>
---
.../devicetree/bindings/hwmon/ti,ina3221.yaml | 16 +++++++++++++++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/hwmon/ti,ina3221.yaml b/Documentation/devicetree/bindings/hwmon/ti,ina3221.yaml
index 5f10f1207d69..0fae82ca3ee1 100644
--- a/Documentation/devicetree/bindings/hwmon/ti,ina3221.yaml
+++ b/Documentation/devicetree/bindings/hwmon/ti,ina3221.yaml
@@ -12,7 +12,9 @@ maintainers:
properties:
compatible:
- const: ti,ina3221
+ enum:
+ - silergy,sq52210
+ - ti,ina3221
reg:
maxItems: 1
@@ -77,6 +79,18 @@ patternProperties:
exclude specific channels from the summation control function.
type: boolean
+ alert-type:
+ description: |
+ The SQ52210 features a configurable alert function with four
+ types: SUL, BOL, BUL, and POL. Each channel can be configured to
+ select one of these types to enable the alert function. This alert
+ function can operate concurrently with both Critical and Warning
+ functions.
+
+ The configuration must use numerical values 0 through 3,
+ 0 corresponds to SUL, 1 to BOL, 2 to BUL, and 3 to POL.
+ enum: [ 0, 1, 2, 3 ]
+
required:
- reg
--
2.17.1On 11/11/25 00:05, Wenliang Yan wrote: > Add a compatible string for sq52210, sq52210 is forward compatible > with INA3221 and add alert register to implement four additional > alert function. > > Signed-off-by: Wenliang Yan <wenliang202407@163.com> > --- > .../devicetree/bindings/hwmon/ti,ina3221.yaml | 16 +++++++++++++++- > 1 file changed, 15 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/hwmon/ti,ina3221.yaml b/Documentation/devicetree/bindings/hwmon/ti,ina3221.yaml > index 5f10f1207d69..0fae82ca3ee1 100644 > --- a/Documentation/devicetree/bindings/hwmon/ti,ina3221.yaml > +++ b/Documentation/devicetree/bindings/hwmon/ti,ina3221.yaml > @@ -12,7 +12,9 @@ maintainers: > > properties: > compatible: > - const: ti,ina3221 > + enum: > + - silergy,sq52210 > + - ti,ina3221 > > reg: > maxItems: 1 > @@ -77,6 +79,18 @@ patternProperties: > exclude specific channels from the summation control function. > type: boolean > > + alert-type: > + description: | > + The SQ52210 features a configurable alert function with four > + types: SUL, BOL, BUL, and POL. Each channel can be configured to > + select one of these types to enable the alert function. This alert > + function can operate concurrently with both Critical and Warning > + functions. > + > + The configuration must use numerical values 0 through 3, > + 0 corresponds to SUL, 1 to BOL, 2 to BUL, and 3 to POL. > + enum: [ 0, 1, 2, 3 ] > + Per datasheet, each of the alerts can be enabled independently. It is possible to enable SUL, BOL, BUL, and POL on each channel at the same time. This is not possible with the above property since it only permits enabling alerts for one of the alert sources on each channel. Also, I am not sure if it makes sense to have this as devicetree property. It is not really a board property. It might make more sense to tie enabling the alerts automatically if a channel is enabled and a limit is set for a given channel. Guenter
At 2025-11-13 10:03:01, "Guenter Roeck" <linux@roeck-us.net> wrote: >On 11/11/25 00:05, Wenliang Yan wrote: >> Add a compatible string for sq52210, sq52210 is forward compatible >> with INA3221 and add alert register to implement four additional >> alert function. >> >> Signed-off-by: Wenliang Yan <wenliang202407@163.com> >> --- >> .../devicetree/bindings/hwmon/ti,ina3221.yaml | 16 +++++++++++++++- >> 1 file changed, 15 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/hwmon/ti,ina3221.yaml b/Documentation/devicetree/bindings/hwmon/ti,ina3221.yaml >> index 5f10f1207d69..0fae82ca3ee1 100644 >> --- a/Documentation/devicetree/bindings/hwmon/ti,ina3221.yaml >> +++ b/Documentation/devicetree/bindings/hwmon/ti,ina3221.yaml >> @@ -12,7 +12,9 @@ maintainers: >> >> properties: >> compatible: >> - const: ti,ina3221 >> + enum: >> + - silergy,sq52210 >> + - ti,ina3221 >> >> reg: >> maxItems: 1 >> @@ -77,6 +79,18 @@ patternProperties: >> exclude specific channels from the summation control function. >> type: boolean >> >> + alert-type: >> + description: | >> + The SQ52210 features a configurable alert function with four >> + types: SUL, BOL, BUL, and POL. Each channel can be configured to >> + select one of these types to enable the alert function. This alert >> + function can operate concurrently with both Critical and Warning >> + functions. >> + >> + The configuration must use numerical values 0 through 3, >> + 0 corresponds to SUL, 1 to BOL, 2 to BUL, and 3 to POL. >> + enum: [ 0, 1, 2, 3 ] >> + > >Per datasheet, each of the alerts can be enabled independently. It is possible >to enable SUL, BOL, BUL, and POL on each channel at the same time. This is not >possible with the above property since it only permits enabling alerts for one >of the alert sources on each channel. > >Also, I am not sure if it makes sense to have this as devicetree property. >It is not really a board property. It might make more sense to tie enabling >the alerts automatically if a channel is enabled and a limit is set for a >given channel. > The "If multiple function are enabled, the Alert Function with the highrst signifivant bit position(D15-D4) takes priority and responds to the Alert LImit Register" described on page 21 of the datasheet refers to the fact that when different trigger sources are enabled simultaneously, only the highest priority trigger source takes effect (SUL > BOL > BUL > POL).Therefore, essentially only one type of alert can be active per channel. Indeed, it is unnecessary to configure the alert-type at the board level. I will modify this content and conduct testing before the next submission, and also remove the alert-type support in Patch 3. Thanks, Wenlaing Yan
On Tue, 11 Nov 2025 03:05:39 -0500, Wenliang Yan wrote: > Add a compatible string for sq52210, sq52210 is forward compatible > with INA3221 and add alert register to implement four additional > alert function. > > Signed-off-by: Wenliang Yan <wenliang202407@163.com> > --- > .../devicetree/bindings/hwmon/ti,ina3221.yaml | 16 +++++++++++++++- > 1 file changed, 15 insertions(+), 1 deletion(-) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/hwmon/ti,ina3221.yaml: alert-type: missing type definition doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20251111080546.32421-2-wenliang202407@163.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
At 2025-11-11 17:32:18, "Rob Herring (Arm)" <robh@kernel.org> wrote: > >On Tue, 11 Nov 2025 03:05:39 -0500, Wenliang Yan wrote: >> Add a compatible string for sq52210, sq52210 is forward compatible >> with INA3221 and add alert register to implement four additional >> alert function. >> >> Signed-off-by: Wenliang Yan <wenliang202407@163.com> >> --- >> .../devicetree/bindings/hwmon/ti,ina3221.yaml | 16 +++++++++++++++- >> 1 file changed, 15 insertions(+), 1 deletion(-) >> > >My bot found errors running 'make dt_binding_check' on your patch: > >yamllint warnings/errors: > >dtschema/dtc warnings/errors: >/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/hwmon/ti,ina3221.yaml: alert-type: missing type definition > >doc reference errors (make refcheckdocs): > >See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20251111080546.32421-2-wenliang202407@163.com > >The base for the series is generally the latest rc1. A different dependency >should be noted in *this* patch. > >If you already ran 'make dt_binding_check' and didn't see the above >error(s), then make sure 'yamllint' is installed and dt-schema is up to >date: > >pip3 install dtschema --upgrade > >Please check and re-submit after running the above command yourself. Note >that DT_SCHEMA_FILES can be set to your schema file to speed up checking >your schema. However, it must be unset to test all examples with your schema. I apologize that my configuration error prevented these issues from being detected during runtime. I will update the tools and retest before the next submission. Thanks, Wenlaing Yan
On 11/11/2025 09:05, Wenliang Yan wrote: > Add a compatible string for sq52210, sq52210 is forward compatible > with INA3221 and add alert register to implement four additional > alert function. > > Signed-off-by: Wenliang Yan <wenliang202407@163.com> Please use subject prefixes matching the subsystem. You can get them for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching. For bindings, the preferred subjects are explained here: https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters It is never "dt-binding:". Also, all spaces are gone. Just look at `git log`. > --- > .../devicetree/bindings/hwmon/ti,ina3221.yaml | 16 +++++++++++++++- > 1 file changed, 15 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/hwmon/ti,ina3221.yaml b/Documentation/devicetree/bindings/hwmon/ti,ina3221.yaml > index 5f10f1207d69..0fae82ca3ee1 100644 > --- a/Documentation/devicetree/bindings/hwmon/ti,ina3221.yaml > +++ b/Documentation/devicetree/bindings/hwmon/ti,ina3221.yaml > @@ -12,7 +12,9 @@ maintainers: > > properties: > compatible: > - const: ti,ina3221 > + enum: > + - silergy,sq52210 > + - ti,ina3221 > > reg: > maxItems: 1 > @@ -77,6 +79,18 @@ patternProperties: > exclude specific channels from the summation control function. > type: boolean > > + alert-type: Not a generic property, missing type and vendor prefix. This clearly was not tested. > + description: | > + The SQ52210 features a configurable alert function with four > + types: SUL, BOL, BUL, and POL. Each channel can be configured to > + select one of these types to enable the alert function. This alert > + function can operate concurrently with both Critical and Warning > + functions. > + > + The configuration must use numerical values 0 through 3, Don't repeat constraints in free form text. > + 0 corresponds to SUL, 1 to BOL, 2 to BUL, and 3 to POL. > + enum: [ 0, 1, 2, 3 ] No, use string enum instead. Anyway, does not look like DT property. Why would alert type be set per board? Why I cannot change the alert during runtime? Best regards, Krzysztof
At 2025-11-11 16:17:26, "Krzysztof Kozlowski" <krzk@kernel.org> wrote: >On 11/11/2025 09:05, Wenliang Yan wrote: >> Add a compatible string for sq52210, sq52210 is forward compatible >> with INA3221 and add alert register to implement four additional >> alert function. >> >> Signed-off-by: Wenliang Yan <wenliang202407@163.com> > > >Please use subject prefixes matching the subsystem. You can get them for >example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory >your patch is touching. For bindings, the preferred subjects are >explained here: >https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters > >It is never "dt-binding:". Also, all spaces are gone. Just look at `git >log`. > I will change the subject to "dt-bindings: hwmon: ti,ina3221: Add SQ52210" before the next submission. > >> --- >> .../devicetree/bindings/hwmon/ti,ina3221.yaml | 16 +++++++++++++++- >> 1 file changed, 15 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/hwmon/ti,ina3221.yaml b/Documentation/devicetree/bindings/hwmon/ti,ina3221.yaml >> index 5f10f1207d69..0fae82ca3ee1 100644 >> --- a/Documentation/devicetree/bindings/hwmon/ti,ina3221.yaml >> +++ b/Documentation/devicetree/bindings/hwmon/ti,ina3221.yaml >> @@ -12,7 +12,9 @@ maintainers: >> >> properties: >> compatible: >> - const: ti,ina3221 >> + enum: >> + - silergy,sq52210 >> + - ti,ina3221 >> >> reg: >> maxItems: 1 >> @@ -77,6 +79,18 @@ patternProperties: >> exclude specific channels from the summation control function. >> type: boolean >> >> + alert-type: > >Not a generic property, missing type and vendor prefix. > >This clearly was not tested. > > >> + description: | >> + The SQ52210 features a configurable alert function with four >> + types: SUL, BOL, BUL, and POL. Each channel can be configured to >> + select one of these types to enable the alert function. This alert >> + function can operate concurrently with both Critical and Warning >> + functions. >> + >> + The configuration must use numerical values 0 through 3, > > >Don't repeat constraints in free form text. > >> + 0 corresponds to SUL, 1 to BOL, 2 to BUL, and 3 to POL. >> + enum: [ 0, 1, 2, 3 ] > >No, use string enum instead. > >Anyway, does not look like DT property. Why would alert type be set per >board? Why I cannot change the alert during runtime? > > You are right, my previous consideration was problematic. Indeed, there is no need to set the alert type at the board level. I will modify this content and test it before the next submission. Thanks, Wenlaing Yan
© 2016 - 2026 Red Hat, Inc.