dt-bindings: arm: keystone: add boot_* mailboxes

[PATCH RFC] dt-bindings: arm: keystone: add boot_* mailboxes

Posted by Anshul Dalal 2 months, 4 weeks ago

The bootloader on K3 devices makes use of mailboxes as per the ROM spec
which might be different than one's available to the kernel (firmware
spec).

Therefore, this patch adds the missing mailbox entries to the DT binding
to represent the mailboxes exposed by the hardware during boot for the
purpose of loading the firmware.

Signed-off-by: Anshul Dalal <anshuld@ti.com>
---
 Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml b/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
index 25a2b42105e541cb3c8ad12a0dfec1af038fa907..b5f48647a0f09bb930f052ea0f84a78525c925eb 100644
--- a/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
+++ b/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
@@ -51,15 +51,23 @@ properties:
     minItems: 1
 
   mbox-names:
+    minItems: 2
+    maxItems: 6
     description: |
       Specifies the mailboxes used to communicate with TI-SCI Controller
-      made available from TI-SCI controller.
+      made available from TI-SCI controller. All boot_* mailboxes are used by
+      the first stage bootloader to load firmware for the device.
     items:
       - const: rx
       - const: tx
+      - const: notify
+      - const: boot_rx
+      - const: boot_tx
+      - const: boot_notify
 
   mboxes:
     minItems: 2
+    maxItems: 6
 
   ti,host-id:
     $ref: /schemas/types.yaml#/definitions/uint32

---
base-commit: 1c353dc8d962de652bc7ad2ba2e63f553331391c
change-id: 20251105-k3_syscon_add_boot_mailboxes-8452bdd98962

Best regards,
-- 
Anshul Dalal <anshuld@ti.com>

Re: [PATCH RFC] dt-bindings: arm: keystone: add boot_* mailboxes

Posted by Krzysztof Kozlowski 2 months, 4 weeks ago

On 11/11/2025 11:37, Anshul Dalal wrote:
> The bootloader on K3 devices makes use of mailboxes as per the ROM spec
> which might be different than one's available to the kernel (firmware
> spec).

Why is this RFC? You don't expect review?

> 
> Therefore, this patch adds the missing mailbox entries to the DT binding
> to represent the mailboxes exposed by the hardware during boot for the
> purpose of loading the firmware.
> 
> Signed-off-by: Anshul Dalal <anshuld@ti.com>
> ---
>  Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml b/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
> index 25a2b42105e541cb3c8ad12a0dfec1af038fa907..b5f48647a0f09bb930f052ea0f84a78525c925eb 100644
> --- a/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
> +++ b/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
> @@ -51,15 +51,23 @@ properties:
>      minItems: 1
>  
>    mbox-names:
> +    minItems: 2
> +    maxItems: 6
>      description: |
>        Specifies the mailboxes used to communicate with TI-SCI Controller
> -      made available from TI-SCI controller.
> +      made available from TI-SCI controller. All boot_* mailboxes are used by
> +      the first stage bootloader to load firmware for the device.

Description does not go to mbox-names, but to mboxes.

>      items:
>        - const: rx
>        - const: tx
> +      - const: notify
> +      - const: boot_rx
> +      - const: boot_tx
> +      - const: boot_notify
>  
>    mboxes:
>      minItems: 2
> +    maxItems: 6

You need to list the items instead.

>  
>    ti,host-id:
>      $ref: /schemas/types.yaml#/definitions/uint32

You should update the example so it will be complete.

Best regards,
Krzysztof

Re: [PATCH RFC] dt-bindings: arm: keystone: add boot_* mailboxes

Posted by Anshul Dalal 2 months, 4 weeks ago

On Tue Nov 11, 2025 at 4:22 PM IST, Krzysztof Kozlowski wrote:
> On 11/11/2025 11:37, Anshul Dalal wrote:
>> The bootloader on K3 devices makes use of mailboxes as per the ROM spec
>> which might be different than one's available to the kernel (firmware
>> spec).
>
> Why is this RFC? You don't expect review?
>

Oh my bad, I forgot to reset the b4 prefix. This patch isn't meant to be
an RFC.

I will incorporate rest of your feedback as well and post a v2.

Thanks for the review!
Anshul

>> 
>> Therefore, this patch adds the missing mailbox entries to the DT binding
>> to represent the mailboxes exposed by the hardware during boot for the
>> purpose of loading the firmware.
>> 
>> Signed-off-by: Anshul Dalal <anshuld@ti.com>
>> ---
>>  Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml | 10 +++++++++-
>>  1 file changed, 9 insertions(+), 1 deletion(-)
>> 
>> diff --git a/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml b/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
>> index 25a2b42105e541cb3c8ad12a0dfec1af038fa907..b5f48647a0f09bb930f052ea0f84a78525c925eb 100644
>> --- a/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
>> +++ b/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
>> @@ -51,15 +51,23 @@ properties:
>>      minItems: 1
>>  
>>    mbox-names:
>> +    minItems: 2
>> +    maxItems: 6
>>      description: |
>>        Specifies the mailboxes used to communicate with TI-SCI Controller
>> -      made available from TI-SCI controller.
>> +      made available from TI-SCI controller. All boot_* mailboxes are used by
>> +      the first stage bootloader to load firmware for the device.
>
> Description does not go to mbox-names, but to mboxes.
>
>>      items:
>>        - const: rx
>>        - const: tx
>> +      - const: notify
>> +      - const: boot_rx
>> +      - const: boot_tx
>> +      - const: boot_notify
>>  
>>    mboxes:
>>      minItems: 2
>> +    maxItems: 6
>
> You need to list the items instead.
>
>>  
>>    ti,host-id:
>>      $ref: /schemas/types.yaml#/definitions/uint32
>
> You should update the example so it will be complete.
>
> Best regards,
> Krzysztof