[PATCH 0/3] rust_binder: fix unsoundness due to combining List::remove with mem:take

Alice Ryhl posted 3 patches 2 months, 4 weeks ago
drivers/android/binder/node.rs    | 6 +++---
drivers/android/binder/process.rs | 8 ++++++--
rust/kernel/list.rs               | 3 +++
3 files changed, 12 insertions(+), 5 deletions(-)
[PATCH 0/3] rust_binder: fix unsoundness due to combining List::remove with mem:take
Posted by Alice Ryhl 2 months, 4 weeks ago
See the first patch for details on the bug.

Signed-off-by: Alice Ryhl <aliceryhl@google.com>
---
Alice Ryhl (3):
      rust_binder: fix race condition on death_list
      rust_binder: avoid mem::take on delivered_deaths
      rust: list: add warning to List::remove docs about mem::take

 drivers/android/binder/node.rs    | 6 +++---
 drivers/android/binder/process.rs | 8 ++++++--
 rust/kernel/list.rs               | 3 +++
 3 files changed, 12 insertions(+), 5 deletions(-)
---
base-commit: 211ddde0823f1442e4ad052a2f30f050145ccada
change-id: 20251111-binder-fix-list-remove-41c29c75ffc9

Best regards,
-- 
Alice Ryhl <aliceryhl@google.com>
Re: [PATCH 0/3] rust_binder: fix unsoundness due to combining List::remove with mem:take
Posted by Miguel Ojeda 2 months, 3 weeks ago
On Tue, Nov 11, 2025 at 3:23 PM Alice Ryhl <aliceryhl@google.com> wrote:
>
>       rust_binder: fix race condition on death_list
>       rust_binder: avoid mem::take on delivered_deaths
>       rust: list: add warning to List::remove docs about mem::take

Greg et al.: please let me know if you are not taking the last one
together with the fixes (so that I pick it up). Otherwise, if you do:

Acked-by: Miguel Ojeda <ojeda@kernel.org>

Thanks!

Cheers,
Miguel
Re: [PATCH 0/3] rust_binder: fix unsoundness due to combining List::remove with mem:take
Posted by Greg Kroah-Hartman 2 months, 3 weeks ago
On Wed, Nov 12, 2025 at 11:22:25AM +0100, Miguel Ojeda wrote:
> On Tue, Nov 11, 2025 at 3:23 PM Alice Ryhl <aliceryhl@google.com> wrote:
> >
> >       rust_binder: fix race condition on death_list
> >       rust_binder: avoid mem::take on delivered_deaths
> >       rust: list: add warning to List::remove docs about mem::take
> 
> Greg et al.: please let me know if you are not taking the last one
> together with the fixes (so that I pick it up). Otherwise, if you do:
> 
> Acked-by: Miguel Ojeda <ojeda@kernel.org>

I'll take all of these, thanks for the ack!

greg k-h