[PATCH 2/2] firmware: stratix10-rsu: add COMPILE_TEST support

Rosen Penev posted 2 patches 2 months, 4 weeks ago
There is a newer version of this series
[PATCH 2/2] firmware: stratix10-rsu: add COMPILE_TEST support
Posted by Rosen Penev 2 months, 4 weeks ago
Helps the buildbots catch potential issues.

Remove ARM64 dependency. ARM32 can build this now.

Remove HAVE_ARM_SMCCC. On at least x86, it seems to not be needed.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
 drivers/firmware/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig
index bbd2155d8483..bbe478cfba6b 100644
--- a/drivers/firmware/Kconfig
+++ b/drivers/firmware/Kconfig
@@ -141,7 +141,7 @@ config FW_CFG_SYSFS_CMDLINE
 
 config INTEL_STRATIX10_SERVICE
 	tristate "Intel Stratix10 Service Layer"
-	depends on ARCH_INTEL_SOCFPGA && ARM64 && HAVE_ARM_SMCCC
+	depends on ARCH_INTEL_SOCFPGA || COMPILE_TEST
 	default n
 	help
 	  Intel Stratix10 service layer runs at privileged exception level,
-- 
2.51.2
Re: [PATCH 2/2] firmware: stratix10-rsu: add COMPILE_TEST support
Posted by Dinh Nguyen 2 months, 3 weeks ago
Hi Rosen,

On 11/10/25 15:24, Rosen Penev wrote:
> Helps the buildbots catch potential issues.
> 
> Remove ARM64 dependency. ARM32 can build this now.
> 

This driver will not run on an ARM32, so why are we trying to build for it?

Dinh
Re: [PATCH 2/2] firmware: stratix10-rsu: add COMPILE_TEST support
Posted by Rosen Penev 2 months, 3 weeks ago
On Tue, Nov 11, 2025 at 7:44 PM Dinh Nguyen <dinguyen@kernel.org> wrote:
>
> Hi Rosen,
>
> On 11/10/25 15:24, Rosen Penev wrote:
> > Helps the buildbots catch potential issues.
> >
> > Remove ARM64 dependency. ARM32 can build this now.
> >
>
> This driver will not run on an ARM32, so why are we trying to build for it?
I was mostly trying to get COMPILE_TEST working and compiled on ARM32
to make sure nothing blows up. I'll add back ARM64.
>
> Dinh