KVM: arm64: add missing newline to sysreg init log

[PATCH] KVM: arm64: add missing newline to sysreg init log

Posted by Osama Abdelkader 2 months, 4 weeks ago

missing newline so the  message is merged with follow-on logs
the change only affects console output formatting, no behavioral impact.

Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
---
 arch/arm64/kvm/arm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c
index 870953b4a8a7..156cd1a6106e 100644
--- a/arch/arm64/kvm/arm.c
+++ b/arch/arm64/kvm/arm.c
@@ -2845,7 +2845,7 @@ static __init int kvm_arm_init(void)
 
 	err = kvm_sys_reg_table_init();
 	if (err) {
-		kvm_info("Error initializing system register tables");
+		kvm_info("Error initializing system register tables\n");
 		return err;
 	}
 
-- 
2.43.0

Re: [PATCH] KVM: arm64: add missing newline to sysreg init log

Posted by Marc Zyngier 2 months, 4 weeks ago

On Mon, 10 Nov 2025 21:10:51 +0000,
Osama Abdelkader <osama.abdelkader@gmail.com> wrote:
> 
> missing newline so the  message is merged with follow-on logs
> the change only affects console output formatting, no behavioral impact.
> 
> Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
> ---
>  arch/arm64/kvm/arm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c
> index 870953b4a8a7..156cd1a6106e 100644
> --- a/arch/arm64/kvm/arm.c
> +++ b/arch/arm64/kvm/arm.c
> @@ -2845,7 +2845,7 @@ static __init int kvm_arm_init(void)
>  
>  	err = kvm_sys_reg_table_init();
>  	if (err) {
> -		kvm_info("Error initializing system register tables");
> +		kvm_info("Error initializing system register tables\n");
>  		return err;
>  	}
>  

Given that everything in kvm_sys_reg_table_init() already screams
badly when it fails, I don't see the point of an additional message,
and I'd rather remove it.

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.

Re: [PATCH] KVM: arm64: add missing newline to sysreg init log

Posted by Osama Abdelkader 2 months, 3 weeks ago

On Tue, Nov 11, 2025 at 09:49:03AM +0000, Marc Zyngier wrote:
> On Mon, 10 Nov 2025 21:10:51 +0000,
> Osama Abdelkader <osama.abdelkader@gmail.com> wrote:
> > 
> > missing newline so the  message is merged with follow-on logs
> > the change only affects console output formatting, no behavioral impact.
> > 
> > Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
> > ---
> >  arch/arm64/kvm/arm.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c
> > index 870953b4a8a7..156cd1a6106e 100644
> > --- a/arch/arm64/kvm/arm.c
> > +++ b/arch/arm64/kvm/arm.c
> > @@ -2845,7 +2845,7 @@ static __init int kvm_arm_init(void)
> >  
> >  	err = kvm_sys_reg_table_init();
> >  	if (err) {
> > -		kvm_info("Error initializing system register tables");
> > +		kvm_info("Error initializing system register tables\n");
> >  		return err;
> >  	}
> >  
> 
> Given that everything in kvm_sys_reg_table_init() already screams
> badly when it fails, I don't see the point of an additional message,
> and I'd rather remove it.
> 
> Thanks,
> 
> 	M.
> 
> -- 
> Without deviation from the norm, progress is not possible.

Thanks Marc. I just sent the patch to drop that message.

Thank you,
Osama