On 10/11/2025 18:40, Andy Shevchenko wrote:
> Use %ptSp instead of open coded variants to print content of
> struct timespec64 in human readable format.
>
> While at it, fix wrong use of %ptT against struct timespec64.
> It's kinda lucky that it worked just because the first member
> there 64-bit and it's of time64_t type. Now with %ptS it may
> be used correctly.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/ptp/ptp_ocp.c | 15 ++++++---------
> 1 file changed, 6 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/ptp/ptp_ocp.c b/drivers/ptp/ptp_ocp.c
> index a5c363252986..a0bb8d3045d2 100644
> --- a/drivers/ptp/ptp_ocp.c
> +++ b/drivers/ptp/ptp_ocp.c
> @@ -3261,7 +3261,7 @@ signal_show(struct device *dev, struct device_attribute *attr, char *buf)
> signal->duty, signal->phase, signal->polarity);
>
> ts = ktime_to_timespec64(signal->start);
> - count += sysfs_emit_at(buf, count, " %ptT TAI\n", &ts);
> + count += sysfs_emit_at(buf, count, " %ptS TAI\n", &ts);
>
> return count;
> }
> @@ -4287,11 +4287,9 @@ ptp_ocp_summary_show(struct seq_file *s, void *data)
> ns += (s64)bp->utc_tai_offset * NSEC_PER_SEC;
> sys_ts = ns_to_timespec64(ns);
>
> - seq_printf(s, "%7s: %lld.%ld == %ptT TAI\n", "PHC",
> - ts.tv_sec, ts.tv_nsec, &ts);
> - seq_printf(s, "%7s: %lld.%ld == %ptT UTC offset %d\n", "SYS",
> - sys_ts.tv_sec, sys_ts.tv_nsec, &sys_ts,
> - bp->utc_tai_offset);
> + seq_printf(s, "%7s: %ptSp == %ptS TAI\n", "PHC", &ts, &ts);
> + seq_printf(s, "%7s: %ptSp == %ptS UTC offset %d\n", "SYS",
> + &sys_ts, &sys_ts, bp->utc_tai_offset);
> seq_printf(s, "%7s: PHC:SYS offset: %lld window: %lld\n", "",
> timespec64_to_ns(&ts) - ns,
> post_ns - pre_ns);
> @@ -4499,9 +4497,8 @@ ptp_ocp_phc_info(struct ptp_ocp *bp)
> ptp_clock_index(bp->ptp));
>
> if (!ptp_ocp_gettimex(&bp->ptp_info, &ts, NULL))
> - dev_info(&bp->pdev->dev, "Time: %lld.%ld, %s\n",
> - ts.tv_sec, ts.tv_nsec,
> - bp->sync ? "in-sync" : "UNSYNCED");
> + dev_info(&bp->pdev->dev, "Time: %ptSp, %s\n",
> + &ts, bp->sync ? "in-sync" : "UNSYNCED");
> }
>
> static void
Acked-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>