fbdev/gxt4500: Use dev_err instead printk leftover.

[PATCH] fbdev/gxt4500: Use dev_err instead printk leftover.

Posted by Javier Garcia 2 months, 4 weeks ago

I coundn't test as not have that hw but cross compiled to check the code
change.

Fixes: a3d899839064 ("[PATCH] Fbdev driver for IBM GXT4500P videocards")
Signed-off-by: Javier Garcia <rampxxxx@gmail.com>
---
 drivers/video/fbdev/gxt4500.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/fbdev/gxt4500.c b/drivers/video/fbdev/gxt4500.c
index 15a82c6b609e..27a46e364419 100644
--- a/drivers/video/fbdev/gxt4500.c
+++ b/drivers/video/fbdev/gxt4500.c
@@ -704,7 +704,7 @@ static int gxt4500_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 	}
 	info->var = var;
 	if (gxt4500_set_par(info)) {
-		printk(KERN_ERR "gxt4500: cannot set video mode\n");
+		dev_err(&pdev->dev, "gxt4500: cannot set video mode\n");
 		goto err_free_cmap;
 	}
 
-- 
2.50.1

Re: [PATCH] fbdev/gxt4500: Use dev_err instead printk leftover.

Posted by Helge Deller 2 months, 3 weeks ago

On 11/10/25 17:52, Javier Garcia wrote:
> I coundn't test as not have that hw but cross compiled to check the code
> change.
> 
> Fixes: a3d899839064 ("[PATCH] Fbdev driver for IBM GXT4500P videocards")
> Signed-off-by: Javier Garcia <rampxxxx@gmail.com>
> ---
>   drivers/video/fbdev/gxt4500.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

applied.

Thanks!
Helge