[PATCH v2 0/2] LoongArch: Refine init_hw_perf_events()

Tiezhu Yang posted 2 patches 1 month, 1 week ago
arch/loongarch/include/asm/loongarch.h | 1 +
arch/loongarch/kernel/perf_event.c     | 7 ++++---
2 files changed, 5 insertions(+), 3 deletions(-)
[PATCH v2 0/2] LoongArch: Refine init_hw_perf_events()
Posted by Tiezhu Yang 1 month, 1 week ago
This version is based on 6.18-rc5, use the proper patch title
to make it clear.

Tiezhu Yang (2):
  LoongArch: Use CPUCFG6_PMNUM_SHIFT to get PMU number
  LoongArch: Detect PMU bits via CPUCFG instruction

 arch/loongarch/include/asm/loongarch.h | 1 +
 arch/loongarch/kernel/perf_event.c     | 7 ++++---
 2 files changed, 5 insertions(+), 3 deletions(-)

-- 
2.42.0
Re: [PATCH v2 0/2] LoongArch: Refine init_hw_perf_events()
Posted by Huacai Chen 1 month, 1 week ago
V1 was applied last week and now in linux-next, don't do meaningless work.

Huacai

On Mon, Nov 10, 2025 at 10:59 AM Tiezhu Yang <yangtiezhu@loongson.cn> wrote:
>
> This version is based on 6.18-rc5, use the proper patch title
> to make it clear.
>
> Tiezhu Yang (2):
>   LoongArch: Use CPUCFG6_PMNUM_SHIFT to get PMU number
>   LoongArch: Detect PMU bits via CPUCFG instruction
>
>  arch/loongarch/include/asm/loongarch.h | 1 +
>  arch/loongarch/kernel/perf_event.c     | 7 ++++---
>  2 files changed, 5 insertions(+), 3 deletions(-)
>
> --
> 2.42.0
>
Re: [PATCH v2 0/2] LoongArch: Refine init_hw_perf_events()
Posted by Tiezhu Yang 1 month, 1 week ago
在 2025/11/10 下午2:48, Huacai Chen 写道:
> V1 was applied last week and now in linux-next, don't do meaningless work.
> 
> Huacai
> 
> On Mon, Nov 10, 2025 at 10:59 AM Tiezhu Yang <yangtiezhu@loongson.cn> wrote:
>>
>> This version is based on 6.18-rc5, use the proper patch title
>> to make it clear.
>>
>> Tiezhu Yang (2):
>>    LoongArch: Use CPUCFG6_PMNUM_SHIFT to get PMU number
>>    LoongArch: Detect PMU bits via CPUCFG instruction
>>
>>   arch/loongarch/include/asm/loongarch.h | 1 +
>>   arch/loongarch/kernel/perf_event.c     | 7 ++++---
>>   2 files changed, 5 insertions(+), 3 deletions(-)

I do not like to argue with you, but I do not think what you said is
right, there are double standards here.

The code are rebased frequently by you in linux-loongson.git, the latest
is after 6.18-rc5 that is in this week, my patch is also rebased.

You accepted the suggestion of your patch v1 title [1] and send v2 [2]
although v1 has been applied by Andrew, because you think it is a good
suggestion.

I just do the similar and right thing,  but your reply is not polite
and friendly, and also do not do the thing what you should to do as a
maintainer.

[1] 
https://lore.kernel.org/linux-mm/20251108084724.3e389b6597294900347b0476@linux-foundation.org/

[2] 
https://lore.kernel.org/linux-mm/20251109021817.346181-1-chenhuacai@loongson.cn/

[3] 
https://git.kernel.org/pub/scm/linux/kernel/git/chenhuacai/linux-loongson.git/commit/?h=loongarch-fixes&id=4c8a7c982772

Thanks,
Tiezhu

Re: [PATCH v2 0/2] LoongArch: Refine init_hw_perf_events()
Posted by Huacai Chen 1 month, 1 week ago
On Mon, Nov 10, 2025 at 8:24 PM Tiezhu Yang <yangtiezhu@loongson.cn> wrote:
>
> 在 2025/11/10 下午2:48, Huacai Chen 写道:
> > V1 was applied last week and now in linux-next, don't do meaningless work.
> >
> > Huacai
> >
> > On Mon, Nov 10, 2025 at 10:59 AM Tiezhu Yang <yangtiezhu@loongson.cn> wrote:
> >>
> >> This version is based on 6.18-rc5, use the proper patch title
> >> to make it clear.
> >>
> >> Tiezhu Yang (2):
> >>    LoongArch: Use CPUCFG6_PMNUM_SHIFT to get PMU number
> >>    LoongArch: Detect PMU bits via CPUCFG instruction
> >>
> >>   arch/loongarch/include/asm/loongarch.h | 1 +
> >>   arch/loongarch/kernel/perf_event.c     | 7 ++++---
> >>   2 files changed, 5 insertions(+), 3 deletions(-)
>
> I do not like to argue with you, but I do not think what you said is
> right, there are double standards here.
>
> The code are rebased frequently by you in linux-loongson.git, the latest
> is after 6.18-rc5 that is in this week, my patch is also rebased.
>
> You accepted the suggestion of your patch v1 title [1] and send v2 [2]
> although v1 has been applied by Andrew, because you think it is a good
> suggestion.
>
> I just do the similar and right thing,  but your reply is not polite
> and friendly, and also do not do the thing what you should to do as a
> maintainer.
If my words make you uncomfortable, I apologize for that.

But something is different.

1, I asked Andrew whether I should re-submit V2, Andrew said yes, then
I re-submit. You asked me, too, but you re-submit in a hurry before I
reply.

2, Yes, linux-loongson.git is rebased, but the commits keep the same,
this is because: A, changeset for PR should be based on a tag commit
rather than a random commit; B, the commits in linux-next should keep
stable for at least two days before send PR.

Huacai

>
> [1]
> https://lore.kernel.org/linux-mm/20251108084724.3e389b6597294900347b0476@linux-foundation.org/
>
> [2]
> https://lore.kernel.org/linux-mm/20251109021817.346181-1-chenhuacai@loongson.cn/
>
> [3]
> https://git.kernel.org/pub/scm/linux/kernel/git/chenhuacai/linux-loongson.git/commit/?h=loongarch-fixes&id=4c8a7c982772
>
> Thanks,
> Tiezhu
>