include/linux/reset.h | 1 + 1 file changed, 1 insertion(+)
RESET_CONTROL_FLAGS_BIT_* macros use BIT(), but reset.h does not
include bits.h. This causes compilation errors when including
reset.h standalone.
Include bits.h to make reset.h self-contained.
Suggested-by: Troy Mitchell <troy.mitchell@linux.dev>
Reviewed-by: Troy Mitchell <troy.mitchell@linux.dev>
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Encrow Thorne <jyc0019@gmail.com>
---
Changes in v3:
- Fix commit message.
- Link to v2: https://lore.kernel.org/r/20251105-rfc-reset-include-bits-v2-1-f27c57b75a90@gmail.com
Changes in v2:
- Add header in alphabetical order.
- Link to v1: https://lore.kernel.org/r/20251105-rfc-reset-include-bits-v1-1-d7e1bbc7e1ab@gmail.com
---
include/linux/reset.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/reset.h b/include/linux/reset.h
index 840d75d172f6..44f9e3415f92 100644
--- a/include/linux/reset.h
+++ b/include/linux/reset.h
@@ -2,6 +2,7 @@
#ifndef _LINUX_RESET_H_
#define _LINUX_RESET_H_
+#include <linux/bits.h>
#include <linux/err.h>
#include <linux/errno.h>
#include <linux/types.h>
---
base-commit: 8fec172c82c2b5f6f8e47ab837c1dc91ee3d1b87
change-id: 20251105-rfc-reset-include-bits-4ec72344d1a3
Best regards,
--
Encrow Thorne <jyc0019@gmail.com>
On Mo, 2025-11-10 at 14:10 +0800, Encrow Thorne wrote:
> RESET_CONTROL_FLAGS_BIT_* macros use BIT(), but reset.h does not
> include bits.h. This causes compilation errors when including
> reset.h standalone.
>
> Include bits.h to make reset.h self-contained.
>
> Suggested-by: Troy Mitchell <troy.mitchell@linux.dev>
> Reviewed-by: Troy Mitchell <troy.mitchell@linux.dev>
> Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
> Signed-off-by: Encrow Thorne <jyc0019@gmail.com>
Applied to reset/next, thanks!
[1/1] reset: fix BIT macro reference
https://git.pengutronix.de/cgit/pza/linux/commit/?id=dae9b0708255
regards
Philipp
© 2016 - 2025 Red Hat, Inc.