From: Elliot Berman <elliot.berman@oss.qualcomm.com>
Add support for SYSTEM_RESET2 vendor-specific resets in
qcs6490-rb3gen2 as reboot-modes. Describe the resets:
"bootloader" will cause device to reboot and stop in the
bootloader's fastboot mode. "edl" will cause device to reboot
into "emergency download mode", which permits loading images via
the Firehose protocol.
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: Elliot Berman <elliot.berman@oss.qualcomm.com>
Signed-off-by: Shivendra Pratap <shivendra.pratap@oss.qualcomm.com>
---
arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
index 721a26d49ccaeb1429e2cc1c3a5c8d9517da3be6..cebdedd5d614b9efb6dfbee91dd67f3c3e322a38 100644
--- a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
+++ b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
@@ -935,6 +935,13 @@ &pon_resin {
status = "okay";
};
+&psci {
+ reboot-mode {
+ mode-bootloader = <0x10001 0x2>;
+ mode-edl = <0 0x1>;
+ };
+};
+
&qup_uart7_cts {
/*
* Configure a bias-bus-hold on CTS to lower power
--
2.34.1On Sun, Nov 09, 2025 at 08:07:22PM +0530, Shivendra Pratap wrote:
> From: Elliot Berman <elliot.berman@oss.qualcomm.com>
>
> Add support for SYSTEM_RESET2 vendor-specific resets in
Please rewrite this to start with the purpose of the patch, introduce
the fact that we can use SYSTEM_RESET2 to affect the reboot mode.
Make sure you include the information that this isn't broadly available
on all sc7280 devices.
Please line break at 72 characters, not less.
> qcs6490-rb3gen2 as reboot-modes. Describe the resets:
This looks like the header for a list, that documents "bootloader" and
"edl", but it's just one lump of text. Please improve the formatting. If
it is a list, then make it look like a list.
Regards,
Bjorn
> "bootloader" will cause device to reboot and stop in the
> bootloader's fastboot mode. "edl" will cause device to reboot
> into "emergency download mode", which permits loading images via
> the Firehose protocol.
>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> Signed-off-by: Elliot Berman <elliot.berman@oss.qualcomm.com>
> Signed-off-by: Shivendra Pratap <shivendra.pratap@oss.qualcomm.com>
> ---
> arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
> index 721a26d49ccaeb1429e2cc1c3a5c8d9517da3be6..cebdedd5d614b9efb6dfbee91dd67f3c3e322a38 100644
> --- a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
> +++ b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
> @@ -935,6 +935,13 @@ &pon_resin {
> status = "okay";
> };
>
> +&psci {
> + reboot-mode {
> + mode-bootloader = <0x10001 0x2>;
> + mode-edl = <0 0x1>;
> + };
> +};
> +
> &qup_uart7_cts {
> /*
> * Configure a bias-bus-hold on CTS to lower power
>
> --
> 2.34.1
>
On 11/11/2025 10:29 PM, Bjorn Andersson wrote: > On Sun, Nov 09, 2025 at 08:07:22PM +0530, Shivendra Pratap wrote: >> From: Elliot Berman <elliot.berman@oss.qualcomm.com> >> >> Add support for SYSTEM_RESET2 vendor-specific resets in > > Please rewrite this to start with the purpose of the patch, introduce > the fact that we can use SYSTEM_RESET2 to affect the reboot mode. > > Make sure you include the information that this isn't broadly available > on all sc7280 devices. ok. > > Please line break at 72 characters, not less. Ack. will keep note. thanks. > >> qcs6490-rb3gen2 as reboot-modes. Describe the resets: > > This looks like the header for a list, that documents "bootloader" and > "edl", but it's just one lump of text. Please improve the formatting. If > it is a list, then make it look like a list. Ack. will update this commit message. thanks, Shivendra
On Sun, Nov 09, 2025 at 08:07:22PM +0530, Shivendra Pratap wrote:
> From: Elliot Berman <elliot.berman@oss.qualcomm.com>
>
> Add support for SYSTEM_RESET2 vendor-specific resets in
> qcs6490-rb3gen2 as reboot-modes. Describe the resets:
> "bootloader" will cause device to reboot and stop in the
> bootloader's fastboot mode. "edl" will cause device to reboot
> into "emergency download mode", which permits loading images via
> the Firehose protocol.
>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> Signed-off-by: Elliot Berman <elliot.berman@oss.qualcomm.com>
> Signed-off-by: Shivendra Pratap <shivendra.pratap@oss.qualcomm.com>
> ---
> arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
> index 721a26d49ccaeb1429e2cc1c3a5c8d9517da3be6..cebdedd5d614b9efb6dfbee91dd67f3c3e322a38 100644
> --- a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
> +++ b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
> @@ -935,6 +935,13 @@ &pon_resin {
> status = "okay";
> };
>
> +&psci {
> + reboot-mode {
> + mode-bootloader = <0x10001 0x2>;
> + mode-edl = <0 0x1>;
> + };
> +};
> +
Make sense for this as it leverages sc7280 and adding it there would not
have made sense.
Acked-by: Mukesh Ojha <mukesh.ojha@oss.qualcomm.com>
> &qup_uart7_cts {
> /*
> * Configure a bias-bus-hold on CTS to lower power
>
> --
> 2.34.1
>
--
-Mukesh Ojha
On Mon, Nov 10, 2025 at 05:58:24PM +0530, Mukesh Ojha wrote:
> On Sun, Nov 09, 2025 at 08:07:22PM +0530, Shivendra Pratap wrote:
> > From: Elliot Berman <elliot.berman@oss.qualcomm.com>
> >
> > Add support for SYSTEM_RESET2 vendor-specific resets in
> > qcs6490-rb3gen2 as reboot-modes. Describe the resets:
> > "bootloader" will cause device to reboot and stop in the
> > bootloader's fastboot mode. "edl" will cause device to reboot
> > into "emergency download mode", which permits loading images via
> > the Firehose protocol.
> >
> > Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> > Signed-off-by: Elliot Berman <elliot.berman@oss.qualcomm.com>
> > Signed-off-by: Shivendra Pratap <shivendra.pratap@oss.qualcomm.com>
> > ---
> > arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 7 +++++++
> > 1 file changed, 7 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
> > index 721a26d49ccaeb1429e2cc1c3a5c8d9517da3be6..cebdedd5d614b9efb6dfbee91dd67f3c3e322a38 100644
> > --- a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
> > +++ b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
> > @@ -935,6 +935,13 @@ &pon_resin {
> > status = "okay";
> > };
> >
> > +&psci {
> > + reboot-mode {
> > + mode-bootloader = <0x10001 0x2>;
> > + mode-edl = <0 0x1>;
> > + };
> > +};
> > +
>
> Make sense for this as it leverages sc7280 and adding it there would not
> have made sense.
>
Why wouldn't it make sense?
> Acked-by: Mukesh Ojha <mukesh.ojha@oss.qualcomm.com>
>
Please read submitting-patches.rst about Acked-by, and use Reviewed-by
going forward.
Regards,
Bjorn
> > &qup_uart7_cts {
> > /*
> > * Configure a bias-bus-hold on CTS to lower power
> >
> > --
> > 2.34.1
> >
>
> --
> -Mukesh Ojha
>
On Mon, Nov 10, 2025 at 09:30:26AM -0600, Bjorn Andersson wrote:
> On Mon, Nov 10, 2025 at 05:58:24PM +0530, Mukesh Ojha wrote:
> > On Sun, Nov 09, 2025 at 08:07:22PM +0530, Shivendra Pratap wrote:
> > > From: Elliot Berman <elliot.berman@oss.qualcomm.com>
> > >
> > > Add support for SYSTEM_RESET2 vendor-specific resets in
> > > qcs6490-rb3gen2 as reboot-modes. Describe the resets:
> > > "bootloader" will cause device to reboot and stop in the
> > > bootloader's fastboot mode. "edl" will cause device to reboot
> > > into "emergency download mode", which permits loading images via
> > > the Firehose protocol.
> > >
> > > Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> > > Signed-off-by: Elliot Berman <elliot.berman@oss.qualcomm.com>
> > > Signed-off-by: Shivendra Pratap <shivendra.pratap@oss.qualcomm.com>
> > > ---
> > > arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 7 +++++++
> > > 1 file changed, 7 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
> > > index 721a26d49ccaeb1429e2cc1c3a5c8d9517da3be6..cebdedd5d614b9efb6dfbee91dd67f3c3e322a38 100644
> > > --- a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
> > > +++ b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
> > > @@ -935,6 +935,13 @@ &pon_resin {
> > > status = "okay";
> > > };
> > >
> > > +&psci {
> > > + reboot-mode {
> > > + mode-bootloader = <0x10001 0x2>;
> > > + mode-edl = <0 0x1>;
> > > + };
> > > +};
> > > +
> >
> > Make sense for this as it leverages sc7280 and adding it there would not
> > have made sense.
> >
>
> Why wouldn't it make sense?
It is better to add for platforms we know their firmware support this
from day1 and not add for something like chrome or any other variant of
sc7280 where this support would never come or not tested.
>
> > Acked-by: Mukesh Ojha <mukesh.ojha@oss.qualcomm.com>
> >
>
> Please read submitting-patches.rst about Acked-by, and use Reviewed-by
> going forward.
I was acking the idea of this particular change in platform file compared to
other patches, if above reason looks fine, can be converted to R-by.
>
> Regards,
> Bjorn
>
> > > &qup_uart7_cts {
> > > /*
> > > * Configure a bias-bus-hold on CTS to lower power
> > >
> > > --
> > > 2.34.1
> > >
> >
> > --
> > -Mukesh Ojha
> >
--
-Mukesh Ojha
On Mon, Nov 10, 2025 at 09:49:50PM +0530, Mukesh Ojha wrote:
> On Mon, Nov 10, 2025 at 09:30:26AM -0600, Bjorn Andersson wrote:
> > On Mon, Nov 10, 2025 at 05:58:24PM +0530, Mukesh Ojha wrote:
> > > On Sun, Nov 09, 2025 at 08:07:22PM +0530, Shivendra Pratap wrote:
> > > > From: Elliot Berman <elliot.berman@oss.qualcomm.com>
> > > >
> > > > Add support for SYSTEM_RESET2 vendor-specific resets in
> > > > qcs6490-rb3gen2 as reboot-modes. Describe the resets:
> > > > "bootloader" will cause device to reboot and stop in the
> > > > bootloader's fastboot mode. "edl" will cause device to reboot
> > > > into "emergency download mode", which permits loading images via
> > > > the Firehose protocol.
> > > >
> > > > Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> > > > Signed-off-by: Elliot Berman <elliot.berman@oss.qualcomm.com>
> > > > Signed-off-by: Shivendra Pratap <shivendra.pratap@oss.qualcomm.com>
> > > > ---
> > > > arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 7 +++++++
> > > > 1 file changed, 7 insertions(+)
> > > >
> > > > diff --git a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
> > > > index 721a26d49ccaeb1429e2cc1c3a5c8d9517da3be6..cebdedd5d614b9efb6dfbee91dd67f3c3e322a38 100644
> > > > --- a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
> > > > +++ b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
> > > > @@ -935,6 +935,13 @@ &pon_resin {
> > > > status = "okay";
> > > > };
> > > >
> > > > +&psci {
> > > > + reboot-mode {
> > > > + mode-bootloader = <0x10001 0x2>;
> > > > + mode-edl = <0 0x1>;
> > > > + };
> > > > +};
> > > > +
> > >
> > > Make sense for this as it leverages sc7280 and adding it there would not
> > > have made sense.
> > >
> >
> > Why wouldn't it make sense?
>
> It is better to add for platforms we know their firmware support this
> from day1 and not add for something like chrome or any other variant of
> sc7280 where this support would never come or not tested.
So SYSTEM_RESET2 only exist in newer firmware versions and hence this
isn't (and won't be) broadly available in SC7280 devices.
That would be excellent information to put in the commit message, so
others writing Kodiak dts doesn't feel the urge to copy this and debug
why it doesn't work.
> >
> > > Acked-by: Mukesh Ojha <mukesh.ojha@oss.qualcomm.com>
> > >
> >
> > Please read submitting-patches.rst about Acked-by, and use Reviewed-by
> > going forward.
>
> I was acking the idea of this particular change in platform file compared to
> other patches, if above reason looks fine, can be converted to R-by.
>
That's appreciated, but per the documentation, the meaning of acked-by
is different.
Regards,
Bjorn
> >
> > Regards,
> > Bjorn
> >
> > > > &qup_uart7_cts {
> > > > /*
> > > > * Configure a bias-bus-hold on CTS to lower power
> > > >
> > > > --
> > > > 2.34.1
> > > >
> > >
> > > --
> > > -Mukesh Ojha
> > >
>
> --
> -Mukesh Ojha
On Tue, Nov 11, 2025 at 10:52:34AM -0600, Bjorn Andersson wrote:
> On Mon, Nov 10, 2025 at 09:49:50PM +0530, Mukesh Ojha wrote:
> > On Mon, Nov 10, 2025 at 09:30:26AM -0600, Bjorn Andersson wrote:
> > > On Mon, Nov 10, 2025 at 05:58:24PM +0530, Mukesh Ojha wrote:
> > > > On Sun, Nov 09, 2025 at 08:07:22PM +0530, Shivendra Pratap wrote:
> > > > > From: Elliot Berman <elliot.berman@oss.qualcomm.com>
> > > > >
> > > > > Add support for SYSTEM_RESET2 vendor-specific resets in
> > > > > qcs6490-rb3gen2 as reboot-modes. Describe the resets:
> > > > > "bootloader" will cause device to reboot and stop in the
> > > > > bootloader's fastboot mode. "edl" will cause device to reboot
> > > > > into "emergency download mode", which permits loading images via
> > > > > the Firehose protocol.
> > > > >
> > > > > Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> > > > > Signed-off-by: Elliot Berman <elliot.berman@oss.qualcomm.com>
> > > > > Signed-off-by: Shivendra Pratap <shivendra.pratap@oss.qualcomm.com>
> > > > > ---
> > > > > arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 7 +++++++
> > > > > 1 file changed, 7 insertions(+)
> > > > >
> > > > > diff --git a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
> > > > > index 721a26d49ccaeb1429e2cc1c3a5c8d9517da3be6..cebdedd5d614b9efb6dfbee91dd67f3c3e322a38 100644
> > > > > --- a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
> > > > > +++ b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
> > > > > @@ -935,6 +935,13 @@ &pon_resin {
> > > > > status = "okay";
> > > > > };
> > > > >
> > > > > +&psci {
> > > > > + reboot-mode {
> > > > > + mode-bootloader = <0x10001 0x2>;
> > > > > + mode-edl = <0 0x1>;
> > > > > + };
> > > > > +};
> > > > > +
> > > >
> > > > Make sense for this as it leverages sc7280 and adding it there would not
> > > > have made sense.
> > > >
> > >
> > > Why wouldn't it make sense?
> >
> > It is better to add for platforms we know their firmware support this
> > from day1 and not add for something like chrome or any other variant of
> > sc7280 where this support would never come or not tested.
>
> So SYSTEM_RESET2 only exist in newer firmware versions and hence this
> isn't (and won't be) broadly available in SC7280 devices.
>
> That would be excellent information to put in the commit message, so
> others writing Kodiak dts doesn't feel the urge to copy this and debug
> why it doesn't work.
Sure, @shivendra please add this information in commit text.
>
> > >
> > > > Acked-by: Mukesh Ojha <mukesh.ojha@oss.qualcomm.com>
> > > >
> > >
> > > Please read submitting-patches.rst about Acked-by, and use Reviewed-by
> > > going forward.
> >
> > I was acking the idea of this particular change in platform file compared to
> > other patches, if above reason looks fine, can be converted to R-by.
> >
>
> That's appreciated, but per the documentation, the meaning of acked-by
> is different.
Sure..
>
> Regards,
> Bjorn
>
> > >
> > > Regards,
> > > Bjorn
> > >
> > > > > &qup_uart7_cts {
> > > > > /*
> > > > > * Configure a bias-bus-hold on CTS to lower power
> > > > >
> > > > > --
> > > > > 2.34.1
> > > > >
> > > >
> > > > --
> > > > -Mukesh Ojha
> > > >
> >
> > --
> > -Mukesh Ojha
--
-Mukesh Ojha
On 11/12/2025 4:45 PM, Mukesh Ojha wrote:
> On Tue, Nov 11, 2025 at 10:52:34AM -0600, Bjorn Andersson wrote:
>> On Mon, Nov 10, 2025 at 09:49:50PM +0530, Mukesh Ojha wrote:
>>> On Mon, Nov 10, 2025 at 09:30:26AM -0600, Bjorn Andersson wrote:
>>>> On Mon, Nov 10, 2025 at 05:58:24PM +0530, Mukesh Ojha wrote:
>>>>> On Sun, Nov 09, 2025 at 08:07:22PM +0530, Shivendra Pratap wrote:
>>>>>> From: Elliot Berman <elliot.berman@oss.qualcomm.com>
>>>>>>
>>>>>> Add support for SYSTEM_RESET2 vendor-specific resets in
>>>>>> qcs6490-rb3gen2 as reboot-modes. Describe the resets:
>>>>>> "bootloader" will cause device to reboot and stop in the
>>>>>> bootloader's fastboot mode. "edl" will cause device to reboot
>>>>>> into "emergency download mode", which permits loading images via
>>>>>> the Firehose protocol.
>>>>>>
>>>>>> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>>>>>> Signed-off-by: Elliot Berman <elliot.berman@oss.qualcomm.com>
>>>>>> Signed-off-by: Shivendra Pratap <shivendra.pratap@oss.qualcomm.com>
>>>>>> ---
>>>>>> arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 7 +++++++
>>>>>> 1 file changed, 7 insertions(+)
>>>>>>
>>>>>> diff --git a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
>>>>>> index 721a26d49ccaeb1429e2cc1c3a5c8d9517da3be6..cebdedd5d614b9efb6dfbee91dd67f3c3e322a38 100644
>>>>>> --- a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
>>>>>> +++ b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
>>>>>> @@ -935,6 +935,13 @@ &pon_resin {
>>>>>> status = "okay";
>>>>>> };
>>>>>>
>>>>>> +&psci {
>>>>>> + reboot-mode {
>>>>>> + mode-bootloader = <0x10001 0x2>;
>>>>>> + mode-edl = <0 0x1>;
>>>>>> + };
>>>>>> +};
>>>>>> +
>>>>>
>>>>> Make sense for this as it leverages sc7280 and adding it there would not
>>>>> have made sense.
>>>>>
>>>>
>>>> Why wouldn't it make sense?
>>>
>>> It is better to add for platforms we know their firmware support this
>>> from day1 and not add for something like chrome or any other variant of
>>> sc7280 where this support would never come or not tested.
>>
>> So SYSTEM_RESET2 only exist in newer firmware versions and hence this
>> isn't (and won't be) broadly available in SC7280 devices.
>>
>> That would be excellent information to put in the commit message, so
>> others writing Kodiak dts doesn't feel the urge to copy this and debug
>> why it doesn't work.
>
> Sure, @shivendra please add this information in commit text.
Ack.
>
>>
>>>>
>>>>> Acked-by: Mukesh Ojha <mukesh.ojha@oss.qualcomm.com>
>>>>>
>>>>
>>>> Please read submitting-patches.rst about Acked-by, and use Reviewed-by
>>>> going forward.
>>>
>>> I was acking the idea of this particular change in platform file compared to
>>> other patches, if above reason looks fine, can be converted to R-by.
>>>
>>
>> That's appreciated, but per the documentation, the meaning of acked-by
>> is different.
>
> Sure..
>
>>
>> Regards,
>> Bjorn
>>
>>>>
>>>> Regards,
>>>> Bjorn
>>>>
>>>>>> &qup_uart7_cts {
>>>>>> /*
>>>>>> * Configure a bias-bus-hold on CTS to lower power
>>>>>>
>>>>>> --
>>>>>> 2.34.1
>>>>>>
>>>>>
>>>>> --
>>>>> -Mukesh Ojha
>>>>>
>>>
>>> --
>>> -Mukesh Ojha
>
© 2016 - 2025 Red Hat, Inc.