[PATCH] crypto: zstd - Remove unnecessary size_t cast

Thorsten Blum posted 1 patch 1 month, 1 week ago
crypto/zstd.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
[PATCH] crypto: zstd - Remove unnecessary size_t cast
Posted by Thorsten Blum 1 month, 1 week ago
Use max() instead of max_t() since zstd_cstream_workspace_bound() and
zstd_dstream_workspace_bound() already return size_t and casting the
values is unnecessary.

Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
 crypto/zstd.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/crypto/zstd.c b/crypto/zstd.c
index ac318d333b68..ff21cab382ba 100644
--- a/crypto/zstd.c
+++ b/crypto/zstd.c
@@ -38,9 +38,8 @@ static void *zstd_alloc_stream(void)
 
 	params = zstd_get_params(ZSTD_DEF_LEVEL, ZSTD_MAX_SIZE);
 
-	wksp_size = max_t(size_t,
-			  zstd_cstream_workspace_bound(&params.cParams),
-			  zstd_dstream_workspace_bound(ZSTD_MAX_SIZE));
+	wksp_size = max(zstd_cstream_workspace_bound(&params.cParams),
+			zstd_dstream_workspace_bound(ZSTD_MAX_SIZE));
 	if (!wksp_size)
 		return ERR_PTR(-EINVAL);
 
-- 
2.51.1
Re: [PATCH] crypto: zstd - Remove unnecessary size_t cast
Posted by Herbert Xu 1 month ago
On Sat, Nov 08, 2025 at 03:57:07PM +0100, Thorsten Blum wrote:
> Use max() instead of max_t() since zstd_cstream_workspace_bound() and
> zstd_dstream_workspace_bound() already return size_t and casting the
> values is unnecessary.
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
>  crypto/zstd.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Re: [PATCH] crypto: zstd - Remove unnecessary size_t cast
Posted by David Sterba 1 month ago
On Sat, Nov 08, 2025 at 03:57:07PM +0100, Thorsten Blum wrote:
> Use max() instead of max_t() since zstd_cstream_workspace_bound() and
> zstd_dstream_workspace_bound() already return size_t and casting the
> values is unnecessary.
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>

Reviewed-by: David Sterba <dsterba@suse.com>