[v1] can: gs_usb: fix USB bulk in and out callbacks

[PATCH can 0/3] can: gs_usb: fix USB bulk in and out callbacks

Marc Kleine-Budde posted 3 patches 1 month, 1 week ago

Diff against v1
Download series mbox

There is a newer version of this series

drivers/net/can/usb/gs_usb.c | 108 +++++++++++++++++++++++++++++++++++++------
1 file changed, 94 insertions(+), 14 deletions(-)

Expand all Fold all

[PATCH can 0/3] can: gs_usb: fix USB bulk in and out callbacks

Posted by Marc Kleine-Budde 1 month, 1 week ago

The bulk-out callback gs_usb_xmit_callback() does not take care of the
cleanup of failed transfers of URBs. The 1st patch adds the missing
cleanup.

The bulk-in callback gs_usb_receive_bulk_callback() accesses the buffer of
the URB without checking how much data has actually been received. The last
2 patches fix this problem.

Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
---
Marc Kleine-Budde (3):
      can: gs_usb: gs_usb_xmit_callback(): fix handling of failed transmitted URBs
      can: gs_usb: gs_usb_receive_bulk_callback(): check actual_length before accessing header
      can: gs_usb: gs_usb_receive_bulk_callback(): check actual_length before accessing data

 drivers/net/can/usb/gs_usb.c | 108 +++++++++++++++++++++++++++++++++++++------
 1 file changed, 94 insertions(+), 14 deletions(-)
---
base-commit: 74d4432421a3e2669fbccc08c0f4fc2980bf0e39
change-id: 20251107-gs_usb-fix-usb-callbacks-5fa2955299c3

Best regards,
--  
Marc Kleine-Budde <mkl@pengutronix.de>