accel/amdxdna: Clear mailbox interrupt register during channel creation

[PATCH] accel/amdxdna: Clear mailbox interrupt register during channel creation

Posted by Lizhi Hou 1 month, 1 week ago

The mailbox interrupt register is not always cleared when a mailbox channel
is created. This can leave stale interrupt states from previous operations.

Fix this by explicitly clearing the interrupt register in the mailbox
channel creation function.

Fixes: b87f920b9344 ("accel/amdxdna: Support hardware mailbox")
Signed-off-by: Lizhi Hou <lizhi.hou@amd.com>
---
 drivers/accel/amdxdna/amdxdna_mailbox.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/accel/amdxdna/amdxdna_mailbox.c b/drivers/accel/amdxdna/amdxdna_mailbox.c
index 24258dcc18eb..858df97cd3fb 100644
--- a/drivers/accel/amdxdna/amdxdna_mailbox.c
+++ b/drivers/accel/amdxdna/amdxdna_mailbox.c
@@ -516,6 +516,7 @@ xdna_mailbox_create_channel(struct mailbox *mb,
 	}
 
 	mb_chann->bad_state = false;
+	mailbox_reg_write(mb_chann, mb_chann->iohub_int_addr, 0);
 
 	MB_DBG(mb_chann, "Mailbox channel created (irq: %d)", mb_chann->msix_irq);
 	return mb_chann;
-- 
2.34.1

Re: [PATCH] accel/amdxdna: Clear mailbox interrupt register during channel creation

Posted by Falkowski, Maciej 1 month ago

Reviewed-by: Maciej Falkowski <maciej.falkowski@linux.intel.com>

On 11/7/2025 7:11 PM, Lizhi Hou wrote:
> The mailbox interrupt register is not always cleared when a mailbox channel
> is created. This can leave stale interrupt states from previous operations.
>
> Fix this by explicitly clearing the interrupt register in the mailbox
> channel creation function.
>
> Fixes: b87f920b9344 ("accel/amdxdna: Support hardware mailbox")
> Signed-off-by: Lizhi Hou <lizhi.hou@amd.com>
> ---
>   drivers/accel/amdxdna/amdxdna_mailbox.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/accel/amdxdna/amdxdna_mailbox.c b/drivers/accel/amdxdna/amdxdna_mailbox.c
> index 24258dcc18eb..858df97cd3fb 100644
> --- a/drivers/accel/amdxdna/amdxdna_mailbox.c
> +++ b/drivers/accel/amdxdna/amdxdna_mailbox.c
> @@ -516,6 +516,7 @@ xdna_mailbox_create_channel(struct mailbox *mb,
>   	}
>   
>   	mb_chann->bad_state = false;
> +	mailbox_reg_write(mb_chann, mb_chann->iohub_int_addr, 0);
>   
>   	MB_DBG(mb_chann, "Mailbox channel created (irq: %d)", mb_chann->msix_irq);
>   	return mb_chann;

Re: [PATCH] accel/amdxdna: Clear mailbox interrupt register during channel creation

Posted by Lizhi Hou 1 month ago

Applied to drm-misc-next

On 11/13/25 07:22, Falkowski, Maciej wrote:
> Reviewed-by: Maciej Falkowski <maciej.falkowski@linux.intel.com>
>
> On 11/7/2025 7:11 PM, Lizhi Hou wrote:
>> The mailbox interrupt register is not always cleared when a mailbox 
>> channel
>> is created. This can leave stale interrupt states from previous 
>> operations.
>>
>> Fix this by explicitly clearing the interrupt register in the mailbox
>> channel creation function.
>>
>> Fixes: b87f920b9344 ("accel/amdxdna: Support hardware mailbox")
>> Signed-off-by: Lizhi Hou <lizhi.hou@amd.com>
>> ---
>>   drivers/accel/amdxdna/amdxdna_mailbox.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/accel/amdxdna/amdxdna_mailbox.c 
>> b/drivers/accel/amdxdna/amdxdna_mailbox.c
>> index 24258dcc18eb..858df97cd3fb 100644
>> --- a/drivers/accel/amdxdna/amdxdna_mailbox.c
>> +++ b/drivers/accel/amdxdna/amdxdna_mailbox.c
>> @@ -516,6 +516,7 @@ xdna_mailbox_create_channel(struct mailbox *mb,
>>       }
>>         mb_chann->bad_state = false;
>> +    mailbox_reg_write(mb_chann, mb_chann->iohub_int_addr, 0);
>>         MB_DBG(mb_chann, "Mailbox channel created (irq: %d)", 
>> mb_chann->msix_irq);
>>       return mb_chann;