LoongArch: Remove __GFP_HIGHMEM masking

[PATCH] LoongArch: Remove __GFP_HIGHMEM masking

Posted by Vishal Moola (Oracle) 1 month, 1 week ago

Remove unnecessary __GFP_HIGHMEM masking, which was introduced with
commit 382739797f79 ("loongarch: convert various functions to use
ptdescs"). GFP_KERNEL doesn't contain __GFP_HIGHMEM.

Signed-off-by: Vishal Moola (Oracle) <vishal.moola@gmail.com>
---
 arch/loongarch/include/asm/pgalloc.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/loongarch/include/asm/pgalloc.h b/arch/loongarch/include/asm/pgalloc.h
index 1c63a9d9a6d3..08dcc698ec18 100644
--- a/arch/loongarch/include/asm/pgalloc.h
+++ b/arch/loongarch/include/asm/pgalloc.h
@@ -88,7 +88,7 @@ static inline pmd_t *pmd_alloc_one(struct mm_struct *mm, unsigned long address)
 static inline pud_t *pud_alloc_one(struct mm_struct *mm, unsigned long address)
 {
 	pud_t *pud;
-	struct ptdesc *ptdesc = pagetable_alloc(GFP_KERNEL & ~__GFP_HIGHMEM, 0);
+	struct ptdesc *ptdesc = pagetable_alloc(GFP_KERNEL, 0);
 
 	if (!ptdesc)
 		return NULL;
-- 
2.51.1

Re: [PATCH] LoongArch: Remove __GFP_HIGHMEM masking

Posted by Huacai Chen 1 month, 1 week ago

Hi, Vishal,

On Sat, Nov 8, 2025 at 2:06 AM Vishal Moola (Oracle)
<vishal.moola@gmail.com> wrote:
>
> Remove unnecessary __GFP_HIGHMEM masking, which was introduced with
> commit 382739797f79 ("loongarch: convert various functions to use
> ptdescs"). GFP_KERNEL doesn't contain __GFP_HIGHMEM.
I have planned to submit a similar patch after [1] is merged, but
anyway, thank you for your contribution.

[1] https://lore.kernel.org/linux-mm/CAAhV-H5C_Af72a5QcJs25qUMsJqO26=8oNvvLrJ7z+xHZh8oKQ@mail.gmail.com/T/#t

Huacai

>
> Signed-off-by: Vishal Moola (Oracle) <vishal.moola@gmail.com>
> ---
>  arch/loongarch/include/asm/pgalloc.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/loongarch/include/asm/pgalloc.h b/arch/loongarch/include/asm/pgalloc.h
> index 1c63a9d9a6d3..08dcc698ec18 100644
> --- a/arch/loongarch/include/asm/pgalloc.h
> +++ b/arch/loongarch/include/asm/pgalloc.h
> @@ -88,7 +88,7 @@ static inline pmd_t *pmd_alloc_one(struct mm_struct *mm, unsigned long address)
>  static inline pud_t *pud_alloc_one(struct mm_struct *mm, unsigned long address)
>  {
>         pud_t *pud;
> -       struct ptdesc *ptdesc = pagetable_alloc(GFP_KERNEL & ~__GFP_HIGHMEM, 0);
> +       struct ptdesc *ptdesc = pagetable_alloc(GFP_KERNEL, 0);
>
>         if (!ptdesc)
>                 return NULL;
> --
> 2.51.1
>
>