[PATCH] usb: typec: tipd: mark as orientation aware

Peter Korsgaard posted 1 patch 1 month, 1 week ago
drivers/usb/typec/tipd/core.c | 1 +
1 file changed, 1 insertion(+)
[PATCH] usb: typec: tipd: mark as orientation aware
Posted by Peter Korsgaard 1 month, 1 week ago
The driver contains orientation detection logic and correctly calls
typec_set_orientation(), but forgets to set the orientation_aware
capability, so the orientation value is not visible in sysfs - Fix that.

Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
 drivers/usb/typec/tipd/core.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c
index 2b1049c9a6f3..d561032a2970 100644
--- a/drivers/usb/typec/tipd/core.c
+++ b/drivers/usb/typec/tipd/core.c
@@ -1695,6 +1695,7 @@ tps25750_register_port(struct tps6598x *tps, struct fwnode_handle *fwnode)
 	typec_cap.data = ret;
 	typec_cap.revision = USB_TYPEC_REV_1_3;
 	typec_cap.pd_revision = 0x300;
+	typec_cap.orientation_aware = true;
 	typec_cap.driver_data = tps;
 	typec_cap.ops = &tps6598x_ops;
 	typec_cap.fwnode = fwnode;
-- 
2.39.5
Re: [PATCH] usb: typec: tipd: mark as orientation aware
Posted by Heikki Krogerus 1 month, 1 week ago
Fri, Nov 07, 2025 at 04:13:10PM +0100, Peter Korsgaard kirjoitti:
> The driver contains orientation detection logic and correctly calls
> typec_set_orientation(), but forgets to set the orientation_aware
> capability, so the orientation value is not visible in sysfs - Fix that.
> 
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>

Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>

> ---
>  drivers/usb/typec/tipd/core.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c
> index 2b1049c9a6f3..d561032a2970 100644
> --- a/drivers/usb/typec/tipd/core.c
> +++ b/drivers/usb/typec/tipd/core.c
> @@ -1695,6 +1695,7 @@ tps25750_register_port(struct tps6598x *tps, struct fwnode_handle *fwnode)
>  	typec_cap.data = ret;
>  	typec_cap.revision = USB_TYPEC_REV_1_3;
>  	typec_cap.pd_revision = 0x300;
> +	typec_cap.orientation_aware = true;
>  	typec_cap.driver_data = tps;
>  	typec_cap.ops = &tps6598x_ops;
>  	typec_cap.fwnode = fwnode;
> -- 
> 2.39.5

-- 
heikki