[for-linus][PATCH 3/3] tracing/tools: Fix incorrcet short option in usage text for --threads

Steven Rostedt posted 3 patches 3 months ago
[for-linus][PATCH 3/3] tracing/tools: Fix incorrcet short option in usage text for --threads
Posted by Steven Rostedt 3 months ago
From: Zhang Chujun <zhangchujun@cmss.chinamobile.com>

The help message incorrectly listed '-t' as the short option for
--threads, but the actual getopt_long configuration uses '-e'.
This mismatch can confuse users and lead to incorrect command-line
usage. This patch updates the usage string to correctly show:
	"-e, --threads NRTHR"
to match the implementation.

Note: checkpatch.pl reports a false-positive spelling warning on
'Run', which is intentional.

Link: https://patch.msgid.link/20251106031040.1869-1-zhangchujun@cmss.chinamobile.com
Signed-off-by: Zhang Chujun <zhangchujun@cmss.chinamobile.com>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
---
 tools/tracing/latency/latency-collector.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/tracing/latency/latency-collector.c b/tools/tracing/latency/latency-collector.c
index cf263fe9deaf..ef97916e3873 100644
--- a/tools/tracing/latency/latency-collector.c
+++ b/tools/tracing/latency/latency-collector.c
@@ -1725,7 +1725,7 @@ static void show_usage(void)
 "-n, --notrace\t\tIf latency is detected, do not print out the content of\n"
 "\t\t\tthe trace file to standard output\n\n"
 
-"-t, --threads NRTHR\tRun NRTHR threads for printing. Default is %d.\n\n"
+"-e, --threads NRTHR\tRun NRTHR threads for printing. Default is %d.\n\n"
 
 "-r, --random\t\tArbitrarily sleep a certain amount of time, default\n"
 "\t\t\t%ld ms, before reading the trace file. The\n"
-- 
2.51.0
Re: [for-linus][PATCH 3/3] tracing/tools: Fix incorrcet short option in usage text for --threads
Posted by Mathieu Desnoyers 3 months ago
On 2025-11-07 08:07, Steven Rostedt wrote:

Nit: Subject: incorrcet -> incorrect

Thanks,

Mathieu

-- 
Mathieu Desnoyers
EfficiOS Inc.
https://www.efficios.com
Re: [for-linus][PATCH 3/3] tracing/tools: Fix incorrcet short option in usage text for --threads
Posted by Steven Rostedt 3 months ago

On November 7, 2025 8:37:13 AM EST, Mathieu Desnoyers <mathieu.desnoyers@efficios.com> wrote:
>On 2025-11-07 08:07, Steven Rostedt wrote:
>
>Nit: Subject: incorrcet -> incorrect

I saw that just as I did the pull request but figured it wasn't big enough to stop the request.

-- Steve 

>
>Thanks,
>
>Mathieu
>