iommu/iommupt: Fix build error in genericpt unit-tests

[PATCH] iommu/iommupt: Fix build error in genericpt unit-tests

Posted by Joerg Roedel 1 month, 1 week ago

From: Joerg Roedel <joerg.roedel@amd.com>

Fix the include of iommu-pages.h in the KUnit tests for the IOMMU
generic page-table code to make the tests compile again.

Reported-by: Thorsten Leemhuis <linux@leemhuis.info>
Closes: https://lore.kernel.org/all/9844d4cb-f517-478b-9911-b6dc1a963b8e@leemhuis.info/
Fixes: 1dd4187f53c3 ("iommupt: Add a kunit test for Generic Page Table")
Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
---
 drivers/iommu/generic_pt/kunit_iommu.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iommu/generic_pt/kunit_iommu.h b/drivers/iommu/generic_pt/kunit_iommu.h
index 5d4f269627d5..22c9e4c4dd97 100644
--- a/drivers/iommu/generic_pt/kunit_iommu.h
+++ b/drivers/iommu/generic_pt/kunit_iommu.h
@@ -8,7 +8,7 @@
 #define GENERIC_PT_KUNIT 1
 #include <kunit/device.h>
 #include <kunit/test.h>
-#include <../../iommu-pages.h>
+#include "../iommu-pages.h"
 #include "pt_iter.h"
 
 #define pt_iommu_table_cfg CONCATENATE(pt_iommu_table, _cfg)
-- 
2.51.0

Re: [PATCH] iommu/iommupt: Fix build error in genericpt unit-tests

Posted by Vasant Hegde 1 month, 1 week ago

On 11/7/2025 4:17 PM, Joerg Roedel wrote:
> From: Joerg Roedel <joerg.roedel@amd.com>
> 
> Fix the include of iommu-pages.h in the KUnit tests for the IOMMU
> generic page-table code to make the tests compile again.
> 
> Reported-by: Thorsten Leemhuis <linux@leemhuis.info>
> Closes: https://lore.kernel.org/all/9844d4cb-f517-478b-9911-b6dc1a963b8e@leemhuis.info/
> Fixes: 1dd4187f53c3 ("iommupt: Add a kunit test for Generic Page Table")
> Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>

Tested-by: Vasant Hegde <vasant.hegde@amd.com>

-Vasant

Re: [PATCH] iommu/iommupt: Fix build error in genericpt unit-tests

Posted by Jason Gunthorpe 1 month, 1 week ago

On Fri, Nov 07, 2025 at 11:47:01AM +0100, Joerg Roedel wrote:
> From: Joerg Roedel <joerg.roedel@amd.com>
> 
> Fix the include of iommu-pages.h in the KUnit tests for the IOMMU
> generic page-table code to make the tests compile again.
> 
> Reported-by: Thorsten Leemhuis <linux@leemhuis.info>
> Closes: https://lore.kernel.org/all/9844d4cb-f517-478b-9911-b6dc1a963b8e@leemhuis.info/
> Fixes: 1dd4187f53c3 ("iommupt: Add a kunit test for Generic Page Table")
> Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
> ---
>  drivers/iommu/generic_pt/kunit_iommu.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason

Re: [PATCH] iommu/iommupt: Fix build error in genericpt unit-tests

Posted by Thorsten Leemhuis 1 month, 1 week ago

Adding Amandeep Kaur

On 11/7/25 11:47, Joerg Roedel wrote:
> From: Joerg Roedel <joerg.roedel@amd.com>
> 
> Fix the include of iommu-pages.h in the KUnit tests for the IOMMU
> generic page-table code to make the tests compile again.
> 
> Reported-by: Thorsten Leemhuis <linux@leemhuis.info>
> Closes: https://lore.kernel.org/all/9844d4cb-f517-478b-9911-b6dc1a963b8e@leemhuis.info/

Thx Joerg! I did test a equivalent change, so I guess this will be fine:

Tested-by: Thorsten Leemhuis <linux@leemhuis.info>

Maybe also add these:

Reported-by: "Longia, Amandeep Kaur" <amandeepkaur.longia@amd.com>
Closes:
https://lore.kernel.org/all/e641c955-25ad-4eae-b3fe-4392966cf768@amd.com/

Ciao, Thorsten

> Fixes: 1dd4187f53c3 ("iommupt: Add a kunit test for Generic Page Table")
> Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
> ---
>  drivers/iommu/generic_pt/kunit_iommu.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iommu/generic_pt/kunit_iommu.h b/drivers/iommu/generic_pt/kunit_iommu.h
> index 5d4f269627d5..22c9e4c4dd97 100644
> --- a/drivers/iommu/generic_pt/kunit_iommu.h
> +++ b/drivers/iommu/generic_pt/kunit_iommu.h
> @@ -8,7 +8,7 @@
>  #define GENERIC_PT_KUNIT 1
>  #include <kunit/device.h>
>  #include <kunit/test.h>
> -#include <../../iommu-pages.h>
> +#include "../iommu-pages.h"
>  #include "pt_iter.h"
>  
>  #define pt_iommu_table_cfg CONCATENATE(pt_iommu_table, _cfg)