rust: debugfs: Implement BinaryReader for Mutex<T> only when T is Unpin

[PATCH] rust: debugfs: Implement BinaryReader for Mutex<T> only when T is Unpin

Posted by Danilo Krummrich 1 month, 1 week ago

Commit da123f0ee40f ("rust: lock: guard: Add T: Unpin bound to
DerefMut") from tip/master adds an Unpin bound to T for Mutex<T>, hence
also restrict the implementation of BinaryReader for Mutex<T>
accordingly.

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Closes: https://lore.kernel.org/all/20251107134144.117905bd@canb.auug.org.au/
Signed-off-by: Danilo Krummrich <dakr@kernel.org>
---
 rust/kernel/debugfs/traits.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/rust/kernel/debugfs/traits.rs b/rust/kernel/debugfs/traits.rs
index 2c32ddf9826f..82441ac8adaa 100644
--- a/rust/kernel/debugfs/traits.rs
+++ b/rust/kernel/debugfs/traits.rs
@@ -257,7 +257,7 @@ fn read_from_slice(
 }
 
 // Delegate for `Mutex<T>`: Support a `T` with an outer `Mutex`.
-impl<T: BinaryReaderMut> BinaryReader for Mutex<T> {
+impl<T: BinaryReaderMut + Unpin> BinaryReader for Mutex<T> {
     fn read_from_slice(
         &self,
         reader: &mut UserSliceReader,
-- 
2.51.0

Re: [PATCH] rust: debugfs: Implement BinaryReader for Mutex<T> only when T is Unpin

Posted by Danilo Krummrich 1 month, 1 week ago

On Fri Nov 7, 2025 at 10:16 AM CET, Danilo Krummrich wrote:
> Commit da123f0ee40f ("rust: lock: guard: Add T: Unpin bound to
> DerefMut") from tip/master adds an Unpin bound to T for Mutex<T>, hence
> also restrict the implementation of BinaryReader for Mutex<T>
> accordingly.
>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Closes: https://lore.kernel.org/all/20251107134144.117905bd@canb.auug.org.au/
> Signed-off-by: Danilo Krummrich <dakr@kernel.org>

Applied to driver-core-next, thanks!

Re: [PATCH] rust: debugfs: Implement BinaryReader for Mutex<T> only when T is Unpin

Posted by Alice Ryhl 1 month, 1 week ago

On Fri, Nov 07, 2025 at 10:16:07AM +0100, Danilo Krummrich wrote:
> Commit da123f0ee40f ("rust: lock: guard: Add T: Unpin bound to
> DerefMut") from tip/master adds an Unpin bound to T for Mutex<T>, hence
> also restrict the implementation of BinaryReader for Mutex<T>
> accordingly.
> 
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Closes: https://lore.kernel.org/all/20251107134144.117905bd@canb.auug.org.au/
> Signed-off-by: Danilo Krummrich <dakr@kernel.org>

Reviewed-by: Alice Ryhl <aliceryhl@google.com>