[PATCH v1] Bluetooth: btusb: add new custom firmwares

Shuai Zhang posted 1 patch 3 months ago
There is a newer version of this series
drivers/bluetooth/btusb.c | 1 +
1 file changed, 1 insertion(+)
[PATCH v1] Bluetooth: btusb: add new custom firmwares
Posted by Shuai Zhang 3 months ago
There are custom-made firmwares based on board ID for a given QCA BT
chip sometimes, and they are different with existing firmwares and put
in a separate subdirectory to avoid conflict, for example:
QCA2066, as a variant of WCN6855, has firmwares under 'qca/QCA2066/'
of linux-firmware repository.

Cc: stable@vger.kernel.org
Signed-off-by: Shuai Zhang <quic_shuaz@quicinc.com>
---
 drivers/bluetooth/btusb.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index dcbff7641..7175e9b2d 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -3273,6 +3273,7 @@ static const struct qca_device_info qca_devices_table[] = {
 
 static const struct qca_custom_firmware qca_custom_btfws[] = {
 	{ 0x00130201, 0x030A, "QCA2066" },
+	{ 0x00130201, 0x030B, "QCA2066" },
 	{ },
 };
 
-- 
2.34.1
Re: [PATCH v1] Bluetooth: btusb: add new custom firmwares
Posted by Dmitry Baryshkov 3 months ago
On Fri, Nov 07, 2025 at 10:13:45AM +0800, Shuai Zhang wrote:
> There are custom-made firmwares based on board ID for a given QCA BT
> chip sometimes, and they are different with existing firmwares and put
> in a separate subdirectory to avoid conflict, for example:
> QCA2066, as a variant of WCN6855, has firmwares under 'qca/QCA2066/'
> of linux-firmware repository.

These are generic phrases regarding QCA2066. Describe why and what is
done in the patch (e.g. why do you add new entry to that table).

> 
> Cc: stable@vger.kernel.org

There is little point for CC'ing stable if this is not a fix (and it's
not, it lacks a corresponding tag).

> Signed-off-by: Shuai Zhang <quic_shuaz@quicinc.com>

Please migrate to the @oss.qualcomm.com address.

> ---
>  drivers/bluetooth/btusb.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> index dcbff7641..7175e9b2d 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -3273,6 +3273,7 @@ static const struct qca_device_info qca_devices_table[] = {
>  
>  static const struct qca_custom_firmware qca_custom_btfws[] = {
>  	{ 0x00130201, 0x030A, "QCA2066" },
> +	{ 0x00130201, 0x030B, "QCA2066" },
>  	{ },
>  };
>  
> -- 
> 2.34.1
> 

-- 
With best wishes
Dmitry
Re: [PATCH v1] Bluetooth: btusb: add new custom firmwares
Posted by Shuai Zhang 3 months ago
Hi Dmitry

On 11/7/2025 11:13 AM, Dmitry Baryshkov wrote:
> On Fri, Nov 07, 2025 at 10:13:45AM +0800, Shuai Zhang wrote:
>> There are custom-made firmwares based on board ID for a given QCA BT
>> chip sometimes, and they are different with existing firmwares and put
>> in a separate subdirectory to avoid conflict, for example:
>> QCA2066, as a variant of WCN6855, has firmwares under 'qca/QCA2066/'
>> of linux-firmware repository.
> 
> These are generic phrases regarding QCA2066. Describe why and what is
> done in the patch (e.g. why do you add new entry to that table).
> 
>>
>> Cc: stable@vger.kernel.org
> 
> There is little point for CC'ing stable if this is not a fix (and it's
> not, it lacks a corresponding tag).
> 

I tried not adding Cc: stable@vger.kernel.org, but this question occurred.

FYI: kernel test robot notices the stable kernel rule is not satisfied.

The check is based on https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html#option-1

Rule: add the tag "Cc: stable@vger.kernel.org" in the sign-off area to have the patch automatically included in the stable tree."



>> Signed-off-by: Shuai Zhang <quic_shuaz@quicinc.com>
> 
> Please migrate to the @oss.qualcomm.com address.

I am currently submitting an application for an OSS account.

> 
>> ---
>>  drivers/bluetooth/btusb.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
>> index dcbff7641..7175e9b2d 100644
>> --- a/drivers/bluetooth/btusb.c
>> +++ b/drivers/bluetooth/btusb.c
>> @@ -3273,6 +3273,7 @@ static const struct qca_device_info qca_devices_table[] = {
>>  
>>  static const struct qca_custom_firmware qca_custom_btfws[] = {
>>  	{ 0x00130201, 0x030A, "QCA2066" },
>> +	{ 0x00130201, 0x030B, "QCA2066" },
>>  	{ },
>>  };
>>  
>> -- 
>> 2.34.1
>>
> 

Best,regard
Shuai