1. Patchew
  2. linux
  3. [PATCH v2 00/11] arm64: dts: add description for solidrun imx8mp hummingboard-iiot
  4. View patch

[PATCH v2 02/11] dt-bindings: display: panel: ronbo,rb070d30: panel-common ref

Josua Mayer posted 11 patches 1 month, 1 week ago
There is a newer version of this series
[PATCH v2 02/11] dt-bindings: display: panel: ronbo,rb070d30: panel-common ref
Posted by Josua Mayer 1 month, 1 week ago 
Add missing ref on panel-common.yaml for this dsi panel so that common
properties can be shared.

Drop reset-gpios and backlight as they are already in panel-common.

Switch from additionalProperties to unevaluatedProperties so that common
panel properties are available without repeating them in this binding.

Notably panel-common defines the "port" property for linking panels to a
source - which was missing from this panel. Mark it as required.

Signed-off-by: Josua Mayer <josua@solid-run.com>
---
 .../devicetree/bindings/display/panel/ronbo,rb070d30.yaml  | 14 +++++---------
 1 file changed, 5 insertions(+), 9 deletions(-)

diff --git a/Documentation/devicetree/bindings/display/panel/ronbo,rb070d30.yaml b/Documentation/devicetree/bindings/display/panel/ronbo,rb070d30.yaml
index 04f86e0cbac91..6940373015833 100644
--- a/Documentation/devicetree/bindings/display/panel/ronbo,rb070d30.yaml
+++ b/Documentation/devicetree/bindings/display/panel/ronbo,rb070d30.yaml
@@ -9,6 +9,9 @@ title: Ronbo RB070D30 DSI Display Panel
 maintainers:
   - Maxime Ripard <mripard@kernel.org>
 
+allOf:
+  - $ref: panel-common.yaml#
+
 properties:
   compatible:
     const: ronbo,rb070d30
@@ -20,10 +23,6 @@ properties:
     description: GPIO used for the power pin
     maxItems: 1
 
-  reset-gpios:
-    description: GPIO used for the reset pin
-    maxItems: 1
-
   shlr-gpios:
     description: GPIO used for the shlr pin (horizontal flip)
     maxItems: 1
@@ -35,10 +34,6 @@ properties:
   vcc-lcd-supply:
     description: Power regulator
 
-  backlight:
-    description: Backlight used by the panel
-    $ref: /schemas/types.yaml#/definitions/phandle
-
 required:
   - compatible
   - power-gpios
@@ -47,5 +42,6 @@ required:
   - shlr-gpios
   - updn-gpios
   - vcc-lcd-supply
+  - port
 
-additionalProperties: false
+unevaluatedProperties: false

-- 
2.51.0
Re: [PATCH v2 02/11] dt-bindings: display: panel: ronbo,rb070d30: panel-common ref
Posted by Conor Dooley 1 month, 1 week ago 
On Fri, Nov 07, 2025 at 12:46:09PM +0100, Josua Mayer wrote:
> Add missing ref on panel-common.yaml for this dsi panel so that common
> properties can be shared.
> 
> Drop reset-gpios and backlight as they are already in panel-common.
> 
> Switch from additionalProperties to unevaluatedProperties so that common
> panel properties are available without repeating them in this binding.
> 
> Notably panel-common defines the "port" property for linking panels to a
> source - which was missing from this panel. Mark it as required.
> 
> Signed-off-by: Josua Mayer <josua@solid-run.com>

Acked-by: Conor Dooley <conor.dooley@microchip.com>
pw-bot: not-applicable
Re: [PATCH v2 02/11] dt-bindings: display: panel: ronbo,rb070d30: panel-common ref
Posted by Josua Mayer 1 month, 1 week ago 
Hi Conor,

Am 07.11.25 um 18:48 schrieb Conor Dooley:
> On Fri, Nov 07, 2025 at 12:46:09PM +0100, Josua Mayer wrote:
>> Add missing ref on panel-common.yaml for this dsi panel so that common
>> properties can be shared.
>>
>> Drop reset-gpios and backlight as they are already in panel-common.
>>
>> Switch from additionalProperties to unevaluatedProperties so that common
>> panel properties are available without repeating them in this binding.
>>
>> Notably panel-common defines the "port" property for linking panels to a
>> source - which was missing from this panel. Mark it as required.
>>
>> Signed-off-by: Josua Mayer <josua@solid-run.com>
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
Is your ack compatible with Frank Li requesting to move the
ref on panel-common further towards the end of the file?
> pw-bot: not-applicable
Re: [PATCH v2 02/11] dt-bindings: display: panel: ronbo,rb070d30: panel-common ref
Posted by Conor Dooley 1 month, 1 week ago 
On Wed, Nov 12, 2025 at 11:51:55AM +0000, Josua Mayer wrote:
> Hi Conor,
> 
> Am 07.11.25 um 18:48 schrieb Conor Dooley:
> > On Fri, Nov 07, 2025 at 12:46:09PM +0100, Josua Mayer wrote:
> >> Add missing ref on panel-common.yaml for this dsi panel so that common
> >> properties can be shared.
> >>
> >> Drop reset-gpios and backlight as they are already in panel-common.
> >>
> >> Switch from additionalProperties to unevaluatedProperties so that common
> >> panel properties are available without repeating them in this binding.
> >>
> >> Notably panel-common defines the "port" property for linking panels to a
> >> source - which was missing from this panel. Mark it as required.
> >>
> >> Signed-off-by: Josua Mayer <josua@solid-run.com>
> > Acked-by: Conor Dooley <conor.dooley@microchip.com>
> Is your ack compatible with Frank Li requesting to move the
> ref on panel-common further towards the end of the file?

I don't care what you do with that. I will say that it is pretty normal
to have it at the top of the file and move it if there ends up being a
need, and it's not worth resubmitting for that alone.
Re: [PATCH v2 02/11] dt-bindings: display: panel: ronbo,rb070d30: panel-common ref
Posted by Frank Li 1 month, 1 week ago 
On Fri, Nov 07, 2025 at 12:46:09PM +0100, Josua Mayer wrote:
> Add missing ref on panel-common.yaml for this dsi panel so that common
> properties can be shared.
>
> Drop reset-gpios and backlight as they are already in panel-common.
>
> Switch from additionalProperties to unevaluatedProperties so that common
> panel properties are available without repeating them in this binding.
>
> Notably panel-common defines the "port" property for linking panels to a
> source - which was missing from this panel. Mark it as required.
>
> Signed-off-by: Josua Mayer <josua@solid-run.com>
> ---
>  .../devicetree/bindings/display/panel/ronbo,rb070d30.yaml  | 14 +++++---------
>  1 file changed, 5 insertions(+), 9 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/panel/ronbo,rb070d30.yaml b/Documentation/devicetree/bindings/display/panel/ronbo,rb070d30.yaml
> index 04f86e0cbac91..6940373015833 100644
> --- a/Documentation/devicetree/bindings/display/panel/ronbo,rb070d30.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/ronbo,rb070d30.yaml
> @@ -9,6 +9,9 @@ title: Ronbo RB070D30 DSI Display Panel
>  maintainers:
>    - Maxime Ripard <mripard@kernel.org>
>
> +allOf:
> +  - $ref: panel-common.yaml#
> +

Can you move allof after required incase add if-else branch later.

Frank
>  properties:
>    compatible:
>      const: ronbo,rb070d30
> @@ -20,10 +23,6 @@ properties:
>      description: GPIO used for the power pin
>      maxItems: 1
>
> -  reset-gpios:
> -    description: GPIO used for the reset pin
> -    maxItems: 1
> -
>    shlr-gpios:
>      description: GPIO used for the shlr pin (horizontal flip)
>      maxItems: 1
> @@ -35,10 +34,6 @@ properties:
>    vcc-lcd-supply:
>      description: Power regulator
>
> -  backlight:
> -    description: Backlight used by the panel
> -    $ref: /schemas/types.yaml#/definitions/phandle
> -
>  required:
>    - compatible
>    - power-gpios
> @@ -47,5 +42,6 @@ required:
>    - shlr-gpios
>    - updn-gpios
>    - vcc-lcd-supply
> +  - port
>
> -additionalProperties: false
> +unevaluatedProperties: false
>
> --
> 2.51.0
>
Re: [PATCH v2 02/11] dt-bindings: display: panel: ronbo,rb070d30: panel-common ref
Posted by Josua Mayer 1 month, 1 week ago 
Am 07.11.25 um 16:53 schrieb Frank Li:
> On Fri, Nov 07, 2025 at 12:46:09PM +0100, Josua Mayer wrote:
>> Add missing ref on panel-common.yaml for this dsi panel so that common
>> properties can be shared.
>>
>> Drop reset-gpios and backlight as they are already in panel-common.
>>
>> Switch from additionalProperties to unevaluatedProperties so that common
>> panel properties are available without repeating them in this binding.
>>
>> Notably panel-common defines the "port" property for linking panels to a
>> source - which was missing from this panel. Mark it as required.
>>
>> Signed-off-by: Josua Mayer <josua@solid-run.com>
>> ---
>>  .../devicetree/bindings/display/panel/ronbo,rb070d30.yaml  | 14 +++++---------
>>  1 file changed, 5 insertions(+), 9 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/display/panel/ronbo,rb070d30.yaml b/Documentation/devicetree/bindings/display/panel/ronbo,rb070d30.yaml
>> index 04f86e0cbac91..6940373015833 100644
>> --- a/Documentation/devicetree/bindings/display/panel/ronbo,rb070d30.yaml
>> +++ b/Documentation/devicetree/bindings/display/panel/ronbo,rb070d30.yaml
>> @@ -9,6 +9,9 @@ title: Ronbo RB070D30 DSI Display Panel
>>  maintainers:
>>    - Maxime Ripard <mripard@kernel.org>
>>
>> +allOf:
>> +  - $ref: panel-common.yaml#
>> +
> Can you move allof after required incase add if-else branch later.

Do you mean at the very end just before unevaluatedProperties?

I have no strong opinion there but most panel bindings reference panel-common
at the very beginning, after maintainers or description.

>
> Frank
>>  properties:
>>    compatible:
>>      const: ronbo,rb070d30
>> @@ -20,10 +23,6 @@ properties:
>>      description: GPIO used for the power pin
>>      maxItems: 1
>>
>> -  reset-gpios:
>> -    description: GPIO used for the reset pin
>> -    maxItems: 1
>> -
>>    shlr-gpios:
>>      description: GPIO used for the shlr pin (horizontal flip)
>>      maxItems: 1
>> @@ -35,10 +34,6 @@ properties:
>>    vcc-lcd-supply:
>>      description: Power regulator
>>
>> -  backlight:
>> -    description: Backlight used by the panel
>> -    $ref: /schemas/types.yaml#/definitions/phandle
>> -
>>  required:
>>    - compatible
>>    - power-gpios
>> @@ -47,5 +42,6 @@ required:
>>    - shlr-gpios
>>    - updn-gpios
>>    - vcc-lcd-supply
>> +  - port
>>
>> -additionalProperties: false
>> +unevaluatedProperties: false
>>
>> --
>> 2.51.0
>>

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.