[PATCH v3 4/5] dt-bindings: arm: airoha: Add the chip-scu node for AN7583 SoC

Christian Marangi posted 5 patches 1 month, 1 week ago
[PATCH v3 4/5] dt-bindings: arm: airoha: Add the chip-scu node for AN7583 SoC
Posted by Christian Marangi 1 month, 1 week ago
Document support for Airoha AN7583 chip-scu node.

This is similar to Airoha EN7581 with the addition of the presence of
thermal sensor in addition to controlling HW PIN and other miscellaneous
pheriperals.

Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
---
 .../bindings/arm/airoha,en7581-chip-scu.yaml       | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/airoha,en7581-chip-scu.yaml b/Documentation/devicetree/bindings/arm/airoha,en7581-chip-scu.yaml
index 67c449d804c2..0d042fb90a78 100644
--- a/Documentation/devicetree/bindings/arm/airoha,en7581-chip-scu.yaml
+++ b/Documentation/devicetree/bindings/arm/airoha,en7581-chip-scu.yaml
@@ -18,16 +18,30 @@ properties:
   compatible:
     items:
       - enum:
+          - airoha,an7583-chip-scu
           - airoha,en7581-chip-scu
       - const: syscon
 
   reg:
     maxItems: 1
 
+  '#thermal-sensor-cells':
+    const: 0
+
 required:
   - compatible
   - reg
 
+if:
+  properties:
+    compatible:
+      contains:
+        const: airoha,en7581-chip-scu
+
+then:
+  properties:
+    '#thermal-sensor-cells': false
+
 additionalProperties: false
 
 examples:
-- 
2.51.0
Re: [PATCH v3 4/5] dt-bindings: arm: airoha: Add the chip-scu node for AN7583 SoC
Posted by Krzysztof Kozlowski 1 month, 1 week ago
On Thu, Nov 06, 2025 at 11:59:13PM +0100, Christian Marangi wrote:
> Document support for Airoha AN7583 chip-scu node.
> 
> This is similar to Airoha EN7581 with the addition of the presence of
> thermal sensor in addition to controlling HW PIN and other miscellaneous
> pheriperals.
> 
> Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
> ---
>  .../bindings/arm/airoha,en7581-chip-scu.yaml       | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/airoha,en7581-chip-scu.yaml b/Documentation/devicetree/bindings/arm/airoha,en7581-chip-scu.yaml
> index 67c449d804c2..0d042fb90a78 100644
> --- a/Documentation/devicetree/bindings/arm/airoha,en7581-chip-scu.yaml
> +++ b/Documentation/devicetree/bindings/arm/airoha,en7581-chip-scu.yaml
> @@ -18,16 +18,30 @@ properties:
>    compatible:
>      items:
>        - enum:
> +          - airoha,an7583-chip-scu

Again, random order.

>            - airoha,en7581-chip-scu
>        - const: syscon

Best regards,
Krzysztof
Re: [PATCH v3 4/5] dt-bindings: arm: airoha: Add the chip-scu node for AN7583 SoC
Posted by Krzysztof Kozlowski 1 month, 1 week ago
On 07/11/2025 08:45, Krzysztof Kozlowski wrote:
> On Thu, Nov 06, 2025 at 11:59:13PM +0100, Christian Marangi wrote:
>> Document support for Airoha AN7583 chip-scu node.
>>
>> This is similar to Airoha EN7581 with the addition of the presence of
>> thermal sensor in addition to controlling HW PIN and other miscellaneous
>> pheriperals.
>>
>> Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
>> ---
>>  .../bindings/arm/airoha,en7581-chip-scu.yaml       | 14 ++++++++++++++
>>  1 file changed, 14 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/airoha,en7581-chip-scu.yaml b/Documentation/devicetree/bindings/arm/airoha,en7581-chip-scu.yaml
>> index 67c449d804c2..0d042fb90a78 100644
>> --- a/Documentation/devicetree/bindings/arm/airoha,en7581-chip-scu.yaml
>> +++ b/Documentation/devicetree/bindings/arm/airoha,en7581-chip-scu.yaml
>> @@ -18,16 +18,30 @@ properties:
>>    compatible:
>>      items:
>>        - enum:
>> +          - airoha,an7583-chip-scu
> 
> Again, random order.

D'oh! That's a correct order. Missed a/e difference.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof