[PATCH 1/2] fpga: stratix10-soc: add missing header

Rosen Penev posted 2 patches 1 month, 1 week ago
[PATCH 1/2] fpga: stratix10-soc: add missing header
Posted by Rosen Penev 1 month, 1 week ago
linux/sizes.h is needed for SZ_512K.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
 drivers/fpga/stratix10-soc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/fpga/stratix10-soc.c b/drivers/fpga/stratix10-soc.c
index 0a295ccf1644..ab309cbf21c6 100644
--- a/drivers/fpga/stratix10-soc.c
+++ b/drivers/fpga/stratix10-soc.c
@@ -11,6 +11,7 @@
 #include <linux/of.h>
 #include <linux/of_platform.h>
 #include <linux/platform_device.h>
+#include <linux/sizes.h>
 
 /*
  * FPGA programming requires a higher level of privilege (EL3), per the SoC
-- 
2.51.2
Re: [PATCH 1/2] fpga: stratix10-soc: add missing header
Posted by Xu Yilun 1 month, 1 week ago
On Thu, Nov 06, 2025 at 10:59:37AM -0800, Rosen Penev wrote:
> linux/sizes.h is needed for SZ_512K.

Does it always fail or only with COMPILE_TEST?

Please add "fixes" & Cc stable kernel if it always fail.

> 
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
> ---
>  drivers/fpga/stratix10-soc.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/fpga/stratix10-soc.c b/drivers/fpga/stratix10-soc.c
> index 0a295ccf1644..ab309cbf21c6 100644
> --- a/drivers/fpga/stratix10-soc.c
> +++ b/drivers/fpga/stratix10-soc.c
> @@ -11,6 +11,7 @@
>  #include <linux/of.h>
>  #include <linux/of_platform.h>
>  #include <linux/platform_device.h>
> +#include <linux/sizes.h>
>  
>  /*
>   * FPGA programming requires a higher level of privilege (EL3), per the SoC
> -- 
> 2.51.2
> 
>
Re: [PATCH 1/2] fpga: stratix10-soc: add missing header
Posted by Rosen Penev 1 month, 1 week ago
On Thu, Nov 6, 2025 at 11:12 PM Xu Yilun <yilun.xu@linux.intel.com> wrote:
>
> On Thu, Nov 06, 2025 at 10:59:37AM -0800, Rosen Penev wrote:
> > linux/sizes.h is needed for SZ_512K.
>
> Does it always fail or only with COMPILE_TEST?
Well, COMPILE_TEST under x86. If I had to guess, this header gets
included from some ARM header.
>
> Please add "fixes" & Cc stable kernel if it always fail.
>
> >
> > Signed-off-by: Rosen Penev <rosenp@gmail.com>
> > ---
> >  drivers/fpga/stratix10-soc.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/fpga/stratix10-soc.c b/drivers/fpga/stratix10-soc.c
> > index 0a295ccf1644..ab309cbf21c6 100644
> > --- a/drivers/fpga/stratix10-soc.c
> > +++ b/drivers/fpga/stratix10-soc.c
> > @@ -11,6 +11,7 @@
> >  #include <linux/of.h>
> >  #include <linux/of_platform.h>
> >  #include <linux/platform_device.h>
> > +#include <linux/sizes.h>
> >
> >  /*
> >   * FPGA programming requires a higher level of privilege (EL3), per the SoC
> > --
> > 2.51.2
> >
> >