[v1] hid/hid-multitouch: Keep latency normal on deactivate for reactivation gesture

[PATCH] hid/hid-multitouch: Keep latency normal on deactivate for reactivation gesture

Posted by Werner Sembach 1 month, 1 week ago

Uniwill devices have a built in gesture in the touchpad to de- and
reactivate it by double taping the upper left corner. This gesture stops
working when latency is set to high, so this patch keeps the latency on
normal.

Signed-off-by: Werner Sembach <wse@tuxedocomputers.com>
---
Or should I better implement this as a quirk?

 drivers/hid/hid-multitouch.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
index 179dc316b4b51..df64cb6c41699 100644
--- a/drivers/hid/hid-multitouch.c
+++ b/drivers/hid/hid-multitouch.c
@@ -1998,7 +1998,7 @@ static void mt_on_hid_hw_open(struct hid_device *hdev)
 
 static void mt_on_hid_hw_close(struct hid_device *hdev)
 {
-	mt_set_modes(hdev, HID_LATENCY_HIGH, TOUCHPAD_REPORT_NONE);
+	mt_set_modes(hdev, HID_LATENCY_NORMAL, TOUCHPAD_REPORT_NONE);
 }
 
 /*
-- 
2.43.0

Re: [PATCH] hid/hid-multitouch: Keep latency normal on deactivate for reactivation gesture

Posted by Benjamin Tissoires 1 month, 1 week ago

On Nov 06 2025, Werner Sembach wrote:
> Uniwill devices have a built in gesture in the touchpad to de- and
> reactivate it by double taping the upper left corner. This gesture stops
> working when latency is set to high, so this patch keeps the latency on
> normal.
> 
> Signed-off-by: Werner Sembach <wse@tuxedocomputers.com>
> ---
> Or should I better implement this as a quirk?

Yeah, I guess a quirk would be appreciated. The high latency on close
was introduced on purpose for saving energy purpose. So this patch is
rather not nice for those systems where it matters.

Cheers,
Benjamin

> 
>  drivers/hid/hid-multitouch.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
> index 179dc316b4b51..df64cb6c41699 100644
> --- a/drivers/hid/hid-multitouch.c
> +++ b/drivers/hid/hid-multitouch.c
> @@ -1998,7 +1998,7 @@ static void mt_on_hid_hw_open(struct hid_device *hdev)
>  
>  static void mt_on_hid_hw_close(struct hid_device *hdev)
>  {
> -	mt_set_modes(hdev, HID_LATENCY_HIGH, TOUCHPAD_REPORT_NONE);
> +	mt_set_modes(hdev, HID_LATENCY_NORMAL, TOUCHPAD_REPORT_NONE);
>  }
>  
>  /*
> -- 
> 2.43.0
>

Re: [PATCH] hid/hid-multitouch: Keep latency normal on deactivate for reactivation gesture

Posted by Werner Sembach 1 month, 1 week ago

Am 06.11.25 um 17:50 schrieb Benjamin Tissoires:
> On Nov 06 2025, Werner Sembach wrote:
>> Uniwill devices have a built in gesture in the touchpad to de- and
>> reactivate it by double taping the upper left corner. This gesture stops
>> working when latency is set to high, so this patch keeps the latency on
>> normal.
>>
>> Signed-off-by: Werner Sembach <wse@tuxedocomputers.com>
>> ---
>> Or should I better implement this as a quirk?
> Yeah, I guess a quirk would be appreciated. The high latency on close
> was introduced on purpose for saving energy purpose. So this patch is
> rather not nice for those systems where it matters.

ack

v2 incoming

>
> Cheers,
> Benjamin
>
>>   drivers/hid/hid-multitouch.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
>> index 179dc316b4b51..df64cb6c41699 100644
>> --- a/drivers/hid/hid-multitouch.c
>> +++ b/drivers/hid/hid-multitouch.c
>> @@ -1998,7 +1998,7 @@ static void mt_on_hid_hw_open(struct hid_device *hdev)
>>   
>>   static void mt_on_hid_hw_close(struct hid_device *hdev)
>>   {
>> -	mt_set_modes(hdev, HID_LATENCY_HIGH, TOUCHPAD_REPORT_NONE);
>> +	mt_set_modes(hdev, HID_LATENCY_NORMAL, TOUCHPAD_REPORT_NONE);
>>   }
>>   
>>   /*
>> -- 
>> 2.43.0
>>

Re: [PATCH] hid/hid-multitouch: Keep latency normal on deactivate for reactivation gesture

Posted by Werner Sembach 1 month, 1 week ago

Am 06.11.25 um 16:45 schrieb Werner Sembach:
> Uniwill devices have a built in gesture in the touchpad to de- and
> reactivate it by double taping the upper left corner. This gesture stops
> working when latency is set to high, so this patch keeps the latency on
> normal.
>
> Signed-off-by: Werner Sembach <wse@tuxedocomputers.com>
Forgot again to add cc stable, please add it if the patch gets accepted.
> ---
> Or should I better implement this as a quirk?
>
>   drivers/hid/hid-multitouch.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
> index 179dc316b4b51..df64cb6c41699 100644
> --- a/drivers/hid/hid-multitouch.c
> +++ b/drivers/hid/hid-multitouch.c
> @@ -1998,7 +1998,7 @@ static void mt_on_hid_hw_open(struct hid_device *hdev)
>   
>   static void mt_on_hid_hw_close(struct hid_device *hdev)
>   {
> -	mt_set_modes(hdev, HID_LATENCY_HIGH, TOUCHPAD_REPORT_NONE);
> +	mt_set_modes(hdev, HID_LATENCY_NORMAL, TOUCHPAD_REPORT_NONE);
>   }
>   
>   /*