From: Riccardo Mereu <r.mereu.kernel@arduino.cc>

Document Arduino UnoQ. Arduino UnoQ is a single-board computer
combining Qualcomm Dragonwing™ QRB2210 microprocessor with
STMicroelectronics STM32U585 microcontroller.

Signed-off-by: Riccardo Mereu <r.mereu@arduino.cc>
---
 Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index d84bd3bca201..1af19245b1d5 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -336,6 +336,7 @@ properties:
       - description: Qualcomm Technologies, Inc. Robotics RB1
         items:
           - enum:
+              - arduino,imola
               - qcom,qrb2210-rb1
           - const: qcom,qrb2210
           - const: qcom,qcm2290
-- 
2.51.2

On 06/11/2025 16:31, Riccardo Mereu wrote:
> From: Riccardo Mereu <r.mereu.kernel@arduino.cc>
> 
> Document Arduino UnoQ. Arduino UnoQ is a single-board computer

compatible says imola, not unoq.

> combining Qualcomm Dragonwing™ QRB2210 microprocessor with
> STMicroelectronics STM32U585 microcontroller.
> 
> Signed-off-by: Riccardo Mereu <r.mereu@arduino.cc>
> ---


Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching. For bindings, the preferred subjects are
explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters


Best regards,
Krzysztof

On Fri, Nov 07, 2025 at 08:13:48AM +0100, Krzysztof Kozlowski wrote:
> On 06/11/2025 16:31, Riccardo Mereu wrote:
> > From: Riccardo Mereu <r.mereu.kernel@arduino.cc>
> > 
> > Document Arduino UnoQ. Arduino UnoQ is a single-board computer
> 
> compatible says imola, not unoq.

And compatibles for various ChromeBooks also use codenames. I think it's
not the first time the vendor uses a codename instead of the marketing
name inside the compat string.

> 
> > combining Qualcomm Dragonwing™ QRB2210 microprocessor with
> > STMicroelectronics STM32U585 microcontroller.
> > 
> > Signed-off-by: Riccardo Mereu <r.mereu@arduino.cc>
> > ---
> 
> 
> Please use subject prefixes matching the subsystem. You can get them for
> example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
> your patch is touching. For bindings, the preferred subjects are
> explained here:
> https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters
> 
> 
> Best regards,
> Krzysztof

-- 
With best wishes
Dmitry

On 11/11/2025 13:27, Dmitry Baryshkov wrote:
> On Fri, Nov 07, 2025 at 08:13:48AM +0100, Krzysztof Kozlowski wrote:
>> On 06/11/2025 16:31, Riccardo Mereu wrote:
>>> From: Riccardo Mereu <r.mereu.kernel@arduino.cc>
>>>
>>> Document Arduino UnoQ. Arduino UnoQ is a single-board computer
>>
>> compatible says imola, not unoq.
> 
> And compatibles for various ChromeBooks also use codenames. I think it's
> not the first time the vendor uses a codename instead of the marketing
> name inside the compat string.

And that's why we have commit msg to explain anything which is not
obvious...

Best regards,
Krzysztof

On Tue, Nov 11, 2025 at 02:27:03PM +0200, Dmitry Baryshkov wrote:
> On Fri, Nov 07, 2025 at 08:13:48AM +0100, Krzysztof Kozlowski wrote:
> > On 06/11/2025 16:31, Riccardo Mereu wrote:
> > > From: Riccardo Mereu <r.mereu.kernel@arduino.cc>
> > > 
> > > Document Arduino UnoQ. Arduino UnoQ is a single-board computer
> > 
> > compatible says imola, not unoq.
> 
> And compatibles for various ChromeBooks also use codenames. I think it's
> not the first time the vendor uses a codename instead of the marketing
> name inside the compat string.
> 

I appreciate the use of the codename, but both subject and commit
message is talking about "UnoQ" only and then "imola" shows up only in
the patch.

@Riccardo, please introduce "imola" in the commit message, so we know
what it is.

Regards,
Bjorn

> > 
> > > combining Qualcomm Dragonwing™ QRB2210 microprocessor with
> > > STMicroelectronics STM32U585 microcontroller.
> > > 
> > > Signed-off-by: Riccardo Mereu <r.mereu@arduino.cc>
> > > ---
> > 
> > 
> > Please use subject prefixes matching the subsystem. You can get them for
> > example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
> > your patch is touching. For bindings, the preferred subjects are
> > explained here:
> > https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters
> > 
> > 
> > Best regards,
> > Krzysztof
> 
> -- 
> With best wishes
> Dmitry