[v3] Add support for MT8189 clock/power controller

[PATCH v3 02/21] dt-bindings: power: mediatek: Add MT8189 power domain definitions

Posted by irving.ch.lin 1 month, 1 week ago

From: Irving-CH Lin <irving-ch.lin@mediatek.com>

Add device tree bindings for the power domains of MediaTek MT8189 SoC.

Signed-off-by: Irving-CH Lin <irving-ch.lin@mediatek.com>
---
 .../power/mediatek,power-controller.yaml      |  1 +
 .../dt-bindings/power/mediatek,mt8189-power.h | 38 +++++++++++++++++++
 2 files changed, 39 insertions(+)
 create mode 100644 include/dt-bindings/power/mediatek,mt8189-power.h

diff --git a/Documentation/devicetree/bindings/power/mediatek,power-controller.yaml b/Documentation/devicetree/bindings/power/mediatek,power-controller.yaml
index f8a13928f615..443c227c0e51 100644
--- a/Documentation/devicetree/bindings/power/mediatek,power-controller.yaml
+++ b/Documentation/devicetree/bindings/power/mediatek,power-controller.yaml
@@ -31,6 +31,7 @@ properties:
       - mediatek,mt8183-power-controller
       - mediatek,mt8186-power-controller
       - mediatek,mt8188-power-controller
+      - mediatek,mt8189-power-controller
       - mediatek,mt8192-power-controller
       - mediatek,mt8195-power-controller
       - mediatek,mt8196-hwv-hfrp-power-controller
diff --git a/include/dt-bindings/power/mediatek,mt8189-power.h b/include/dt-bindings/power/mediatek,mt8189-power.h
new file mode 100644
index 000000000000..70a8c2113457
--- /dev/null
+++ b/include/dt-bindings/power/mediatek,mt8189-power.h
@@ -0,0 +1,38 @@
+/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
+/*
+ * Copyright (c) 2025 MediaTek Inc.
+ * Author: Qiqi Wang <qiqi.wang@mediatek.com>
+ */
+
+#ifndef _DT_BINDINGS_POWER_MT8189_POWER_H
+#define _DT_BINDINGS_POWER_MT8189_POWER_H
+
+/* SPM */
+#define MT8189_POWER_DOMAIN_CONN			0
+#define MT8189_POWER_DOMAIN_AUDIO			1
+#define MT8189_POWER_DOMAIN_ADSP_TOP_DORMANT		2
+#define MT8189_POWER_DOMAIN_ADSP_INFRA			3
+#define MT8189_POWER_DOMAIN_ADSP_AO			4
+#define MT8189_POWER_DOMAIN_MM_INFRA			5
+#define MT8189_POWER_DOMAIN_ISP_IMG1			6
+#define MT8189_POWER_DOMAIN_ISP_IMG2			7
+#define MT8189_POWER_DOMAIN_ISP_IPE			8
+#define MT8189_POWER_DOMAIN_VDE0			9
+#define MT8189_POWER_DOMAIN_VEN0			10
+#define MT8189_POWER_DOMAIN_CAM_MAIN			11
+#define MT8189_POWER_DOMAIN_CAM_SUBA			12
+#define MT8189_POWER_DOMAIN_CAM_SUBB			13
+#define MT8189_POWER_DOMAIN_MDP0			14
+#define MT8189_POWER_DOMAIN_DISP			15
+#define MT8189_POWER_DOMAIN_DP_TX			16
+#define MT8189_POWER_DOMAIN_CSI_RX			17
+#define MT8189_POWER_DOMAIN_SSUSB			18
+#define MT8189_POWER_DOMAIN_MFG0			19
+#define MT8189_POWER_DOMAIN_MFG1			20
+#define MT8189_POWER_DOMAIN_MFG2			21
+#define MT8189_POWER_DOMAIN_MFG3			22
+#define MT8189_POWER_DOMAIN_EDP_TX_DORMANT		23
+#define MT8189_POWER_DOMAIN_PCIE			24
+#define MT8189_POWER_DOMAIN_PCIE_PHY			25
+
+#endif /* _DT_BINDINGS_POWER_MT8189_POWER_H */
-- 
2.45.2

Re: [PATCH v3 02/21] dt-bindings: power: mediatek: Add MT8189 power domain definitions

Posted by Rob Herring (Arm) 1 month, 1 week ago

On Thu, 06 Nov 2025 20:41:47 +0800, irving.ch.lin wrote:
> From: Irving-CH Lin <irving-ch.lin@mediatek.com>
> 
> Add device tree bindings for the power domains of MediaTek MT8189 SoC.
> 
> Signed-off-by: Irving-CH Lin <irving-ch.lin@mediatek.com>
> ---
>  .../power/mediatek,power-controller.yaml      |  1 +
>  .../dt-bindings/power/mediatek,mt8189-power.h | 38 +++++++++++++++++++
>  2 files changed, 39 insertions(+)
>  create mode 100644 include/dt-bindings/power/mediatek,mt8189-power.h
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:
./Documentation/devicetree/bindings/clock/mediatek,mt8189-clock.yaml:25:9: [warning] wrong indentation: expected 10 but found 8 (indentation)

dtschema/dtc warnings/errors:

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20251106124330.1145600-3-irving-ch.lin@mediatek.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.

Re: [PATCH v3 02/21] dt-bindings: power: mediatek: Add MT8189 power domain definitions

Posted by Conor Dooley 1 month, 1 week ago

On Thu, Nov 06, 2025 at 07:34:37AM -0600, Rob Herring (Arm) wrote:
> 
> On Thu, 06 Nov 2025 20:41:47 +0800, irving.ch.lin wrote:
> > From: Irving-CH Lin <irving-ch.lin@mediatek.com>
> > 
> > Add device tree bindings for the power domains of MediaTek MT8189 SoC.
> > 
> > Signed-off-by: Irving-CH Lin <irving-ch.lin@mediatek.com>
> > ---
> >  .../power/mediatek,power-controller.yaml      |  1 +
> >  .../dt-bindings/power/mediatek,mt8189-power.h | 38 +++++++++++++++++++
> >  2 files changed, 39 insertions(+)
> >  create mode 100644 include/dt-bindings/power/mediatek,mt8189-power.h
> > 
> 
> My bot found errors running 'make dt_binding_check' on your patch:
> 
> yamllint warnings/errors:
> ./Documentation/devicetree/bindings/clock/mediatek,mt8189-clock.yaml:25:9: [warning] wrong indentation: expected 10 but found 8 (indentation)

pw-bot: changes-requested

Re: [PATCH v3 02/21] dt-bindings: power: mediatek: Add MT8189 power domain definitions

Posted by Krzysztof Kozlowski 1 month, 1 week ago

On Thu, Nov 06, 2025 at 05:17:39PM +0000, Conor Dooley wrote:
> On Thu, Nov 06, 2025 at 07:34:37AM -0600, Rob Herring (Arm) wrote:
> > 
> > On Thu, 06 Nov 2025 20:41:47 +0800, irving.ch.lin wrote:
> > > From: Irving-CH Lin <irving-ch.lin@mediatek.com>
> > > 
> > > Add device tree bindings for the power domains of MediaTek MT8189 SoC.
> > > 
> > > Signed-off-by: Irving-CH Lin <irving-ch.lin@mediatek.com>
> > > ---
> > >  .../power/mediatek,power-controller.yaml      |  1 +
> > >  .../dt-bindings/power/mediatek,mt8189-power.h | 38 +++++++++++++++++++
> > >  2 files changed, 39 insertions(+)
> > >  create mode 100644 include/dt-bindings/power/mediatek,mt8189-power.h
> > > 
> > 
> > My bot found errors running 'make dt_binding_check' on your patch:
> > 
> > yamllint warnings/errors:
> > ./Documentation/devicetree/bindings/clock/mediatek,mt8189-clock.yaml:25:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
> 
> pw-bot: changes-requested

I think this was bot's false positive - that's a different file, not
changed here. The patch seems fine.

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

Re: [PATCH v3 02/21] dt-bindings: power: mediatek: Add MT8189 power domain definitions

Posted by Conor Dooley 1 month, 1 week ago

On Fri, Nov 07, 2025 at 08:26:34AM +0100, Krzysztof Kozlowski wrote:
> On Thu, Nov 06, 2025 at 05:17:39PM +0000, Conor Dooley wrote:
> > On Thu, Nov 06, 2025 at 07:34:37AM -0600, Rob Herring (Arm) wrote:
> > > 
> > > On Thu, 06 Nov 2025 20:41:47 +0800, irving.ch.lin wrote:
> > > > From: Irving-CH Lin <irving-ch.lin@mediatek.com>
> > > > 
> > > > Add device tree bindings for the power domains of MediaTek MT8189 SoC.
> > > > 
> > > > Signed-off-by: Irving-CH Lin <irving-ch.lin@mediatek.com>
> > > > ---
> > > >  .../power/mediatek,power-controller.yaml      |  1 +
> > > >  .../dt-bindings/power/mediatek,mt8189-power.h | 38 +++++++++++++++++++
> > > >  2 files changed, 39 insertions(+)
> > > >  create mode 100644 include/dt-bindings/power/mediatek,mt8189-power.h
> > > > 
> > > 
> > > My bot found errors running 'make dt_binding_check' on your patch:
> > > 
> > > yamllint warnings/errors:
> > > ./Documentation/devicetree/bindings/clock/mediatek,mt8189-clock.yaml:25:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
> > 
> > pw-bot: changes-requested
> 
> I think this was bot's false positive - that's a different file, not
> changed here. The patch seems fine.
> 
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>


Oh dear, my bad! Good thing I sent the mail, so you noticed, rather than
just setting the status in patchwork. I saw "mediatek,mt8189" and read
nothing else in the error, I suppose.